https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-6090 Lustre <p>1. save errno before calling snprintf since that could overwrite errno.</p> LU-6090

DLC: minor cleanup of dlc API code

Bug Minor Resolved Fixed Amir Shehata Amir Shehata Wed, 7 Jan 2015 23:55:22 +0000 Mon, 10 Aug 2015 13:31:19 +0000 Mon, 10 Aug 2015 13:31:19 +0000 Lustre 2.8.0 0 5 <p>Where is the code in question? Is this the user space library?</p> <p>yes in liblnetconfig.c. Reason it's minor is because it will only get reset if there is a problem with the output, which is not likely, but it's good to clean it up, so that we save the errno before calling snprintf, as recommended in: <a href="http://linux.die.net/man/3/errno" class="external-link" target="_blank" rel="nofollow noopener">http://linux.die.net/man/3/errno</a></p> <p>To be paranoid, according to the man page: "a function that succeeds is allowed to change errno". I actually saw it happen once with other library functions. It's always a good idea to save errno if it's needed across function calls.</p> <p>Amir Shehata (amir.shehata@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/15783" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15783</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6090" title="DLC: minor cleanup of dlc API code" class="issue-link" data-issue-key="LU-6090"><del>LU-6090</del></a> lnet: save errno between function calls<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 5c67a6e1cffbadaa2746941084aa30db66feac4d</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/15783/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15783/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6090" title="DLC: minor cleanup of dlc API code" class="issue-link" data-issue-key="LU-6090"><del>LU-6090</del></a> lnet: save errno between function calls<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: f6c886e36d0729b0791e393386e0b4b9c571ce30</p> <p>Landed for 2.8</p> Development Rank 1|hzx3e7: Rank (Obsolete) 16952 Severity