https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-6099 Lustre <p>when CPT parameter is included in YAML output, the value should be enclosed in double quotes (").</p> <p>Currently</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>net: - net: lo nid: 0@lo status: up tunables: peer_timeout: 0 peer_credits: 0 peer_buffer_credits: 0 credits: 0 CPT: [0,0] </pre> </div></div> <p>should be</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>net: - net: lo nid: 0@lo status: up tunables: peer_timeout: 0 peer_credits: 0 peer_buffer_credits: 0 credits: 0 CPT: "[0,0]" </pre> </div></div> LU-6099

DLC: YAML output must adhere to parsing rules

Bug Critical Resolved Fixed Amir Shehata Amir Shehata HB Fri, 9 Jan 2015 00:49:44 +0000 Thu, 12 Feb 2015 00:46:24 +0000 Mon, 12 Jan 2015 18:50:12 +0000 Lustre 2.7.0 0 6 <p>Amir Shehata (amir.shehata@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/13304" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13304</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6099" title="DLC: YAML output must adhere to parsing rules" class="issue-link" data-issue-key="LU-6099"><del>LU-6099</del></a> lnet: correct YAML output<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 71abe659e67129280c8ec58c2782dcb6b1fb86d5</p> <p>Patch fixes the issue.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13304/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13304/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6099" title="DLC: YAML output must adhere to parsing rules" class="issue-link" data-issue-key="LU-6099"><del>LU-6099</del></a> lnet: correct YAML output<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 53cc2a1fe6befcd51826a9b42e8dff9cc33ee8a3</p> <p>Patch landed to Master.</p> <p>I'm not affected by this, but that fix looks strange. It changes CPT from being an array to being a string. Is there any external tool parsing these files too? Because they're likely to break on that new input.</p> <p>Here's for instance how python decodes the test file before and after:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>{'net': [{'status': 'up', 'tunables': {'peer_timeout': 0, 'credits': 0, 'CPT': [0, 0], ... </pre> </div></div> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>{'net': [{'status': 'up', 'tunables': {'peer_timeout': 0, 'credits': 0, 'CPT': '[0,0]', ... </pre> </div></div> <p>I agree with Frank, that seems like an odd choice to me.</p> <p>There is no existing external tools that parse that output. So there is no backwards compatibility issue.</p> <p>the problem as I have explained in the patch is that the yaml 3rd party library that we use does not parse input such as <span class="error">&#91;0,1...&#93;</span>. It has to be enclosed in double quotes. This causes a problem since the output can be without the double quotes, but if you take that output and try to pipe it into lnetctl again (ex: lnetctl import &lt; config.yaml), it'll have a parse error. </p> <p>The requirement that the lnetclt export output has to be usable with lnetctl import, is higher priority than having the CPT parameter as parsable from python. Therefore the above solution was implemented.</p> <p>Another possible solution is to simply have the output as: </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">CPT: 0,1,2 </pre> </div></div> <p>However, that would parse in python as a string as well. So, you'll end up with the same issue.</p> <p>An easy way to deal with this is simply to parse out the CPT output into a list as below</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">YAML output: net: - net: tcp nid: 192.168.205.158@tcp status: up interfaces: 0: eth4 tunables: peer_timeout: 180 peer_credits: 8 peer_buffer_credits: 0 clnetredits: 256 CPT: <span class="code-quote">"[1,0]"</span> Python Interpetation: {<span class="code-quote">'net'</span>: [{<span class="code-quote">'CPT'</span>: <span class="code-quote">'[1,0]'</span>, <span class="code-quote">'interfaces'</span>: {0: <span class="code-quote">'eth4'</span>}, <span class="code-quote">'net'</span>: <span class="code-quote">'tcp'</span>, <span class="code-quote">'nid'</span>: <span class="code-quote">'192.168.205.158@tcp'</span>, <span class="code-quote">'status'</span>: <span class="code-quote">'up'</span>, <span class="code-quote">'tunables'</span>: {<span class="code-quote">'clnetredits'</span>: 256, <span class="code-quote">'peer_buffer_credits'</span>: 0, <span class="code-quote">'peer_credits'</span>: 8, <span class="code-quote">'peer_timeout'</span>: 180}}]} <span class="code-keyword">if</span> we assign the above python expression to a variable x, then you can <span class="code-keyword">do</span> the following cpt_list = x[<span class="code-quote">'net'</span>][0][<span class="code-quote">'CPT'</span>].replace(<span class="code-quote">'['</span>, <span class="code-quote">'').replace('</span>]<span class="code-quote">', '</span><span class="code-quote">').split('</span>,') then you can print items in the list by: <span class="code-object">int</span>(cpt_list[0]) You can also create a loop &gt;&gt;&gt; <span class="code-keyword">for</span> item in cpt_list: ... print <span class="code-object">int</span>(item) </pre> </div></div> <p>If you have a better solution please share it.</p> <p>What about this?</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> CPT: - 0 - 1 - 2 </pre> </div></div> <p>That means if you have over 10 CPTs, which I guess is entirely possible on multicore systems, you'll have something like:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">CPT: - 1 - 2 - 3 - 4 - 5 - 6 - 7 - 8 - 9 - 10 </pre> </div></div> <p>With larger number of CPTs, the output would be fairly large. It does give you the advantage of being converted into a python list, but the disadvantage is that you'll have fairly large output. And there will be no way to express a CPU range. For example "CPT: "<span class="error">&#91;0-4&#93;</span>"</p> <p>Due to these reasons, I believe that the current solution advantages, outweigh the disadvantages.</p> <p>I see. Sorry, it appeared to me that CPT was a list/array (and valid YAML). If it's not, then yes, using quotes is fine. The application just has to parse the string.</p> Related LU-6043 Development Project Rank 1|hzx3in: Rank (Obsolete) 16975 Severity