https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-6160 Lustre <p>ASSERTs in SPL/ZFS are off by default. It'd be a good idea to enable SPL/ZFS assertions at least for test builds, which'd pinpoint problems much earlier before they manifest as hard-to-diagnose symptoms.</p> <p>I have a patch that enables SPL/ZFS debugging:<br/> <a href="http://review.whamcloud.com/#/c/13431/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/13431/</a></p> <p>But there's build failures for i686 in SPL/ZFS. So upstream SPL/ZFS would need a fix for that.</p> LU-6160

all test builds should enable SPL/ZFS debugging

Improvement Major Resolved Fixed Oleg Drokin Isaac Huang zfs Mon, 26 Jan 2015 18:28:46 +0000 Wed, 7 Nov 2018 13:05:08 +0000 Thu, 7 Jun 2018 22:51:31 +0000 Lustre 2.12.0 0 7 <p>I think Lustre isn't quite ready for this yet. in some cases (like append to llog) we can't declare in the way ZFS's debugging expects.</p> <p>Alex, can you please point me to the code?</p> <p>well, I don't remember exact lines, but basically in debug mode DMU tracks all writes are declared properly (including offset/range), while LLOG doesn't know exact offset at declare.</p> <p>I hear that Oleg successfully ran Lustre using ZFS built with debug enabled, and submitted patches for some bugs he found that way.</p> <p>Was Lustre patched to enable this, so that this ticket can now go forward? Or did he just make some one-off change in his environment, perhaps to ZFS, to enable this for testing purposes?</p> <p>"ran" doesn't exactly mean it's reliable.. not that I'm against running with debug enabled, but there were known issues we never fixed, some can't be fixed outside of ZFS code.</p> <p>Assigining to Oleg for his comment</p> <p>Giuseppe Di Natale (dinatale2@llnl.gov) uploaded a new patch: <a href="https://review.whamcloud.com/28544" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28544</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6160" title="all test builds should enable SPL/ZFS debugging" class="issue-link" data-issue-key="LU-6160"><del>LU-6160</del></a> osd-zfs: Fix refcount_add call<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 510f1536aa60e11271d621e2171dc19bcf8c7a5b</p> <p>I'm submitting <a href="https://review.whamcloud.com/28544" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28544</a> just so lustre builds against zfs packages that have debug enabled.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/28544/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28544/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6160" title="all test builds should enable SPL/ZFS debugging" class="issue-link" data-issue-key="LU-6160"><del>LU-6160</del></a> osd-zfs: Fix refcount_add call<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: ad7e62cc15e9e90d33a7302308d47566e4af3593</p> <p>Landed for 2.12</p> <p>I see that Oleg landed the patch to <em>allow</em> Lustre to build against zfs packages with debug enabled.</p> <p>But were the appropriate change(s) made to your build system to enable debug in zfs for test builds?</p> <p>Nathaniel Clark (nclark@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/33604" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33604</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6160" title="all test builds should enable SPL/ZFS debugging" class="issue-link" data-issue-key="LU-6160"><del>LU-6160</del></a> osd-zfs: Fix refcount_add call<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: 1<br/> Commit: fe7bf8a315c6c995f9eb674bd15308ff8def7633</p> Related LU-6155 LU-6195 Development Rank 1|hzx4w7: Rank (Obsolete) 17226