https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-6205 Lustre <p>When calling lfs path2fid, and FID is returned between bracket. When that fid variable is used, it is then expanded by the shell to something else. For instance when it is given to fid2path, it returns an error:</p> <p> $ ../utils/lfs fid2path lustre <span class="error">&#91;0x200000be7:0xb:0x0&#93;</span><br/> bad FID format <span class="error">&#91;x&#93;</span>, should be <span class="error">&#91;0x1:0x2:0x0&#93;</span></p> <p> fid2path: error on FID x: Invalid argument</p> <p>This will cause some tests, such as 154A or test_238 to fail under certain conditions, such as being called with:</p> <p> ONLY=154A PDSH=ssh AGTCOUNT=1 agt1_HOST=localhost \<br/> NAME=local sh ./sanity.sh</p> LU-6205

tests: fix bash expansion of FIDs

Bug Minor Resolved Fixed WC Triage Frank Zago patch Tue, 3 Feb 2015 21:11:03 +0000 Mon, 24 Apr 2017 18:15:28 +0000 Tue, 24 Mar 2015 16:27:49 +0000 Lustre 2.7.0 Lustre 2.8.0 0 7 <p>frank zago (fzago@cray.com) uploaded a new patch: <a href="http://review.whamcloud.com/13618" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13618</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6205" title="tests: fix bash expansion of FIDs" class="issue-link" data-issue-key="LU-6205"><del>LU-6205</del></a> tests: fix bash expansion of fid<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: aa99d73b66d377c0d5bad798eafbb25b0413b524</p> <p>I can't figure out how to make this fail. Do you have a simple reproducer for this?</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[root@test1 lustre]# touch foo [root@test1 lustre]# lfs path2fid foo [0x200000400:0x4a:0x0] [root@test1 lustre]# lfs fid2path lustre [0x200000400:0x4a:0x0] foo [root@test1 lustre]# v=[0x200000400:0x4a:0x0] [root@test1 lustre]# lfs fid2path lustre $v foo </pre> </div></div> <p>Your sample fails for me:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre># lustre/utils/lfs fid2path lustre [0x200000400:0x4a:0x0] bad FID format [a], should be [0x1:0x2:0x0] # v=[0x200000400:0x4a:0x0] [root@c65-l251-intel-fzago lustre-cleanup]# lustre/utils/lfs fid2path lustre $v bad FID format [a], should be [0x1:0x2:0x0] </pre> </div></div> <p>I'm running bash on centos 6.5.</p> <p>Robert, create a file "a" and try again.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre># v=[0x200000400:0x4a:0x0] # lfs fid2path lustre $v fid2path: error on FID [0x200000400:0x4a:0x0]: No such file or directory # touch a # lfs fid2path lustre $v bad FID format [a], should be [0x1:0x2:0x0] fid2path: error on FID a: Invalid argument </pre> </div></div> <p>doh!</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/13618/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/13618/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6205" title="tests: fix bash expansion of FIDs" class="issue-link" data-issue-key="LU-6205"><del>LU-6205</del></a> tests: fix bash expansion of fid<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: fd3bfcd73ee93e356adb716b11feca4bfd860af4</p> <p>Landed to master (pre-2.8.0)</p> <p>There are other scripts that needs similar fix, e.g.</p> <p>== sanity-lfsck test 2a: LFSCK can find out and repair crashed linkEA entry == 02:11:11 (1452877871)<br/> formatall<br/> setupall<br/> preparing... 1 * 1 files will be created.<br/> prepared.<br/> stop mds1<br/> start mds1<br/> Starting client: atest-vm31: -o user_xattr,flock atest-vm32@tcp:/lustre /mnt/lustre<br/> fail_loc=0x1603<br/> fail_loc=0<br/> 10.128.12.32@tcp:/lustre /mnt/lustre lustre rw,flock,user_xattr 0 0<br/> Stopping client atest-vm31 /mnt/lustre (opts<img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/><br/> Started LFSCK on the device lustre-MDT0000: namespace.<br/> Starting client: atest-vm31: -o user_xattr,flock atest-vm32@tcp:/lustre /mnt/lustre<br/> bad FID format <span class="error">&#91;b&#93;</span>, should be <span class="error">&#91;0x1:0x2:0x0&#93;</span></p> <p>fid2path: error on FID b: Invalid argument<br/> sanity-lfsck test_2a: @@@@@@ FAIL: (8) Fail to repair linkEA: <span class="error">&#91;0x280000bd0:0x1:0x0&#93;</span> <br/> Trace dump:<br/> = /usr/lib64/lustre/tests/test-framework.sh:4421:error_noexit()<br/> = /usr/lib64/lustre/tests/test-framework.sh:4452:error()<br/> = /usr/lib64/lustre/tests/sanity-lfsck.sh:262:test_2a()<br/> = /usr/lib64/lustre/tests/test-framework.sh:4691:run_one()<br/> = /usr/lib64/lustre/tests/test-framework.sh:4728:run_one_logged()<br/> = /usr/lib64/lustre/tests/test-framework.sh:4594:run_test()<br/> = /usr/lib64/lustre/tests/sanity-lfsck.sh:264:main()<br/> Dumping lctl log to /tmp/test_logs/logdir_1007_sanity-lfsck_1/sanity-lfsck.test_2a.*.1452877964.log</p> Related Development Rank 1|hzx5kn: Rank (Obsolete) 17351 Severity