https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-6401 Lustre <p>Much like the current situation with libcfs the headers for lustre being used internally for the kernel and for userland utilites is heavly intertwined. This work will look to unravel this mess and create a clear separation between lustre kernel space and lustre user land.</p> LU-6401

Untangle lustre userland and kernel headers

Improvement Minor Resolved Fixed Ben Evans James A Simmons patch upstream Wed, 25 Mar 2015 21:50:36 +0000 Wed, 29 May 2019 18:47:25 +0000 Sun, 13 Aug 2017 17:43:10 +0000 Lustre 2.8.0 Lustre 2.11.0 0 12 <p>Hi James,<br/> Are you going to submit patches for this ticket? If yes, I'll assign this ticket to me to take care of the patches.</p> <p>Yes soon but they are not ready. Wanted this ticket has a place holder until then.</p> <p>I'm working on a bunch of changes for this. What would be the best way of submitting them, the deltas here are pretty large (mostly cutting+pasting).</p> <p>Hi Ben,<br/> FYI, Andreas had a suggestion in <a href="https://jira.hpdd.intel.com/browse/LU-6142?focusedCommentId=104684&amp;page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-104684" class="external-link" target="_blank" rel="nofollow noopener">https://jira.hpdd.intel.com/browse/LU-6142?focusedCommentId=104684&amp;page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-104684</a></p> <p>Thank you for doing this work. Please break up the patches as small as possible where each patch does one specific change. The reason for this is these patches will be going upstream and very large patches that doing many things will be rejected since it is hard to inspect such a patch. Also any tabs or style changes should be patches in themselves.</p> <p>Don't be afraid to push what you have now. I will gladly review your patches.</p> <p>Ben Evans (bevans@cray.com) uploaded a new patch: <a href="http://review.whamcloud.com/15952" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15952</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> headers: Create single .h for lu_seq_range<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 8f8350e1f849e271b09b1272f20a33a5f4f60c3d</p> <p>Ben looking at the patch could you place that new header in lustre/include/lustre/* since it used by wiretest which is a user land app.</p> <p>No problem, reworking the patch because it didn't get submitted correctly. Moving it to lustre/include/lustre is no problem.</p> <p>Given the comments in the patch I created from John Hammond, how should I proceed here? Giant include files like lustre_idl.h and lustre_user.h are pretty clunky, and really don't keep things organized in any easily maintainable and understandable way, and they tend to be the "easy out" for development (just include the one giant thing and be done with it).</p> <p>My idea for separating things into files by function, and including all the "on the wire" data structures #include'd there seems to me to be a good way of cleaning up the code, and making it more maintainable.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/15952/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15952/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> headers: Create single .h for lu_seq_range<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 1ecf5bd5a3bece3d615d037a332792e360b49a09</p> <p>I wish this was fixed but a lot more work needs to be done. Could you reopen this ticket and remove the Fix Version field.</p> <p>James,<br/> My mistake - I thought the rest of the work was occurring in the related LU tickets. Will revert my changes.<br/> Joe</p> <p>Ben Evans (bevans@cray.com) uploaded a new patch: <a href="http://review.whamcloud.com/16339" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16339</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> headers: move swab functions to new header files<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 6b9113fef73419a49841d2d3c096c36cf9a26c75</p> <p>Should I create separate LUs for each one of these patches I do? I expect there to be a long series of them.</p> <p>That would be a lot of patches. I think it is okay to keep them under this ticket.</p> <p>Building some of test apps I hit <a href="https://jira.whamcloud.com/browse/LU-5011" title="lustre_idl.h again does not compile in user space" class="issue-link" data-issue-key="LU-5011"><del>LU-5011</del></a> due to libcfs/types.h being in lustre_idl.h. Ben I would be very grateful if you reworked lustre_idl.h to remove libcfs/types.h. If you do please place the work under <a href="https://jira.whamcloud.com/browse/LU-5011" title="lustre_idl.h again does not compile in user space" class="issue-link" data-issue-key="LU-5011"><del>LU-5011</del></a>.</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="http://review.whamcloud.com/16494" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16494</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> lustre: make lustre_user.h compile in user space<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 001375a9a215eeb5fd773851021720728e91c670</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/16494/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16494/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> lustre: make lustre_user.h compile in user space<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 9f19e2f152e1012558f37f6eecd336d516ff812e</p> <p>Ben Evans (bevans@cray.com) uploaded a new patch: <a href="http://review.whamcloud.com/16917" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16917</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> headers: Create a header for obdo related functions<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: fe73484a122a4c7df6528c0f451dec2d8f74a3e5</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="http://review.whamcloud.com/17720" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17720</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> uapi: change uapi_kernelcomm.h to LGPLv2.1 license<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 603dc605d666a2ba577817798d1a785266a66fcf</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/17720/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17720/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> uapi: change uapi_kernelcomm.h to LGPLv2.1 license<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: c683c00408bc56bb68ab44d8bd21eaceb75fe86a</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/16339/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16339/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> headers: move swab functions to new header files<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: adfb405433aac3691bbd00ed548203c57ce61e3a</p> <p>Ben Evans (bevans@cray.com) uploaded a new patch: <a href="http://review.whamcloud.com/18863" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/18863</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> headers: move seq_range.h to correct directory<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: fca545541496f8ebe38fb9956fb1e80c71a4b9fa</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/16917/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16917/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> headers: Create a header for obdo related functions<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 713174908cb8e5e3ceadd3ca1cb42a88b200e576</p> <p>Ben Evans (bevans@cray.com) uploaded a new patch: <a href="http://review.whamcloud.com/19266" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/19266</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> obdclass: make get/set_wire_obdo non-inline<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: b34ee42a6b08b34c361bd7ce0d4c5ea46db3e912</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/18863/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/18863/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> headers: move seq_range.h to correct directory<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 1230bc483cbd15280ef2abf235eed600d500b9da</p> <p>Ben Evans (bevans@cray.com) uploaded a new patch: <a href="http://review.whamcloud.com/20120" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/20120</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> headers: Move object_update functions to new header<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: d47505fdb75369a07ea06c844d2fc23ed248294a</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/19266/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/19266/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> obdclass: make get/set_wire_obdo non-inline<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 219e0a6dd4306a7424dd33146963a0a830035128</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/20120/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/20120/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> headers: Move object_update functions to new header<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 86068ab4d84dd0915fc91dbf59ac924ced9373c3</p> <p>Hi Ben,<br/> So far, all of the existing patches for this ticket have landed. Are there any more new patches?</p> <p>Its far from being done.</p> <p>There is a lot left to do. I'll indicate when this process is done.</p> <p>Thank you James and Ben.</p> <p>Ben Evans (bevans@cray.com) uploaded a new patch: <a href="http://review.whamcloud.com/21484" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/21484</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> headers: Move functions out of lustre_idl.h<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 9b6f392899f6a72d68af9d845516025aab38ec2b</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/21484/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/21484/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> headers: Move functions out of lustre_idl.h<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 2714d02cfd570b9fadb5b66483160f1c56e3c5fe</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="http://review.whamcloud.com/22522" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/22522</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> header: remove assert from interval_set()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: ae0502739905ca6d5745d4c957fb336b6e4cc42b</p> <p>Ben Evans (bevans@cray.com) uploaded a new patch: <a href="http://review.whamcloud.com/22712" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/22712</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> headers: move lu_fid, ost_id funcs out of lustre_idl<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 494b366ca0e95cb8f3fed4dd81a5f0afe803be7c</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/22522/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/22522/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> header: remove assert from interval_set()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 5207c488239e30e9aee51531ec3a363c649211de</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/24323" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/24323</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> header: remove libcfs.h in interval_tree.h<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 8e8109538c140a76a598b5e44c46f433ac904030</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/24325" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/24325</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> header: turn lustre_param.h into a proper UAPI header<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 89c9fe889d6eb92e31034ffa9c93fb29b305ea8f</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/24374" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/24374</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> header: don't make lustre_acl.h a UAPI header<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 0cdf6cd1630811b59233736ac2ddd8d487d01ac1</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/22712/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/22712/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> headers: move lu_fid, ost_id funcs out of lustre_idl.h<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 51828ff66904be2a56a8790c3c9ce562a7c8e2e6</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/24323/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/24323/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> header: remove libcfs.h in interval_tree.h<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 24bc033262d15ab565f1a424c8e1a709993814d1</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/24568" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/24568</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> header: turn lustre_ioctl.h into a proper UAPI header<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: c5b4be52a74be44c1a32acfe3ebb388b00003278</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/24569" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/24569</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> headers: fix up lustre_ostid.h<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: d156b6fdff64bd4531a29c494c0f85f9782bf1fb</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/25194" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/25194</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> uapi: split lustre_disk.h into two headers<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 97913453dcd56d8f9c9489f3e352030f6b212c3f</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/25246" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/25246</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> uapi: remove lustre_idl.h from most userspace code<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: b7338d35902eff236392f1499a8bbd8eb4099e8a</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/25194/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/25194/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> uapi: split lustre_disk.h into two headers<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 3344e648236778565a8838ca85c655446ee7028c</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/24568/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/24568/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> uapi: turn lustre_ioctl.h into a proper UAPI header<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: b8afd0dcd3834a88b0ceead18c71d37052a00a8d</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/24569/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/24569/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> uapi: fix up lustre_ostid.h and lustre_fid.h<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 34acfbc2bfe502d18c12ba35771bde7c4a0f7906</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/26966" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/26966</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> uapi: change lustre_cfg.h into a proper UAPI header<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 5c019c4dc0f8e7b281b9d6751af98158b57a50d3</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/24325/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/24325/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> uapi: turn lustre_param.h into a proper UAPI header<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 424e56abd685c5eabc6a276154dec1c031cf5044</p> <p>One outstanding patch and I have the final one in the works. Almost done but I'm down to one last issue. For lustre_ioctl.h which is an UAPI headers to have CONFIG_LUSTRE_OBD_MAX_IOCTL_BUFFER is a big no no. So I see two ways this can be handled. One is make OBD_MAX_IOCTL_BUFFER a constant or make this a module parameter. Which approach should be done?</p> <p>Can you explain what is wrong with that parameter? I honestly don't think we'll change it any time soon, so it could be moved to an internal header. That said, what is wrong with exposing this constant to userspace?</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>0 lustre/include/uapi/linux/lustre_ioctl.h &lt;global&gt; 65 #define OBD_MAX_IOCTL_BUFFER CONFIG_LUSTRE_OBD_MAX_IOCTL_BUFFER 1 lustre/obdclass/linux/linux-module.c obd_ioctl_getdata 167 if (hdr.ioc_len &gt; OBD_MAX_IOCTL_BUFFER) { 2 lustre/obdclass/linux/linux-module.c obd_ioctl_getdata 169 hdr.ioc_len, OBD_MAX_IOCTL_BUFFER); 3 lustre/utils/liblustreapi.c cb_migrate_mdt_init 3853 char raw[OBD_MAX_IOCTL_BUFFER] = {'\0'}; 4 lustre/utils/liblustreapi.c llapi_obd_fstatfs 4167 char raw[OBD_MAX_IOCTL_BUFFER] = {'\0'}; 5 lustre/utils/obd.c jt_obd_lov_getconfig 2219 desc.ld_tgt_count = ((OBD_MAX_IOCTL_BUFFER-sizeof(data)-sizeof(desc)) / </pre> </div></div> <p>In <tt>cb_migrate_mdt_init()</tt> and <tt>llapi_obd_fstatfs()</tt> use of <tt>OBD_MAX_IOCTL_BUFFER</tt> can easily be replaced by using dynamic allocation from <tt>obd_ioctl_pack()</tt>.</p> <p><tt>lctl lov_getconfig</tt> should just be deleted. But if that's not politically feasible then all of the information it prints can be gotten from lov proc.</p> <p>Then there are no more uses of <tt>OBD_MAX_IOCTL_BUFFER</tt> in userspace.</p> <p>Last two patches have been updated that will finish this ticket !!!! <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/biggrin.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>Thank you James! <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/biggrin.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/26966/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/26966/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> uapi: change lustre_cfg.h into a proper UAPI header<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 4fedbc879571305a0d14a2caa989c8c306efc54c</p> <p>Was it intentional to remove the 8 character filesystem name limit in commit 424e56abd685c5eabc6a276154dec1c031cf5044 ?</p> <p> </p> <p>And if so, is there an LUDOC for that change?</p> <p>If that change was intentional then there's a bug with mkfs.lustre rename option that restricts a rename to 8 characters.</p> <p>8 vs 16 length issue reported at <a href="https://jira.whamcloud.com/browse/LU-9767" title="FS name checking got removed" class="issue-link" data-issue-key="LU-9767"><del>LU-9767</del></a>.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/25246/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/25246/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6401" title="Untangle lustre userland and kernel headers" class="issue-link" data-issue-key="LU-6401"><del>LU-6401</del></a> uapi: migrate remaining uapi headers to uapi directory<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 6712478e79588e73e28c7ccac3afc7ac2368a4f3</p> <p>After 3 years of work this is complete.</p> <p>And nearly 3 years later it's still not closed =)</p> <p>Oops. Forgot to close it out.</p> Blocker LU-6245 Related LU-9767 LU-9679 LU-6202 LU-6746 LU-5000 LU-6450 LU-9128 LU-9301 LU-5011 LU-8945 Development End date Wed, 11 May 2016 21:50:36 +0000 Epic/Theme upstream Rank 1|hzx9cf: Rank (Obsolete) 9223372036854775807 Start date Wed, 25 Mar 2015 21:50:36 +0000