https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-6418 Lustre <p>In function ll_direct_rw_pages, the cl_page_find will return a cl_page with cp_type of CPT_TRANSIENT for sure. And we will not cache this type of cl_page anymore.</p> <p>So, i think we could remove the code of the logical when the cp_type is equal CPT_CACHABLE which is the code need in old version that cached the cl_page into the radix tree no matter what the type is.</p> LU-6418

Simplify code of ll_direct_rw_pages

Improvement Trivial Closed Fixed Jinshan Xiong wu libin patch Tue, 31 Mar 2015 17:35:13 +0000 Thu, 8 Feb 2018 18:28:08 +0000 Thu, 8 Feb 2018 18:28:08 +0000 0 4 <p>Wu Libin (gnlwlb@gmail.com) uploaded a new patch: <a href="http://review.whamcloud.com/14288" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/14288</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6418" title="Simplify code of ll_direct_rw_pages" class="issue-link" data-issue-key="LU-6418"><del>LU-6418</del></a> llite: Simplify code of ll_direct_rw_pages<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 21771b2aac89aa8ae6f24d096ed536f3b01f18d6</p> <p>Jinshan has provided feedback on the patch in gerrit</p> <p>Please reopen this ticket if anything new comes up.</p> <p>Hi, Jinshan, from the code of cl_page_find, it seems that cp_type of the cl_page impossible to be CPT_CACHEABLE here.So the codes of the "if (clp-&gt;cp_type == CPT_CACHEABLE)" branch are redundant, right? Please take a look at it again, sorry if i have missed something.</p> <p>indeed, I forgot that we have changed cl_page_find() implementation. Yes, your patch is correct.</p> <p>sure, thanks!</p> <p>The work should be already in Lustre.</p> Development End date Fri, 3 Apr 2015 17:35:13 +0000 Rank 1|hzx9un: Rank (Obsolete) 9223372036854775807 Start date Tue, 31 Mar 2015 17:35:13 +0000