Whamcloud Community JIRA

Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us

9.4.14

940014

05-12-2023

[LU-6491] Confusing results for too long fsname https://jira.whamcloud.com/browse/LU-6491 Lustre <p> If users passed a fsname longer than 9 bytes, caller<br/> will handle it as ENOMEM which output following results:</p> <p> error: conf_param: Cannot allocate memory</p> <p> which is really unfriendly for common users.</p> LU-6491

Confusing results for too long fsname

Bug Trivial Resolved Fixed Emoly Liu Wang Shilong Fri, 24 Apr 2015 05:41:01 +0000 Thu, 28 May 2015 22:31:59 +0000 Thu, 28 May 2015 22:31:59 +0000 Lustre 2.8.0 0 3 <p>I missed to migrate my google account for gerrit, but i think here should fix it.<br/> diff --git a/lustre/mgs/mgs_llog.c b/lustre/mgs/mgs_llog.c<br/> index d804de4..2f36696 100644<br/> — a/lustre/mgs/mgs_llog.c<br/> +++ b/lustre/mgs/mgs_llog.c<br/> @@ -334,12 +334,12 @@ static struct fs_db *mgs_new_fsdb(const struct lu_env *env,</p> <p> if (strlen(fsname) >= sizeof(fsdb->fsdb_name)) </p> { CERROR("fsname %s is too long\n", fsname); - RETURN(NULL); + RETURN(ERR_PTR(-EINVAL)); } <p> OBD_ALLOC_PTR(fsdb);<br/> if (!fsdb)</p> <ul class="alternate" type="square"> <li>RETURN(NULL);<br/> + RETURN(ERR_PTR(-ENOMEM));</li> </ul> <p> strcpy(fsdb->fsdb_name, fsname);<br/> mutex_init(&fsdb->fsdb_mutex);<br/> @@ -380,7 +380,7 @@ err:<br/> name_destroy(&fsdb->fsdb_clilov);<br/> name_destroy(&fsdb->fsdb_clilmv);<br/> OBD_FREE_PTR(fsdb);</p> <ul class="alternate" type="square"> <li>RETURN(NULL);<br/> + RETURN(ERR_PTR(rc));<br/> }</li> </ul> <p> static void mgs_free_fsdb(struct mgs_device *mgs, struct fs_db *fsdb)<br/> @@ -443,11 +443,11 @@ int mgs_find_or_make_fsdb(const struct lu_env *env,<br/> CDEBUG(D_MGS, "Creating new db\n");<br/> fsdb = mgs_new_fsdb(env, mgs, name);<br/> /* lock fsdb_mutex until the db is loaded from llogs */</p> <ul class="alternate" type="square"> <li>if (fsdb)<br/> + if (!IS_ERR(fsdb))<br/> mutex_lock(&fsdb->fsdb_mutex);<br/> mutex_unlock(&mgs->mgs_mutex);</li> <li>if (!fsdb)</li> <li>RETURN(-ENOMEM);<br/> + if (IS_ERR(fsdb))<br/> + RETURN(PTR_ERR(fsdb));</li> </ul> <p> if (!test_bit(FSDB_MGS_SELF, &fsdb->fsdb_flags)) {<br/> /* populate the db from the client llog */</p> <p>Shilong Wang (wshilong@ddn.com) uploaded a new patch: <a href="http://review.whamcloud.com/14568" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/14568</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6491" title="Confusing results for too long fsname" class="issue-link" data-issue-key="LU-6491"><del>LU-6491</del></a> llog: fix wrong return value for too long fsname<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 88b4af7b6e98462ccf8a62252d2442bd9ef8c416</p> <p>Emoly</p> <p>Could you please take care of this patch?</p> <p>Thanks</p> <p>Peter</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/14568/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/14568/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6491" title="Confusing results for too long fsname" class="issue-link" data-issue-key="LU-6491"><del>LU-6491</del></a> llog: fix wrong return value for too long fsname<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 5b6d23d7fb8de7ae44ca369381a128c78f78bf21</p> <p>Landed for 2.8</p> Development Epic/Theme patch Rank 1|hzxbh3: Rank (Obsolete) 9223372036854775807 Severity