[LU-6498] Redundant rc check in ll_setattr_raw

Wed, 7 Jun 2017 19:37:10 +0000

It looks like we had a bit of a strange code before SOM removal that is even more redundant now in ll_Setattr_raw:

        rc = ll_md_setattr(dentry, op_data);
        if (rc)
                GOTO(out, rc);

        /* RPC to MDT is sent, cancel data modification flag */
        if (rc == 0 && (op_data->op_bias & MDS_DATA_MODIFIED)) {
                spin_lock(&lli->lli_lock);
                lli->lli_flags &= ~LLIF_DATA_MODIFIED;
                spin_unlock(&lli->lli_lock);
        }

So I guess the rc ==0 part could go easily?

Whamcloud Community JIRA

[LU-6498] Redundant rc check in ll_setattr_raw