[LU-6499] leaking a kernel device on error in init_obdclass

Related — Thu, 9 Mar 2017 20:55:10 +0000

Highlighted by smatch:

init_obdclass has this nice code:

        err = misc_register(&obd_psdev);
        if (err) {
                CERROR("cannot register %d err %d\n", OBD_DEV_MINOR, err);
                return err;
        }
...
        err = obd_init_caches();
        if (err)
                return err;
        err = class_procfs_init();
        if (err)
                return err;

        err = lu_global_init();
        if (err)
                return err;

        err = lu_capainfo_init();
        if (err)
                return err;
...

leaking reference to the just registered device.
We should really be freeing it on all subsequent errors.

Whamcloud Community JIRA

[LU-6499] leaking a kernel device on error in init_obdclass