[LU-6512] ll_dir_ioctl has some pretty strange code now.

Tue, 3 May 2016 19:04:40 +0000

smatch highlighted thid interesting piece in ll_dir_ioctl that results from a bit of code change by commit 60e07b972114df24105a3a1bfa7365892f72a4a7 ~~LU-4690~~:

                rc = ll_dir_getstripe(inode, (void **)&lmm, &lmmsize, &request,
                                      valid);
                if (rc != 0)
                        GOTO(finish_req, rc);

                /* Get default LMV EA */
                if (lum.lum_magic == LMV_USER_MAGIC) {
                        if (rc != 0)
                                GOTO(finish_req, rc);

note the two identical comparisons.
Should we take the other one down?

Whamcloud Community JIRA

[LU-6512] ll_dir_ioctl has some pretty strange code now.