[LU-6513] redundant rc check in mgs_setparam

Sun, 30 Jan 2022 10:41:56 +0000

smatch highlighted this bit in mgs_setparam:

        rc = mgs_parse_devname(devname, fsname, NULL);
        if (rc == 0 && !mgs_parse_devname(devname, NULL, &index)) {
                /* param related to llite isn't allowed to set by OST or MDT */
                if (rc == 0 && strncmp(param, PARAM_LLITE,
                                       sizeof(PARAM_LLITE) - 1) == 0)
                        RETURN(-EINVAL);
        } else {

So, why do we need this second rc == 0 check? let's take it down to improce clarity, perhaps we can even combine the two if statements ?

Whamcloud Community JIRA

[LU-6513] redundant rc check in mgs_setparam