[LU-6515] Always true check in mdd_migrate_create

Related — Tue, 16 Jun 2020 23:03:32 +0000

smatch highlights this case in mdd_migrate_create():

        handle = mdd_trans_create(env, mdd);
        if (IS_ERR(handle))
                GOTO(out_free, rc = PTR_ERR(handle));

        /* Note: this transaction is part of migration, and it is not
         * the last step of migration, so we set th_local = 1 to avoid
         * update last rcvd for this transaction */
        handle->th_local = 1;
....
stop_trans:
        if (handle != NULL)
                mdd_trans_stop(env, mdd, rc, handle);
out_free:
...

handle, once allocated, is never freed or reassigned, so I feel like we should just drop that redundant check to avoid some extra confusion?

Whamcloud Community JIRA

[LU-6515] Always true check in mdd_migrate_create