https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-6516 Lustre <p>found by smatch, in ofd_inconsistency_verification_main:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> spin_unlock(&amp;ofd-&gt;ofd_inconsistency_lock); if (rc != 0) RETURN(rc); OBD_ALLOC_PTR(lr); if (unlikely(lr == NULL)) GOTO(out, rc = -ENOMEM); ... thread_set_flags(thread, SVC_STOPPED); wake_up_all(&amp;thread-&gt;t_ctl_waitq); spin_unlock(&amp;ofd-&gt;ofd_inconsistency_lock); </pre> </div></div> LU-6516

double spin unlock in ofd_inconsistency_verification_main

Bug Minor Resolved Fixed Jian Yu Oleg Drokin patch Mon, 27 Apr 2015 04:40:47 +0000 Tue, 29 Dec 2015 21:53:51 +0000 Tue, 18 Aug 2015 13:57:42 +0000 Lustre 2.8.0 0 4 <p>Hi,</p> <p>Yes this seems to be issue. Earlier we are taking lock and waking up threads.<br/> See this code -</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>spin_lock(&amp;ofd-&gt;ofd_inconsistency_lock); thread_set_flags(thread, rc != 0 ? SVC_STOPPED : SVC_RUNNING); wake_up_all(&amp;thread-&gt;t_ctl_waitq); spin_unlock(&amp;ofd-&gt;ofd_inconsistency_lock); </pre> </div></div> <p>However in out we did not lock again.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>thread_set_flags(thread, SVC_STOPPED); wake_up_all(&amp;thread-&gt;t_ctl_waitq); spin_unlock(&amp;ofd-&gt;ofd_inconsistency_lock); lu_env_fini(&amp;env); return rc; </pre> </div></div> <p>This is because in normal case we have spinlock already taken.<br/> But if memory allocation failed then this will not work.<br/> Probable solution is -<br/> OBD_ALLOC_PTR(lr);<br/> if (unlikely(lr == NULL))<br/> GOTO(out1, rc = <del>ENOMEM);&lt;</del>--- added new lable</p> <p>out1:<br/> spin_lock(&amp;ofd-&gt;ofd_inconsistency_lock);<br/> thread_set_flags(thread, rc != 0 ? SVC_STOPPED : SVC_RUNNING);<br/> wake_up_all(&amp;thread-&gt;t_ctl_waitq);<br/> spin_unlock(&amp;ofd-&gt;ofd_inconsistency_lock);<br/> lu_env_fini(&amp;env);</p> <p> return rc;</p> <p>Please advice.<br/> -Ulka</p> <p>Ulka Vaze (ulka.vaze@yahoo.in) uploaded a new patch: <a href="http://review.whamcloud.com/14875" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/14875</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6516" title="double spin unlock in ofd_inconsistency_verification_main" class="issue-link" data-issue-key="LU-6516"><del>LU-6516</del></a> ofd: double unlock of spinlock<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 1095e21567f7cfb5906d9e7178e950567fb924a4</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/14875/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/14875/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6516" title="double spin unlock in ofd_inconsistency_verification_main" class="issue-link" data-issue-key="LU-6516"><del>LU-6516</del></a> ofd: fix double spin_unlock<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 490ea83a486c0c44274f4d4f6f77d8e0e16835d5</p> <p>Landed for 2.8</p> Related Development Rank 1|hzxbqn: Rank (Obsolete) 9223372036854775807 Severity