[LU-6523] Unchecked usage of potential ERR_PTR result in lmv_hsm_req_count and lmv_hsm_req_build

Wed, 15 Jun 2016 13:03:13 +0000

smatch highlighted that lmv_hsm_req_count and lmv_hsm_req_build have this sort of code:

        for (i = 0; i < hur->hur_request.hr_itemcount; i++) {
                curr_tgt = lmv_find_target(lmv, &hur->hur_user_item[i].hui_fid);
                if (obd_uuid_equals(&curr_tgt->ltd_uuid, &tgt_mds->ltd_uuid))
                        nr++;
        }

lmv_find_target can return an error that we definitely need to check for there.

Whamcloud Community JIRA

[LU-6523] Unchecked usage of potential ERR_PTR result in lmv_hsm_req_count and lmv_hsm_req_build