[LU-6524] llog_osd_destroy incorrectly tried to use ERR_PTR pointer

Wed, 10 Jun 2015 13:34:19 +0000

smatch highlighted tihs obviously incorrect code in llog_osd_destroy:

        if (loghandle->lgh_name) {
                llog_dir = llog_osd_dir_get(env, ctxt);
                if (IS_ERR(llog_dir))
                        GOTO(out_trans, rc = PTR_ERR(llog_dir));
...
out_trans:
        dt_trans_stop(env, d, th);
        if (llog_dir != NULL)
                lu_object_put(env, &llog_dir->do_lu);

Nothing good can come out of it for sure.

Whamcloud Community JIRA

[LU-6524] llog_osd_destroy incorrectly tried to use ERR_PTR pointer