https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-6536 Lustre <p><tt>llapi_layout_get_by_fd()</tt> contains this code which uses <tt>lmm_stripe_count</tt> without first checking if the <tt>lov_user_md</tt> needs to be byte-swapped. This causes a false error on PowerPC clients.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">if</span> (!S_ISDIR(st.st_mode) &amp;&amp; object_count != lum-&gt;lmm_stripe_count) { errno = EINTR; <span class="code-keyword">goto</span> out; } </pre> </div></div> LU-6536

lum->lmm_stripe_count used unswabbed in llapi_layout_get_by_fd()

Bug Major Resolved Fixed Emoly Liu Ned Bass patch Tue, 28 Apr 2015 18:19:08 +0000 Tue, 1 Sep 2015 21:12:19 +0000 Tue, 7 Jul 2015 11:50:17 +0000 Lustre 2.8.0 0 3 <p>Ned Bass (bass6@llnl.gov) uploaded a new patch: <a href="http://review.whamcloud.com/14633" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/14633</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6536" title="lum-&gt;lmm_stripe_count used unswabbed in llapi_layout_get_by_fd()" class="issue-link" data-issue-key="LU-6536"><del>LU-6536</del></a> llapi: lmm_stripe_count used unswabbed<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 325652177c8a7365943b792dde77afdc7759c987</p> <p>HM, it's eally strange we don't do all theswabbing in the kernel and need to ask userspace to do it too.</p> <p>Is this all that wise? Should we onvert to all-in-kernel swabbing?</p> <p>Hi Oleg. The kernel swabs the <tt>lustre_user_md</tt> through the <tt>ioctl()</tt> interface but not <tt>getxattr()</tt>. The <tt>llapi_layout</tt> library functions use <tt>getxattr()</tt> to accommodate function shipping platforms that don't grok the ioctls. I recall discussing this behavior at length with John Hammond and we settled on things as they stand today. I'll have to dig up that discussion. I forget which Jira issue or gerrit review it happened in.</p> <p>Ah, for xattr interface I agree we have no business changing anything</p> <p>Oleg, see the review comments here <a href="http://review.whamcloud.com/#/c/5737/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/5737/</a>. The caveat for byte swapping through getxattr() is that setxattr() would have to accept LUM data in either endianness to avoid breaking tar. We decided not to go that route.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/14633/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/14633/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6536" title="lum-&gt;lmm_stripe_count used unswabbed in llapi_layout_get_by_fd()" class="issue-link" data-issue-key="LU-6536"><del>LU-6536</del></a> llapi: lmm_stripe_count used unswabbed<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 3742646beeb658f321745f5c275836879b9d077d</p> Related LU-2973 Development Rank 1|hzxc13: Rank (Obsolete) 9223372036854775807