https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-6589 Lustre <p>The input validation for this function appears to have a typo. Presumably "&amp;&amp;" was intended instead of "||":</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">if</span> (pattern != LLAPI_LAYOUT_DEFAULT || pattern != LLAPI_LAYOUT_RAID0) { errno = EOPNOTSUPP; <span class="code-keyword">return</span> -1; } </pre> </div></div> LU-6589

llapi_layout_pattern_set() rejects valid pattern values

Bug Minor Resolved Fixed Yang Sheng Robert Read patch Mon, 11 May 2015 23:08:49 +0000 Wed, 23 Sep 2015 13:08:19 +0000 Wed, 23 Sep 2015 13:08:19 +0000 Lustre 2.8.0 0 6 <p>It isn't clear that this is actually a bug? LLAPI_LAYOUT_DEFAULT means "use the default values", so I can't see it makes sense to specify "use the default" at the same time as specifying something that may not be the default? Also, since LLAPI_LAYOUT_DEFAULT is not a simple bitfield it will also conflict with RAID0?</p> <p>Ned, any comment on this API usage?</p> <p>Robert, were you doing something in particular that failed this check, or merely code review?</p> <p>I think Robert is right--it will reject any value other than LLAPI_LAYOUT_DEFAULT. I'll whip up a patch.</p> <p>Ned Bass (bass6@llnl.gov) uploaded a new patch: <a href="http://review.whamcloud.com/14784" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/14784</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6589" title="llapi_layout_pattern_set() rejects valid pattern values" class="issue-link" data-issue-key="LU-6589"><del>LU-6589</del></a> llapi: ..._layout_pattern_set() rejects valid patterns<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 3ffaa9456818da1e29231a317247bc2faa64b31d</p> <p>Yang Sheng</p> <p>Could you please take care of this patch?</p> <p>Thanks</p> <p>Peter</p> <p>This also rejects LLAPI_LAYOUT_DEFAULT, too.</p> <p>I noticed this problem while writing unit tests for my own tool. </p> <p>My bad, didn't read the code correctly... <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>No worries - I had to stare at it for a few minutes to convince myself it actually was as broken as I thought it was. <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/14784/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/14784/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6589" title="llapi_layout_pattern_set() rejects valid pattern values" class="issue-link" data-issue-key="LU-6589"><del>LU-6589</del></a> llapi: ..._layout_pattern_set() rejects valid patterns<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 1d700aaf9ff785e062d8e4c6a8920f37265dd969</p> <p>Landed for 2.8</p> Development Rank 1|hzxd0n: Rank (Obsolete) 9223372036854775807 Severity