https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-6662 Lustre <p>mkfs.lustre defaults mountoptions to error=mount-ro and doesn't allow error=panic. Changing this using tunefs.lustre also gives warning about 'error=mount-ro' is missing.</p> <p>Is the use of error=panic discouraged? if so why? </p> LU-6662

mkfs should allow use of errors=panic

Bug Major Resolved Fixed Hongchao Zhang Mahmoud Hanafi easy Thu, 28 May 2015 18:57:49 +0000 Thu, 12 May 2016 13:23:04 +0000 Fri, 18 Dec 2015 14:08:22 +0000 Lustre 2.5.3 Lustre 2.8.0 0 7 <p>Hongchao</p> <p>Could you please advise on this one?</p> <p>Thanks</p> <p>Peter</p> <p>I don't think <tt>errors=panic</tt> is discouraged, this is likely just an oversight from the time when the <tt>errors=remount-ro</tt> option was never being specified and the warning message was added to ensure that this wasn't missed.</p> <p>To fix this problem, I think the right approach is to change the code to check for any <tt>errors=</tt> option being specified. However, this is complicated by the way that the code is currently implemented, since for it sets <tt>errors=remount-ro</tt> into default_mountopts in <tt>ldiskfs_prepare_lustre()</tt>, and then later checks in <tt>check_mountfsoptions()</tt> whether those default options are present.</p> <p>There isn't really an easy way to change this currently, though I think it would be better to change the <tt>osd_prepare_lustre()</tt> method to be passed only actual mountopts string, ldd_mount_opts[] and its maximum size, instead of passing the default_mountopts and always_mountopts back to the caller. That would allow ldiskfs_prepare_lustre() to verify the mountopts string to handle cases like this, store the defaults into ldd_mount_opts[], and append any user-specified values to override the default values.</p> <p>Hongchao Zhang (hongchao.zhang@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/15870" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15870</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6662" title="mkfs should allow use of errors=panic" class="issue-link" data-issue-key="LU-6662"><del>LU-6662</del></a> utils: allow overriding default mountopts<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 27bdc3417985dbcbe9790492b60ce0d8141bdbba</p> <p>The conf-sanity.sh in 2.5.3 contains only up to test_77. Is it OK to just pick up test_88 added in #15870?</p> <p>Yes, each subtest should be self-contained. </p> <p>This LU can be closed</p> <p>Thanks Mahmoud but, given that there is a patch that - as far as I understand - you are using we should probably hold this open until that has landed to master</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/15870/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15870/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6662" title="mkfs should allow use of errors=panic" class="issue-link" data-issue-key="LU-6662"><del>LU-6662</del></a> utils: allow overriding default mountopts<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 927effd2c2374508d904d2022c74574e508c07f1</p> <p>Landed for 2.8</p> Related LU-6442 LU-6978 LU-6952 Development Rank 1|hzxeg7: Rank (Obsolete) 9223372036854775807 Severity