[LU-6691] distribute_txn_commit_batchid_init references ERR_PTR on error path

Tue, 14 Jul 2015 22:43:58 +0000

Recently landed patch http://review.whamcloud.com/11572 has these problems:

/home/green/smt/git/lustre-release/lustre/ptlrpc/../../lustre/target/update_trans.c:1216 distribute_txn_commit_batchid_init() error: 'dt_obj' dereferencing possible ERR_PTR()

code:

        dt_obj = dt_find_or_create(env, lut->lut_bottom, fid, dof,
                                   attr);
        if (IS_ERR(dt_obj))
                GOTO(out_put, rc = PTR_ERR(dt_obj));
...
out_put:
        if (rc < 0 && dt_obj != NULL) {
                lu_object_put(env, &dt_obj->do_lu);

This is clearly wrong.

Whamcloud Community JIRA

[LU-6691] distribute_txn_commit_batchid_init references ERR_PTR on error path