https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-6693 Lustre <p>Recent patch <a href="http://review.whamcloud.com/14787" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/14787</a> added a code to object_update_param_get that returns PTR_ERR. But before it only returned NUL on error which all callers expect.<br/> Now every caller is broken as they don't expect non NULL errors.</p> <p>E.g. in out_xattr_set, out_read (twice). in target/out_handler.c</p> <p>I think we need to convert object_update_param_get back to returning just NULL on error.</p> LU-6693

object_update_param_get inconsistent return value

Bug Critical Resolved Fixed Di Wang Oleg Drokin Fri, 5 Jun 2015 06:10:21 +0000 Fri, 4 Dec 2015 13:28:46 +0000 Fri, 4 Dec 2015 13:28:45 +0000 Lustre 2.8.0 0 4 <p><a href="http://review.whamcloud.com/#/c/12825/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/12825/</a> has fixed this issue.</p> <p>This is not a full fix.<br/> Remaining problems:</p> <p>/home/green/smt/git/lustre-release/lustre/ptlrpc/../../lustre/target/out_lib.c:204 out_create_pack() error: 'obdo' dereferencing possible ERR_PTR()<br/> /home/green/smt/git/lustre-release/lustre/ptlrpc/../../lustre/target/out_lib.c:252 out_attr_set_pack() error: 'obdo' dereferencing possible ERR_PTR()</p> <p>wangdi (di.wang@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/16417" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16417</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6693" title="object_update_param_get inconsistent return value" class="issue-link" data-issue-key="LU-6693"><del>LU-6693</del></a> out: replace assert with error check in out_xx()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 942234aace34b48dc06cdbe0f112662f4eeba214</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/16417/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16417/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6693" title="object_update_param_get inconsistent return value" class="issue-link" data-issue-key="LU-6693"><del>LU-6693</del></a> out: not return NULL in object_update_param_get<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: d059b3c01a9784b8da61ea99fb746e949d681b7e</p> <p>Landed for 2.8</p> Development Rank 1|hzxf1r: Rank (Obsolete) 9223372036854775807 Severity