https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-6714 Lustre <p>the llog_process_thread() save curent offset in last_offset variable before getting the new block of data, and uses it as the beginning of that block later. That can be wrong because new block can be read from different offset, depending on index being searched. We need to use the value returned by llog_next_block() call.</p> LU-6714

llog_process_thread() may use wrong offset for the next block

Bug Minor Resolved Fixed Mikhail Pershin Mikhail Pershin Fri, 12 Jun 2015 10:31:58 +0000 Mon, 10 Apr 2017 18:03:30 +0000 Tue, 11 Aug 2015 15:02:17 +0000 Lustre 2.8.0 0 6 <p>It worths also to modify llog processing for the llog with fixed size records. For such llogs needed records can be accessed by index like in array, so we have file offset of record just by index, no need to search it going through whole llog.</p> <p>Link <a href="https://jira.whamcloud.com/browse/LU-5635" title="(llog.c:310:llog_process_thread()) ASSERTION( index &lt;= last_index + 1 ) failed:" class="issue-link" data-issue-key="LU-5635"><del>LU-5635</del></a> here as well to fix it properly</p> <p>Mike Pershin (mike.pershin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/15316" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15316</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6714" title="llog_process_thread() may use wrong offset for the next block" class="issue-link" data-issue-key="LU-6714"><del>LU-6714</del></a> llog: fix wrong offset in llog_process_thread()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 6a18e003fd97fb360a4a94d347895b1392d3022f</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/15316/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15316/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6714" title="llog_process_thread() may use wrong offset for the next block" class="issue-link" data-issue-key="LU-6714"><del>LU-6714</del></a> llog: fix wrong offset in llog_process_thread()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: df45994ddcf5e6fdc379b3e1d43f1d26ba321a0e</p> <p>Landed for 2.8</p> <p>Mike Pershin (mike.pershin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/15835" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15835</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6714" title="llog_process_thread() may use wrong offset for the next block" class="issue-link" data-issue-key="LU-6714"><del>LU-6714</del></a> llog: test plain llog more throughly<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 1ed810ab336dad8881eb3507353697958ec4a708</p> <p>Mike Pershin (mike.pershin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/15841" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15841</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6714" title="llog_process_thread() may use wrong offset for the next block" class="issue-link" data-issue-key="LU-6714"><del>LU-6714</del></a> llog: fix the llog_cat_set_first_idx()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 116467aac55d9cbf55633b85915511c0c9256f55</p> <p>Looks like the <a href="http://review.whamcloud.com/15841" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15841</a> patch is not landed yet.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/15841/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15841/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6714" title="llog_process_thread() may use wrong offset for the next block" class="issue-link" data-issue-key="LU-6714"><del>LU-6714</del></a> llog: fix the llog_cat_set_first_idx()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: a830c06c612125cf517c66823078364c0c509de9</p> <p>fix was landed</p> <p>Mike</p> <p>Doesn't this ticket need to remain open until <a href="http://review.whamcloud.com/#/c/15835/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/15835/</a> lands? Or can this work be abandoned or tracked under another ticket #?</p> <p>Peter</p> <p>this ticket can be closed, the patch you mentioned is under different ticket already</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/15835/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15835/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6714" title="llog_process_thread() may use wrong offset for the next block" class="issue-link" data-issue-key="LU-6714"><del>LU-6714</del></a> llog: test plain llog more throughly<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: f17796cf08df5004fa68b9b4a9b0e221559389dc</p> <p>Mike Pershin (mike.pershin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/16287" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16287</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6714" title="llog_process_thread() may use wrong offset for the next block" class="issue-link" data-issue-key="LU-6714"><del>LU-6714</del></a> llog: test on-disk llog header values<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 74e9220de55d8bd2eb5560d26c53a48684bbc66b</p> <p>Mike Pershin (mike.pershin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/16288" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16288</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6714" title="llog_process_thread() may use wrong offset for the next block" class="issue-link" data-issue-key="LU-6714"><del>LU-6714</del></a> llog: add test for llh_cat_idx checking<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: dcebb42f60abd1741b68ec7f35226c1680b83ee9</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/16287/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16287/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6714" title="llog_process_thread() may use wrong offset for the next block" class="issue-link" data-issue-key="LU-6714"><del>LU-6714</del></a> llog: test on-disk llog header values<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e667cd00c8312258453f0a081c51cf2e6233999a</p> Related LU-5635 LU-6944 LU-9312 Development Rank 1|hzxfmf: Rank (Obsolete) 9223372036854775807 Severity