https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-6912 Lustre <p>We don't check for new version of RHEL releases. And any attempt to compile Lustre with external OFED will fail on RHEL 6.[67] and RHEL 7.x.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-keyword">case</span> <span class="code-quote">"$RHEL_RELEASE_NO"</span> in 64) EXTRA_OFED_INCLUDE=<span class="code-quote">"$EXTRA_OFED_INCLUDE -DCONFIG_COMPAT_RHEL_6_4"</span> ;; 65) EXTRA_OFED_INCLUDE=<span class="code-quote">"$EXTRA_OFED_INCLUDE -DCONFIG_COMPAT_RHEL_6_4 -DCONFIG_COMPAT_RHEL_6_5"</span> ;; esac </pre> </div></div> <p>OFED distributive (at least latest versions) has autoconfig header file (compat_autoconf.h) with full set of defines we should specify for current OS. We should use it instead of provide our own defines and checks. This allow avoid dependency from OS and OFED version.</p> LU-6912

rework autoconf rules for external OFED to avoid dependency from OS

Improvement Major Resolved Fixed Dmitry Eremin Dmitry Eremin Mon, 27 Jul 2015 18:37:00 +0000 Wed, 14 Oct 2015 15:26:43 +0000 Mon, 31 Aug 2015 13:02:58 +0000 Lustre 2.8.0 0 12 <p>Do we have to do this for SLES12 and Ubuntu<span class="error">&#91;14|15&#93;</span> as well?</p> <p>This is a good question!</p> <p>Why are we setting CONFIG_COMPAT_RHEL_6_4 on RHEL 6.5?</p> <p>I think setting CONFIG_COMPAT_RHEL_6_4 on 6.5 is a bug. I just looked at OFED 3.18 and we don't need to worry about Ubuntu or SLES12 since they follow very closely the upstream kernel OFED sets CONFIG_COMPAT_* to some kernel version. So SLES12 just ends up being CONFIG_COMPAT_3_12. Only RHELX needs special help since it is a mutant kernel.</p> <p>No, it's not a bug. It's requirement. According OFED sources they use new defines only for new portion of code specifically related to new OS support, All previous defines should be specified also. If you see in OFED configuration script you will see the following:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">RHEL_MINOR := $(shell grep ^RHEL_MINOR $(KLIB_BUILD)/Makefile | sed -n <span class="code-quote">'s/.*= *\(.*\)/\1/p'</span>) COMPAT_RHEL_VERSIONS := $(shell I=$(RHEL_MINOR); <span class="code-keyword">while</span> [ <span class="code-quote">"$$I"</span> -ge 0 ]; <span class="code-keyword">do</span> echo $$I; I=$$(($$I - 1)); done) $(foreach ver,$(COMPAT_RHEL_VERSIONS),$(eval CONFIG_COMPAT_RHEL_$(RHEL_MAJOR)_$(ver)=y)) </pre> </div></div> <p>So, for RHEL 6.5 all defines (6.4, 6.3, 6.2, 6.1 and 6.0) will be specified.</p> <p>Actually we will have an error of compilation on RHEL 6.5 only if CONFIG_COMPAT_RHEL_6_4 will not be specified. But I think current approach with specifing defines for OFED is not correct and latest issue <a href="https://jira.whamcloud.com/browse/LU-6769" title="Mellanox backport header (kthread.h) conflicts with newer kernels" class="issue-link" data-issue-key="LU-6769"><del>LU-6769</del></a> prove this. OFED distributive (at least latest versions) has autoconfig header file (compat_autoconf.h) with full set of defines we should specify for current OS. We should use it instead of provide our own defines and checks. I'm working on this patch now.</p> <p>Dmitry Eremin (dmitry.eremin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/15811" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15811</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6912" title="rework autoconf rules for external OFED to avoid dependency from OS" class="issue-link" data-issue-key="LU-6912"><del>LU-6912</del></a> lnet: rework autoconf rules for external OFED<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 0de9e3d2b4c08f03e18b43b14341002814607e0a</p> <p>Unfortunately header O2IBPATH/include/linux/compat_autoconf.h exist in modern OFEDs only. So we still need automatically generate CONFIG_COMPAT_RHEL_<b>_</b> for RHEL distributive if it absent. With patch <a href="http://review.whamcloud.com/15811" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15811</a> new RHEL versions will be supported automatically. Also no errors should be on Ubuntu if O2IBPATH set correctly to DKMS compiled directory.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/15811/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15811/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-6912" title="rework autoconf rules for external OFED to avoid dependency from OS" class="issue-link" data-issue-key="LU-6912"><del>LU-6912</del></a> lnet: rework autoconf rules for external OFED<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: d98974fce00c6974168173abe6fddca3a8c19670</p> <p>Landed for 2.8.</p> Related Development Rank 1|hzxj3r: Rank (Obsolete) 9223372036854775807 Severity