https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-7004 Lustre <p>The <tt>lctl set_param -P</tt> functionality was landed via <a href="https://jira.whamcloud.com/browse/LU-3155" title="Permanent parameters with lctl set_param -P" class="issue-link" data-issue-key="LU-3155"><del>LU-3155</del></a> for 2.5.0 and deprecates <tt>lctl conf_param</tt> usage. There is a deprecation message printed in <tt>jt_lcfg_mgsparam()</tt> since 2.7.53 that conf_param is obsolete and set_param should be used instead.</p> <p>The test scripts need to be changed over to use "lctl set_param -P" exclusively, both to quiet the deprecation warning, as well as verify that the "lctl set_param -P" functionality is working correctly.</p> <p>For now, I'm going to bump the deprecation warning to 2.8.53 to give us time to make this change in the 2.9 release cycle since there isn't enough time to do it for 2.8.0 anymore.</p> LU-7004

fix "lctl set_param -P" to allow deprecation of "lctl conf_param"

Improvement Critical Resolved Fixed James A Simmons Andreas Dilger llnl patch Thu, 13 Aug 2015 18:47:38 +0000 Thu, 2 Nov 2023 02:11:39 +0000 Fri, 4 Jan 2019 05:05:05 +0000 Lustre 2.9.0 Lustre 2.13.0 0 15 <p>Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/15979" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15979</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7004" title="fix &quot;lctl set_param -P&quot; to allow deprecation of &quot;lctl conf_param&quot;" class="issue-link" data-issue-key="LU-7004"><del>LU-7004</del></a> utils: defer conf_param deprecation<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: e44795ec78b6d42fa8b6702cc6e4a57718cb5db1</p> <p>Andreas Dilger (andreas.dilger@intel.com) merged in patch <a href="http://review.whamcloud.com/15979/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15979/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7004" title="fix &quot;lctl set_param -P&quot; to allow deprecation of &quot;lctl conf_param&quot;" class="issue-link" data-issue-key="LU-7004"><del>LU-7004</del></a> utils: defer conf_param deprecation<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 1305c503ce158b3a8a65b8f03b54a3f4894c5108</p> <p>I would argue that deprecating lctl conf_param requires a lot more discussion and planning. lctl set_param -P is currently broken for some (many?) settings. There is also some question in my mind about whether lctl set_param -P is even a reasonable user interface.</p> <p>I bumped into the "conf_param is deprecated" message again after the build version was bumped to 2.8.53.</p> <p>Artem, is there any plan to address the testing issues in this ticket and <a href="https://jira.whamcloud.com/browse/LU-7183" title="lctl set_param -P does not work for sptlrpc flavor" class="issue-link" data-issue-key="LU-7183"><del>LU-7183</del></a>, as well as update the User Manual to use <tt>set_param -P</tt> instead of <tt>conf_param</tt>?</p> <p>For now I'm going to remove the deprecation warning completely instead of pushing it to a later release, since there has been no action on this issue in a year.</p> <p>Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/20573" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/20573</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7004" title="fix &quot;lctl set_param -P&quot; to allow deprecation of &quot;lctl conf_param&quot;" class="issue-link" data-issue-key="LU-7004"><del>LU-7004</del></a> utils: remove "lctl conf_param" deprecation<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 737413d7b7a0c5dd2e5a88c77ffe8d72df5847fd</p> <p>&gt;Artem, is there any plan to address the testing issues in this ticket and <a href="https://jira.whamcloud.com/browse/LU-7183" title="lctl set_param -P does not work for sptlrpc flavor" class="issue-link" data-issue-key="LU-7183"><del>LU-7183</del></a>, as well as update the User Manual to use set_param -P instead of conf_param?</p> <p>Andreas, yes sure. But I need to find time this.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/20573/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/20573/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7004" title="fix &quot;lctl set_param -P&quot; to allow deprecation of &quot;lctl conf_param&quot;" class="issue-link" data-issue-key="LU-7004"><del>LU-7004</del></a> utils: remove "lctl conf_param" deprecation<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e3c6c6739d8edc48e325843e1075a1fe8c157ec9</p> <p>Look like everything landed for 2.9</p> <p>The landed patch only removed the deprecation of "conf_param", but didn't actually fix "set_param -P" at all.</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/28590" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28590</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7004" title="fix &quot;lctl set_param -P&quot; to allow deprecation of &quot;lctl conf_param&quot;" class="issue-link" data-issue-key="LU-7004"><del>LU-7004</del></a> obd: make LCFG_SET_PARAM functional<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 2323a12774ab66d546a257240d6d931dcabc3af9</p> <p>After much sweat and tears I think I got lctl set_param -P working again for the most part. The issue with sptlrpc might be more involved but for the other stuff it appears to work now. Once we have this working I would suggest that we back port this to b2_10 and re-enable the lctl conf_param deprecate warning so user can move to lctl set_param -P before the next major LTS lustre version.</p> <p>Okay I rewrote the mgs llog to be more understandable. I do have one question which is the not clear in the docs. I see failover.nid being set with:</p> <p>lctl conf_param $fsname-MDT0001.failover.node=$nid</p> <p>Now with lctl set_param -P is it the same format:</p> <p>lctl set_param -P $fsname-MDT0001.failover.node=$nid</p> <p>or should it be:</p> <p>lctl set_param -P mdt.$fsname-MDT0001.failover.node=$nid</p> <p>With <tt>lctl set_param -P</tt> it should be <tt>&lt;device&gt;.&lt;instance&gt;.param</tt>. That said, I can't find anything in <tt>/{proc,sys}/fs/lustre</tt> named either <tt>node</tt> or <tt>failover</tt> (excluding a few <tt>nodemap</tt> files). I suspec this is a "virtual" attribute, and not one that actually lives in the /proc tree somewhere?</p> <p>We have 4 classes of parameters. </p> <p>Class one are the global values i.e PARAM_TIMEOUT, PARAM_JOBID_VAR. The patch for this ticket adds support for this class for set_param -P. </p> <p>The second class are the ones settable at mount or initial format i.e PARAM_MGSNODE, PARAM_NETWORK. Those should never be changed with set_param -P so they are filtered out. The patch for this ticket adds that filtering. Currently you can stomp on those values with set_param -P <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/> </p> <p>The 3rd class is your typical obd proc mapping. This somewhat worked for set_param -P.</p> <p>Lastly we have your "virtual" devices. Some of these that were virtual can now be mapped to real proc/sysfs entries. The two for this case are PARAM_ACTIVATE and PARAM_ID_UPCALL. Its PARAM_FAILNODE and PARAM_SRPC that are currently virtual. I have managed to allow setting the failnode node using set_param -P but it doesn't transmit the change to the client for some reason. As for PARAM_SRPC I have no idea what the goal was there. In lustre_param.h it list srpc.flavor as a proc entry but it doesn't exist. Anyways I will have to cover that in <a href="https://jira.whamcloud.com/browse/LU-7183" title="lctl set_param -P does not work for sptlrpc flavor" class="issue-link" data-issue-key="LU-7183"><del>LU-7183</del></a>.</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/30087" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30087</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7004" title="fix &quot;lctl set_param -P&quot; to allow deprecation of &quot;lctl conf_param&quot;" class="issue-link" data-issue-key="LU-7004"><del>LU-7004</del></a> tests: move from lctl conf_param to lctl set_param -P<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 57e99d4dd495dd0e69daee9dc52931c33fa45395</p> <p>I also got this working. Only one test fails with lctl set_param -P which I tracked down to the problem that the lcfg changes are only being transmitted to the clients. So trying to deactivate an OST/MDT only appears to happen on the client and the servers don't see the same change. It appears the choice of where to send the lcfg info is done in the mgc layer. Does anyone know the exact method of how this done?</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/28590/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28590/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7004" title="fix &quot;lctl set_param -P&quot; to allow deprecation of &quot;lctl conf_param&quot;" class="issue-link" data-issue-key="LU-7004"><del>LU-7004</del></a> obd: make LCFG_SET_PARAM functional<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: dfe60d0b98a1a888ca4ffce14788938c192b1520</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/31081" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31081</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7004" title="fix &quot;lctl set_param -P&quot; to allow deprecation of &quot;lctl conf_param&quot;" class="issue-link" data-issue-key="LU-7004"><del>LU-7004</del></a> quota: make lctl set_param -P functional for quota<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: e68d0a91625c64dd66dc2f7395cf7dd102dba57b</p> <p>Minh Diep (minh.diep@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/31207" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31207</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7004" title="fix &quot;lctl set_param -P&quot; to allow deprecation of &quot;lctl conf_param&quot;" class="issue-link" data-issue-key="LU-7004"><del>LU-7004</del></a> obd: make LCFG_SET_PARAM functional<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: 1<br/> Commit: 14d209c516d710585d4c492bfdfa6d2eb1add25d</p> <p>John L. Hammond (john.hammond@intel.com) merged in patch <a href="https://review.whamcloud.com/31207/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31207/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7004" title="fix &quot;lctl set_param -P&quot; to allow deprecation of &quot;lctl conf_param&quot;" class="issue-link" data-issue-key="LU-7004"><del>LU-7004</del></a> obd: make LCFG_SET_PARAM functional<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: <br/> Commit: d7f9f2130c5d8c74004f36aa68938df57778a6b1</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/31081/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/31081/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7004" title="fix &quot;lctl set_param -P&quot; to allow deprecation of &quot;lctl conf_param&quot;" class="issue-link" data-issue-key="LU-7004"><del>LU-7004</del></a> quota: make lctl set_param -P functional for quota<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 6d9df3b2c0d54b16d00b6e419c7bb958e6b54844</p> <p>So the good news is that I found lctl conf_param lustre-OST*.failover.node=10.0.0.1@tcp can be done with set_param <del>P with already existing code. The command to do it is lctl set_param -P osc.lustre-OST</del>*.import=connection=10.0.0.1@tcp. So its just a matter of updating the test in this case. Only sptlrpc is not functional.</p> <p>looks like this work is coming to completion <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/32784" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32784</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7004" title="fix &quot;lctl set_param -P&quot; to allow deprecation of &quot;lctl conf_param&quot;" class="issue-link" data-issue-key="LU-7004"><del>LU-7004</del></a> obd: handle fsname-MDT0000-**<b><del>MDT0000</del></b> for obdname2fsname<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 29b45b5dd7c87dbf4b6168ca07d8bbd0acbafe84</p> <p>So I see one regression with lctl set_param -P.  Some test use the form get the parameter valu:</p> <p>lctl set_param osc.lustre-OST0001-osc-<span class="error">&#91;^M&#93;</span>*.active=1</p> <p>The shell seems to expand this properly or the get_param routine parses this correctly.</p> <p>Now if I run on the MGS lctl set_param "<del>P" osc.lustre-OST0001-osc</del><span class="error">&#91;^M&#93;</span>*.active=1 then the <span class="error">&#91;^M&#93;</span> is actually cached in the config logs. The function obdname2fsname() chokes on this wildcard. So the question is how to handle this. I see the following:</p> <p>1) Make the shell expand the <span class="error">&#91;^M&#93;</span> to some value before passing the string to lctl itself. I don't know how to       do that <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>2) Use regex or something in the C code of lctl to expand this out before packing the data for the ioctl on           the MGS.</p> <p>3) Change the test scripts to drop the <span class="error">&#91;^M&#93;</span> for lctl set_param -P.</p> <p>Which is the best option?</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/30087/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/30087/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7004" title="fix &quot;lctl set_param -P&quot; to allow deprecation of &quot;lctl conf_param&quot;" class="issue-link" data-issue-key="LU-7004"><del>LU-7004</del></a> tests: move from lctl conf_param to lctl set_param -P<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: b9c359a70db9d5a6b69cc222c5f3b306a23df8b1</p> <p>Can patch <a href="https://review.whamcloud.com/#/c/32784" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/#/c/32784</a> be reviewed so it can land for 2.12. It was discovered that obdname2fsname() doesn't cover all the cases so this patch removes the use of obdname2fsname() on the MSG server when dealing with config logs. Currently it can break in some corner cases. After this patch then obdname2fsname() will only be used with sptlrpc like before. That can be addressed in the follow on <a href="https://jira.whamcloud.com/browse/LU-10937" title="Use sysfs to fix up sptlrpc handling." class="issue-link" data-issue-key="LU-10937">LU-10937</a> patch for 2.13.</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/32784/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/32784/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7004" title="fix &quot;lctl set_param -P&quot; to allow deprecation of &quot;lctl conf_param&quot;" class="issue-link" data-issue-key="LU-7004"><del>LU-7004</del></a> mgs: remove using obdname2fsname() from mgs layer.<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 5da91cd4e44f8113b00035324738a9bb67f8a597</p> <p>James</p> <p>Do I recall correctly - this is the only fix needed but it should be queued up for 2.12.1 in addition to being in 2.13?</p> <p>Peter</p> <p>Yes this last patch should land for 2.12. Currently the params files on the MGS server can have malformed names. Rare but can happen. </p> <p>"Andreas Dilger &lt;adilger@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/doc/manual/+/52553" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/doc/manual/+/52553</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7004" title="fix &quot;lctl set_param -P&quot; to allow deprecation of &quot;lctl conf_param&quot;" class="issue-link" data-issue-key="LU-7004"><del>LU-7004</del></a> utils: prefer 'set_param -P' over 'conf_param'<br/> Project: doc/manual<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: d8be3b93093855f1a1a27994fe37aa8daecf04ef</p> <p>"Andreas Dilger &lt;adilger@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/doc/manual/+/52553/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/doc/manual/+/52553/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7004" title="fix &quot;lctl set_param -P&quot; to allow deprecation of &quot;lctl conf_param&quot;" class="issue-link" data-issue-key="LU-7004"><del>LU-7004</del></a> utils: prefer 'set_param -P' over 'conf_param'<br/> Project: doc/manual<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 19c2cce1fa5a52aa2536cc75833bc8c0d4593d7d</p> Related LU-8414 LU-3155 LU-10937 LU-8482 LU-9431 LU-7031 LU-9399 LU-10626 LU-10756 Development Rank 1|hzxkgn: Rank (Obsolete) 9223372036854775807