[LU-7025] lfsck_layout_scan_stripes suspicious rc assignment

Mon, 24 Aug 2015 15:47:55 +0000

We seem to be having this sort of code there:

                if (lso == NULL) {
                        struct lu_attr *attr = &info->lti_la;

                        rc = dt_attr_get(env, parent, attr);
                        if (rc != 0) {
                                rc = PTR_ERR(lso);
                                goto next;
                        }

Now note that lso is already NULL - meaning we reset nonzero rc into zero in quite a roundabout way.
Are you sure this is what was desired? I think we should just reuse the rc with the error instead?

Whamcloud Community JIRA

[LU-7025] lfsck_layout_scan_stripes suspicious rc assignment