Whamcloud Community JIRA

Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us

9.4.14

940014

05-12-2023

[LU-708] OSD Misc feature landing tracker https://jira.whamcloud.com/browse/LU-708 Lustre <p>Task to track landings of various small fixes and code cleanups from orion onto master.</p> LU-708

OSD Misc feature landing tracker

Story Minor Resolved Fixed Zhenyu Xu Andreas Dilger Thu, 22 Sep 2011 13:11:06 +0000 Thu, 25 Apr 2013 09:41:54 +0000 Thu, 25 Apr 2013 09:41:54 +0000 Lustre 2.3.0 0 3 <p>I'm using "More Actions->Link Issue" to link to ORI-300, another change that can land on master directly. Hopefully this will be a useful way to track these changes for landing on master.</p> <p>The restructuring of the mkfs.lustre, tunefs.lustre and mount.lustre could be landed on master without affecting the functionality.</p> <p>ORI-300 port to master patch tracking at <a href="http://review.whamcloud.com/1653" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/1653</a></p> <p>refactor mkfs/tunefs/mount port to master patch tracking at <a href="http://review.whamcloud.com/1762" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/1762</a> (ORI-294)</p> <p>This last patch seems to break mgs failover. Chris has been using this patch and is now unable to mount a lustre client with two mgs nids.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre># mount -t lustre -o user_xattr,acl,flock 10.10.4.190@tcp0:10.10.4.194@tcp0:/lustre /mnt/lustre mount.lustre: 10.10.4.190@tcp:10.10.4.194@tcp:/lustre has not been formatted with mkfs.lustre or the backend filesystem type is not supported by this tool </pre> </div></div> <p>This error message is returned by parse_ldd() and from the code:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">if</span> (!devname_is_client(mop.mo_usource)) { rc = parse_ldd(mop.mo_source, &mop, options); <span class="code-keyword">if</span> (rc) <span class="code-keyword">goto</span> out; } </pre> </div></div> <p>Obviously, parse_ldd() should not be executed for client mount, so somehow devname_is_client() failed to detect that we are trying to mount a lustre client. Then i ran mount.lustre directly to check the arguments:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre># mount.lustre -v -o user_xattr,acl,flock 10.10.4.190@tcp0:10.10.4.194@tcp0:/lustre /mnt/lustre arg[0] = mount.lustre arg[1] = -v arg[2] = -o arg[3] = user_xattr,acl,flock arg[4] = 10.10.4.190@tcp0 arg[5] = /mnt/lustre source = 10.10.4.190@tcp0 (10.10.4.190@tcp:10.10.4.194@tcp:/lustre) target = /mnt/lustre options = user_xattr,acl,flock checking for existing Lustre data: not found mount.lustre: 10.10.4.190@tcp:10.10.4.194@tcp:/lustre has not been formatted with mkfs.lustre or the backend filesystem type is not supported by this tool </pre> </div></div> <p>As you can see, mop.mo_usource = 10.10.4.190@tcp0 instead of 10.10.4.190@tcp:10.10.4.194@tcp:/lustre. This explains why devname_is_client() fails.<br/> However, i have no idea yet why mo_usource is truncated.<br/> For the record, it works well with just one nid:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre># mount.lustre -v -o user_xattr,acl,flock 10.10.4.194@tcp0:/lustre /mnt/lustre arg[0] = mount.lustre arg[1] = -v arg[2] = -o arg[3] = user_xattr,acl,flock arg[4] = 10.10.4.194@tcp0:/lustre arg[5] = /mnt/lustre source = 10.10.4.194@tcp0:/lustre (10.10.4.194@tcp:/lustre) target = /mnt/lustre options = user_xattr,acl,flock </pre> </div></div> <p>Actually, the problem is that convert_hostnames() modifies the string given as argument, so the following does not work:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"><span class="code-comment">/* convert nids part, but not fsname part */</span> tmp = *ptr; *ptr = <span class="code-quote">'\0'</span>; nids = convert_hostnames(mop->mo_usource); <span class="code-keyword">if</span> (!nids) usage(stderr); *ptr = tmp; </pre> </div></div> <p>I think Orion also has this issue, the char *convert_hostnames(char *s1) has changed argument @s1 while it should not.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> while ((left > 0) && (s1 < end)) { s2 = strpbrk(s1, ",:"); if (s2 == NULL) s2 = end; sep = *s2; *s2 = '\0'; nid = libcfs_str2nid(s1); + *s2 = sep; // Forget to put back the separator in s1. </pre> </div></div> <p>Right, could you please push a fix to the orion branch too?</p> <p>Ok, orion fix posted at <a href="http://review.whamcloud.com/1821" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/1821</a></p> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-dev/./arch=x86_64,build_type=client,distro=el5,ib_stack=inkernel/340/" class="external-link" target="_blank" rel="nofollow noopener">lustre-dev » x86_64,client,el5,inkernel #340</a><br/> <a href="https://jira.whamcloud.com/browse/LU-708" title="OSD Misc feature landing tracker" class="issue-link" data-issue-key="LU-708"><del>LU-708</del></a> utils: convert_hostnames() should not change its arg (Revision cf6b187c6fe73447455478998554f3662779e9e8)</p> <p> Result = SUCCESS<br/> Mikhail Pershin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-dev.git;a=shortlog;h=refs/heads/$GIT_BRANCH&a=commit&h=cf6b187c6fe73447455478998554f3662779e9e8" class="external-link" target="_blank" rel="nofollow noopener">cf6b187c6fe73447455478998554f3662779e9e8</a><br/> Files : </p> <ul> <li>lustre/utils/mount_utils.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-dev/./arch=i686,build_type=client,distro=el6,ib_stack=inkernel/340/" class="external-link" target="_blank" rel="nofollow noopener">lustre-dev » i686,client,el6,inkernel #340</a><br/> <a href="https://jira.whamcloud.com/browse/LU-708" title="OSD Misc feature landing tracker" class="issue-link" data-issue-key="LU-708"><del>LU-708</del></a> utils: convert_hostnames() should not change its arg (Revision cf6b187c6fe73447455478998554f3662779e9e8)</p> <p> Result = SUCCESS<br/> Mikhail Pershin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-dev.git;a=shortlog;h=refs/heads/$GIT_BRANCH&a=commit&h=cf6b187c6fe73447455478998554f3662779e9e8" class="external-link" target="_blank" rel="nofollow noopener">cf6b187c6fe73447455478998554f3662779e9e8</a><br/> Files : </p> <ul> <li>lustre/utils/mount_utils.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-dev/./arch=i686,build_type=server,distro=el5,ib_stack=inkernel/340/" class="external-link" target="_blank" rel="nofollow noopener">lustre-dev » i686,server,el5,inkernel #340</a><br/> <a href="https://jira.whamcloud.com/browse/LU-708" title="OSD Misc feature landing tracker" class="issue-link" data-issue-key="LU-708"><del>LU-708</del></a> utils: convert_hostnames() should not change its arg (Revision cf6b187c6fe73447455478998554f3662779e9e8)</p> <p> Result = SUCCESS<br/> Mikhail Pershin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-dev.git;a=shortlog;h=refs/heads/$GIT_BRANCH&a=commit&h=cf6b187c6fe73447455478998554f3662779e9e8" class="external-link" target="_blank" rel="nofollow noopener">cf6b187c6fe73447455478998554f3662779e9e8</a><br/> Files : </p> <ul> <li>lustre/utils/mount_utils.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-dev/./arch=x86_64,build_type=server,distro=el6,ib_stack=inkernel/340/" class="external-link" target="_blank" rel="nofollow noopener">lustre-dev » x86_64,server,el6,inkernel #340</a><br/> <a href="https://jira.whamcloud.com/browse/LU-708" title="OSD Misc feature landing tracker" class="issue-link" data-issue-key="LU-708"><del>LU-708</del></a> utils: convert_hostnames() should not change its arg (Revision cf6b187c6fe73447455478998554f3662779e9e8)</p> <p> Result = SUCCESS<br/> Mikhail Pershin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-dev.git;a=shortlog;h=refs/heads/$GIT_BRANCH&a=commit&h=cf6b187c6fe73447455478998554f3662779e9e8" class="external-link" target="_blank" rel="nofollow noopener">cf6b187c6fe73447455478998554f3662779e9e8</a><br/> Files : </p> <ul> <li>lustre/utils/mount_utils.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-dev/./arch=i686,build_type=client,distro=el5,ib_stack=inkernel/340/" class="external-link" target="_blank" rel="nofollow noopener">lustre-dev » i686,client,el5,inkernel #340</a><br/> <a href="https://jira.whamcloud.com/browse/LU-708" title="OSD Misc feature landing tracker" class="issue-link" data-issue-key="LU-708"><del>LU-708</del></a> utils: convert_hostnames() should not change its arg (Revision cf6b187c6fe73447455478998554f3662779e9e8)</p> <p> Result = SUCCESS<br/> Mikhail Pershin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-dev.git;a=shortlog;h=refs/heads/$GIT_BRANCH&a=commit&h=cf6b187c6fe73447455478998554f3662779e9e8" class="external-link" target="_blank" rel="nofollow noopener">cf6b187c6fe73447455478998554f3662779e9e8</a><br/> Files : </p> <ul> <li>lustre/utils/mount_utils.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-dev/./arch=x86_64,build_type=server,distro=el5,ib_stack=inkernel/340/" class="external-link" target="_blank" rel="nofollow noopener">lustre-dev » x86_64,server,el5,inkernel #340</a><br/> <a href="https://jira.whamcloud.com/browse/LU-708" title="OSD Misc feature landing tracker" class="issue-link" data-issue-key="LU-708"><del>LU-708</del></a> utils: convert_hostnames() should not change its arg (Revision cf6b187c6fe73447455478998554f3662779e9e8)</p> <p> Result = SUCCESS<br/> Mikhail Pershin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-dev.git;a=shortlog;h=refs/heads/$GIT_BRANCH&a=commit&h=cf6b187c6fe73447455478998554f3662779e9e8" class="external-link" target="_blank" rel="nofollow noopener">cf6b187c6fe73447455478998554f3662779e9e8</a><br/> Files : </p> <ul> <li>lustre/utils/mount_utils.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-dev/./arch=x86_64,build_type=client,distro=el6,ib_stack=inkernel/340/" class="external-link" target="_blank" rel="nofollow noopener">lustre-dev » x86_64,client,el6,inkernel #340</a><br/> <a href="https://jira.whamcloud.com/browse/LU-708" title="OSD Misc feature landing tracker" class="issue-link" data-issue-key="LU-708"><del>LU-708</del></a> utils: convert_hostnames() should not change its arg (Revision cf6b187c6fe73447455478998554f3662779e9e8)</p> <p> Result = SUCCESS<br/> Mikhail Pershin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-dev.git;a=shortlog;h=refs/heads/$GIT_BRANCH&a=commit&h=cf6b187c6fe73447455478998554f3662779e9e8" class="external-link" target="_blank" rel="nofollow noopener">cf6b187c6fe73447455478998554f3662779e9e8</a><br/> Files : </p> <ul> <li>lustre/utils/mount_utils.c</li> </ul> Related LU-709 LU-732 Development Project Rank 1|hzv5x3: Rank (Obsolete) 4493 Story Points 8.0