https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-7160 Lustre <p>lctl replace_nids command saves previous version of<br/> config files to file with original_name.bak file name.<br/> This file should never be processed by MGS.</p> <p>This patch adds code that skips file with .bak extention<br/> from list to be processed by MGS.</p> LU-7160

Saved by change_nids .bak files on MGS should never be processed

Bug Minor Resolved Fixed WC Triage Artem Blagodarenko patch Tue, 15 Sep 2015 10:17:38 +0000 Thu, 22 Nov 2018 00:05:40 +0000 Mon, 22 Aug 2016 15:58:32 +0000 Lustre 2.9.0 0 5 <p>Artem Blagodarenko (artem.blagodarenko@seagate.com) uploaded a new patch: <a href="http://review.whamcloud.com/16428" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16428</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7160" title="Saved by change_nids .bak files on MGS should never be processed" class="issue-link" data-issue-key="LU-7160"><del>LU-7160</del></a> mgs: Skip processing .bak files on MGS<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: e0451cd7e0f6044a48d6f592932c63528fa21f05</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/16428/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16428/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7160" title="Saved by change_nids .bak files on MGS should never be processed" class="issue-link" data-issue-key="LU-7160"><del>LU-7160</del></a> mgs: Skip processing .bak files on MGS<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 0bb49b2624827490ca3ea6a146d96cf7cf2b402f</p> <p>Landed for 2.9</p> <p>As mentioned in my review of <a href="http://review.whamcloud.com/16428/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16428/</a> I think this patch could be more robust. In addition to .bak files, I've personally made backup files of the form <tt>myth-MDT0000-20160811</tt> before doing some major system change. Having the <tt>lctl replace_nids</tt> code change the NIDs in all of the backup files it finds kind of breaks the value of having backups in the first place...</p> <p>It would be more robust if the <tt>replace_nids</tt> code checked for specific filenames like <tt><em>fsname</em>-&lt;OST,MDT&gt;<em>nnnn</em></tt> and <tt><em>fsname</em>-client</tt> and only modified those files instead of changing every file that it finds in <tt>CONFIGS/</tt>.</p> <p>Fan Yong,<br/> does a similar problem exist with the rename filesystem patch <a href="http://review.whamcloud.com/18597" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/18597</a> ?</p> <p>Currently, the tools for rename filesystem name can filter out the names with "-" as postfix, such as "myth-MDT0000-20160811", after merging with the patch <a href="http://review.whamcloud.com/16428/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16428/</a>, it also can filter out the names with ".bak" as postfix. As for other format, such as "myth-MDT0000.2016", it will not be filtered out.</p> <p>&gt; I've personally made backup files of the form myth-MDT0000-20160811 before doing some major system change<br/> Andreas, probably storing backup files outside the Lustre FS is the best solution. This is more safe for files and for Lustre FS. If you store something (files that not used by Lustre FS) in config directory - no warranty.<br/> Another solution - store automatic backup files (from replace_nids for example) to other directory, not CONFIGS.</p> Related LU-10883 LU-11648 Development Rank 1|hzxnmf: Rank (Obsolete) 9223372036854775807 Severity