https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-7315 Lustre <ol> <li><b>Pointer may be passed to function that can dereference it after it was positively checked for NULL</b> <ul> <li><tt>lustre/osd-ldiskfs/osd_handler.c</tt>: in <em>osd_dirent_check_repair</em>, Pointer 'hlock' checked for NULL at line 5478 may be passed to function and may be dereferenced there by passing argument 4 to function '&#95;&#95;ldiskfs&#95;find&#95;entry' at line 5353. Also there are 2 similar errors on lines 5353.</li> </ul> </li> <li><b>Null pointer may be passed to function that may dereference it</b> <ul> <li><tt>lustre/osd-ldiskfs/osd_handler.c</tt>: in <em>osd_dirent_check_repair</em>, Null pointer 'hlock' that comes from line 5257 may be passed to function and can be dereferenced there by passing argument 4 to function '&#95;&#95;ldiskfs&#95;find&#95;entry' at line 5353.</li> </ul> </li> </ol> <p>The list of commits since the previous build 2.7.61-9-g4438262:</p> <div class='table-wrap'> <table class='confluenceTable'><tbody> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=723065fca5b0dc2f93848de47a0b82b11a6bbb1a" class="external-link" target="_blank" rel="nofollow noopener">723065f</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6868" title="MDT migration does not generate changelog records" class="issue-link" data-issue-key="LU-6868"><del>LU-6868</del></a> mdd: add changelog for migration</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=3c86f727f006ecb86e7a02acc4a4ce4d524894ed" class="external-link" target="_blank" rel="nofollow noopener">3c86f72</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-7295" title="hide debug message in OSP at umount" class="issue-link" data-issue-key="LU-7295"><del>LU-7295</del></a> osp: do not warn on uncommitted changes</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=9ea40a338c6e58a59792df56f963e58afced4e26" class="external-link" target="_blank" rel="nofollow noopener">9ea40a3</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6746" title="move IT_* definitions to lustre_idl.h" class="issue-link" data-issue-key="LU-6746"><del>LU-6746</del></a> ptlrpc: Move IT_* definitions to lustre_idl.h</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=4691290f6d39bffaa3e463697fbc3ac351015e76" class="external-link" target="_blank" rel="nofollow noopener">4691290</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6556" title="changelog catalog corruption if all possible records is define " class="issue-link" data-issue-key="LU-6556"><del>LU-6556</del></a> obdclass: re-allow catalog to wrap around</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=ef63c034b437d47cd10fe7ee94ed614ac1359f44" class="external-link" target="_blank" rel="nofollow noopener">ef63c03</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-4341" title="Failure on test suite sanity test_170: expected 31 bad lines, but got 34" class="issue-link" data-issue-key="LU-4341"><del>LU-4341</del></a> test: skip failing sanity test 170</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=e94d375d8a55af1d380b2f5f657a9b69045a6854" class="external-link" target="_blank" rel="nofollow noopener">e94d375</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-7153" title="Update ZFS/SPL version to 0.6.5.2" class="issue-link" data-issue-key="LU-7153"><del>LU-7153</del></a> build: Update SPL/ZFS to 0.6.5.2</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=10ebe81e394af356fbae4703ca47586d6b3bc367" class="external-link" target="_blank" rel="nofollow noopener">10ebe81</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6155" title="osd_count_not_mapped() calls dbuf_hold_impl() without the lock" class="issue-link" data-issue-key="LU-6155"><del>LU-6155</del></a> osd-zfs: dbuf_hold_impl() called without the lock</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=bee9c1897677473f12c0b807edd3e8fec452bc32" class="external-link" target="_blank" rel="nofollow noopener">bee9c18</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6852" title="MDS is evicted during 24-24 hours failover." class="issue-link" data-issue-key="LU-6852"><del>LU-6852</del></a> ldlm: Do not evict MDS-MDS connection</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=cc0733fe2d3c97435c4619f9123972641a8a6681" class="external-link" target="_blank" rel="nofollow noopener">cc0733f</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6215" title="Sync Lustre external tree with lustre linux kernel client" class="issue-link" data-issue-key="LU-6215"><del>LU-6215</del></a> lnet: make o2iblnd buildable for 4.2.1 kernels</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=31b7404f436241436fb0abdec2b6cd678c674d82" class="external-link" target="_blank" rel="nofollow noopener">31b7404</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-2049" title="add support for OBD_CONNECT_GRANT_PARAM" class="issue-link" data-issue-key="LU-2049"><del>LU-2049</del></a> grant: delay grant releasing until commit</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=dd16884e8e367007e792708901bdf55ffeac665b" class="external-link" target="_blank" rel="nofollow noopener">dd16884</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6204" title="modinfo data is stale, and would be nice if they included the lustre version" class="issue-link" data-issue-key="LU-6204"><del>LU-6204</del></a> misc: Add missing MODULE_VERSION for lustre</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=2907eb63d98a81384d79cd713b571fd311d9d474" class="external-link" target="_blank" rel="nofollow noopener">2907eb6</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-7244" title="build failed due to XATTR_NAME_EVM redefinition" class="issue-link" data-issue-key="LU-7244"><del>LU-7244</del></a> llite: Fix XATTR_NAME_EVM redefinition</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=173b3327265b32c385a4537666a78be3cf8e4943" class="external-link" target="_blank" rel="nofollow noopener">173b332</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-7122" title="Document -n switch for lctl changelog_register" class="issue-link" data-issue-key="LU-7122"><del>LU-7122</del></a> utils: changelog_ {de} <p>register cleanup</p></td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=bc17c8d35694867e1eadeb41bc1d487cd0baacb5" class="external-link" target="_blank" rel="nofollow noopener">bc17c8d</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6899" title="rename sanity test_162 to test_162a" class="issue-link" data-issue-key="LU-6899"><del>LU-6899</del></a> test: rename sanity test_162 to test_162a</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=1443374611c2d1b56e2b641b7d13aa3b5fba8815" class="external-link" target="_blank" rel="nofollow noopener">1443374</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-5733" title="Use lnet_is_route_alive for route aliveness" class="issue-link" data-issue-key="LU-5733"><del>LU-5733</del></a> lnet: Use lnet_is_route_alive for router aliveness</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=d2d725d2e2d31899f0453c967f5707a72e796fa0" class="external-link" target="_blank" rel="nofollow noopener">d2d725d</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-7184" title="(lod_dev.c:1493:lod_device_free()) ASSERTION( atomic_read(&amp;lu-&gt;ld_ref) == 0 ) failed: lu is ffff88010cf8a000" class="issue-link" data-issue-key="LU-7184"><del>LU-7184</del></a> lod: cleanup unused OSP devices on error</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=d8612e307f28cc81df5d93e45130b9f04837ee27" class="external-link" target="_blank" rel="nofollow noopener">d8612e3</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6895" title="sanity-lfsck test 4 hung: bad entry in directory: rec_len is smaller than minimal - inode=3925999616" class="issue-link" data-issue-key="LU-6895"><del>LU-6895</del></a> scrub: not trigger scrub if inode removed by race</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=eebc3da214dfcbc01ba637f0925bfe8635b26138" class="external-link" target="_blank" rel="nofollow noopener">eebc3da</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6895" title="sanity-lfsck test 4 hung: bad entry in directory: rec_len is smaller than minimal - inode=3925999616" class="issue-link" data-issue-key="LU-6895"><del>LU-6895</del></a> lfsck: not destroy directory when fix FID-in-dirent</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=5fa93f6011dc37fba3354137457b80151f46c66f" class="external-link" target="_blank" rel="nofollow noopener">5fa93f6</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6386" title="lower transno may overwrite the bigger one in client last_rcvd slot" class="issue-link" data-issue-key="LU-6386"><del>LU-6386</del></a> tgt: don't update client data with smaller transno</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=85c6c099d83b19480dd4160de57e7ffac5b312af" class="external-link" target="_blank" rel="nofollow noopener">85c6c09</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-7045" title="NOT enough transaction credits for osp_write_local_file()" class="issue-link" data-issue-key="LU-7045"><del>LU-7045</del></a> osd: enough credits for single indirect block write</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=888a3141e72a25bef8daf822325b4295e5a0d5e8" class="external-link" target="_blank" rel="nofollow noopener">888a314</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6842" title="Seeking the option to hook cl_page LRU up to kernel cache shrinker " class="issue-link" data-issue-key="LU-6842"><del>LU-6842</del></a> clio: add cl_page LRU shrinker</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=7b569574a484bb781ed5796040e0eb357aaeefb9" class="external-link" target="_blank" rel="nofollow noopener">7b56957</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-7005" title="conf-sanity test_50i: lustre-MDT0001-osp-MDT0000:osp_attr_get update error" class="issue-link" data-issue-key="LU-7005"><del>LU-7005</del></a> tests: wait client imports fully recovered</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=e72c1505dfeb9cd2a6581a2752c5a21ae61e9389" class="external-link" target="_blank" rel="nofollow noopener">e72c150</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-7196" title="Kernel update for RHEL6.7 [2.6.32-573.7.1.el6]" class="issue-link" data-issue-key="LU-7196"><del>LU-7196</del></a> kernel: kernel update RHEL 6.7 <span class="error">&#91;2.6.32-573.7.1.el6&#93;</span></td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=cbb42d0ac88ea7ba49f1fcc85fadb51f5950ab63" class="external-link" target="_blank" rel="nofollow noopener">cbb42d0</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6886" title="declare changelog store for POSIX ACLs in mdd_xattr_del" class="issue-link" data-issue-key="LU-6886"><del>LU-6886</del></a> mdd: declare changelog store for POSIX ACLs</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=4d4771b8efbecf530f3079f0681b896aede0e353" class="external-link" target="_blank" rel="nofollow noopener">4d4771b</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-7074" title="skip invalid linkEA entry in migration" class="issue-link" data-issue-key="LU-7074"><del>LU-7074</del></a> mdd: validate the linkea before packing</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=adce06a1c31cfd39f11353f5bbf691dbc72d8783" class="external-link" target="_blank" rel="nofollow noopener">adce06a</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-7228" title="lustre rpm should provide lustre-client" class="issue-link" data-issue-key="LU-7228"><del>LU-7228</del></a> build: make lustre rpm also provide lustre-client</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=9937eb5fa44c66af36fae39767468a76714a2207" class="external-link" target="_blank" rel="nofollow noopener">9937eb5</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-7082" title="conf-sanity test_90b: MDT start failed" class="issue-link" data-issue-key="LU-7082"><del>LU-7082</del></a> test: fix synchronization of conf_sanity test_90</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=a2844eb7d4ea15b8164f219aec1900037f0c506b" class="external-link" target="_blank" rel="nofollow noopener">a2844eb</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6215" title="Sync Lustre external tree with lustre linux kernel client" class="issue-link" data-issue-key="LU-6215"><del>LU-6215</del></a> ldlm: handle percpu_counter_init change in 3.18+ kernels</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=55afbf5934e145e48a31193de601abd58e605a42" class="external-link" target="_blank" rel="nofollow noopener">55afbf5</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6527" title="Journal commit callback opitmization" class="issue-link" data-issue-key="LU-6527"><del>LU-6527</del></a> ext4: journal_commit_callback optimization</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=7f5c9753872cfa8ad47821be3fa924c74c4c8b0d" class="external-link" target="_blank" rel="nofollow noopener">7f5c975</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-3322" title="ko2iblnd support for different map_on_demand and peer_credits between systems" class="issue-link" data-issue-key="LU-3322"><del>LU-3322</del></a> ko2iblnd: Support different configs between systems</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=efe3842c76b8041a048457779554ffa5ba76567d" class="external-link" target="_blank" rel="nofollow noopener">efe3842</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-6584" title="OSS hit LBUG and crash" class="issue-link" data-issue-key="LU-6584"><del>LU-6584</del></a> osd: prevent int type overflow in osd_read_prep()</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=881b288d70318644098c335b92f07388e9e2d3a5" class="external-link" target="_blank" rel="nofollow noopener">881b288</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-7222" title="conf-sanity test_84: invalid llog tail at log id 0x4:10/0 offset 16384" class="issue-link" data-issue-key="LU-7222"><del>LU-7222</del></a> tests: add Mulitple MDTs to test_84</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=790ca7b3c47d27639390bd7a2b9693182d3f24d6" class="external-link" target="_blank" rel="nofollow noopener">790ca7b</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-3281" title="IO Fails - client stack overrun" class="issue-link" data-issue-key="LU-3281"><del>LU-3281</del></a> obdclass: remove structure holes to reduce memory</td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=846efa4d098d3becb74bad343ba6adb6abc8b394" class="external-link" target="_blank" rel="nofollow noopener">846efa4</a></td> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-7162" title="Kernel update for RHEL7.1 [3.10.0-229.14.1.el7]" class="issue-link" data-issue-key="LU-7162"><del>LU-7162</del></a> kernel: kernel update RHEL 7.1 <span class="error">&#91;3.10.0-229.14.1.el7&#93;</span></td> </tr> <tr> <td class='confluenceTd'><a href="http://git.whamcloud.com/?p=fs/lustre-release.git;a=commit;h=c250f40ef3222dbeb92d7914a0d9f38a3525d2fb" class="external-link" target="_blank" rel="nofollow noopener">c250f40</a></td> <td class='confluenceTd'>Revert "<a href="https://jira.whamcloud.com/browse/LU-5951" title="sanity test_39k: mtime is lost on close" class="issue-link" data-issue-key="LU-5951"><del>LU-5951</del></a> ptlrpc: track unreplied requests"</td> </tr> </tbody></table> </div> LU-7315

In osd_dirent_check_repair(), Pointer 'hlock' can be NULL and can be dereferenced

Bug Major Resolved Fixed nasf Dmitry Eremin kw Mon, 19 Oct 2015 14:21:40 +0000 Fri, 4 Dec 2015 18:18:42 +0000 Fri, 4 Dec 2015 18:18:42 +0000 Lustre 2.8.0 0 5 <p>It looks like this was added by <a href="http://review.whamcloud.com/16440" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16440</a> "<a href="https://jira.whamcloud.com/browse/LU-6895" title="sanity-lfsck test 4 hung: bad entry in directory: rec_len is smaller than minimal - inode=3925999616" class="issue-link" data-issue-key="LU-6895"><del>LU-6895</del></a> lfsck: not destroy directory when fix FID-in-dirent" when it landed.</p> <p>Fan Yong, could you please take a look.</p> <p>Inside the function osd_dirent_check_repair(), anytime before it "goto again", it will call as following:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">if</span> (jh == NULL) { brelse(bh); <span class="code-keyword">if</span> (hlock != NULL) ldiskfs_htree_unlock(hlock); <span class="code-keyword">else</span> up_read(&amp;obj-&gt;oo_ext_idx_sem); dev-&gt;od_dirent_journal = 1; <span class="code-keyword">goto</span> again; } </pre> </div></div> <p>Means the "hlock" or "oo_ext_idx_sem" will be unlock/up before "goto again". Then the logic goes to the label "again":</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">if</span> (dev-&gt;od_dirent_journal != 0) { again: jh = osd_journal_start_sb(sb, LDISKFS_HT_MISC, credits); <span class="code-keyword">if</span> (IS_ERR(jh)) { rc = PTR_ERR(jh); CDEBUG(D_LFSCK, <span class="code-quote">"%.16s: fail to start trans <span class="code-keyword">for</span> dirent "</span> <span class="code-quote">"check_repair, dir = %lu/%u, credits = %d, "</span> <span class="code-quote">"name = %.*s: rc = %d\n"</span>, devname, dir-&gt;i_ino, dir-&gt;i_generation, credits, ent-&gt;oied_namelen, ent-&gt;oied_name, rc); GOTO(out_inode, rc); } <span class="code-keyword">if</span> (obj-&gt;oo_hl_head != NULL) { hlock = osd_oti_get(env)-&gt;oti_hlock; /* <span class="code-quote">"0"</span> means exclusive lock <span class="code-keyword">for</span> the whole directory. * We need to prevent others access such name entry * during the delete + insert. Neither HLOCK_ADD nor * HLOCK_DEL cannot guarantee the atomicity. */ ldiskfs_htree_lock(hlock, obj-&gt;oo_hl_head, dir, 0); } <span class="code-keyword">else</span> { down_write(&amp;obj-&gt;oo_ext_idx_sem); } } <span class="code-keyword">else</span> { ... out_inode: iput(inode); <span class="code-keyword">if</span> (rc &gt;= 0 &amp;&amp; !dirty) dev-&gt;od_dirent_journal = 0; <span class="code-keyword">return</span> rc; </pre> </div></div> <p>As you can see, it will try to start journal firstly, if it failed, then "GOTO(out_inode, rc);", at the label "out_inode", it will not handle "hlock" or "oo_ext_idx_sem", because either "hlock" or "oo_ext_idx_sem" has been unlocked/up, or it has not been lock/down (for the first time).</p> <p>If journal has been started successfully, then it will try to lock/down the "hlock" or "oo_ext_idx_sem". After that, all elements become valid. The "obj-&gt;oo_hl_head" cannot be changed once it has been set, so if "hlock" is not NULL before the "goto again", then it will still be non-NULL after the "goto again". So the whole logic is safe.</p> <p>Anyway, I know what you worry about, I will make patch to reset the "hlock" explicitly to the logic to be easy for the readers.</p> <p>Fan Yong (fan.yong@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/16924" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16924</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7315" title="In osd_dirent_check_repair(), Pointer &#39;hlock&#39; can be NULL and can be dereferenced" class="issue-link" data-issue-key="LU-7315"><del>LU-7315</del></a> osd-ldiskfs: reset lock variable after unlock<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: acbdb3581ee53b385838c3f69c0441553e9fad36</p> <p>The tool reports the different path of this issue.<br/> TRACEBACK:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>osd_handler.c:5404: 'hlock' is checked for NULL. osd_handler.c:5404: hlock!= ( (void* )0) is false osd_handler.c:5333: obj-&gt;oo_hl_head!= ( (void* )0) is false osd_handler.c:5353: 'hlock' is dereferenced by passing argument 4 to function '__ldiskfs_find_entry'. namei.c:1215: 'lck' is passed to function '__ldiskfs_find_entry'. namei.c:1236: 'lck' is dereferenced by passing argument 4 to function 'ldiskfs_dx_find_entry'. namei.c:1327: 'lck' is passed to function 'ldiskfs_dx_find_entry'. namei.c:1343: 'lck' is dereferenced by passing argument 5 to function 'dx_probe'. namei.c:594: 'lck' is passed to function 'dx_probe'. namei.c:618: hinfo-&gt;hash_version&lt;=2 is true namei.c:690: 0 is false namei.c:727: ldiskfs_htree_node_locked(lck, LDISKFS_LB_DX) is false namei.c:736: 'lck' is dereferenced by passing argument 1 to function 'dx_probe_hash_collision'. namei.c:566: 'lck' is passed to function 'dx_probe_hash_collision'. namei.c:570: 'lck' is explicitly dereferenced. </pre> </div></div> <p>Hm... That is a different story in the original PDO patch, not related with the recent landed patch <a href="http://review.whamcloud.com/16440" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16440</a>. I have updated the patch to fix that.</p> <p>Please help to analysis the new code with tools. Thanks!</p> <p>Now tool don't detect issue with lck.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/16924/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/16924/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7315" title="In osd_dirent_check_repair(), Pointer &#39;hlock&#39; can be NULL and can be dereferenced" class="issue-link" data-issue-key="LU-7315"><del>LU-7315</del></a> osd-ldiskfs: handle pdo lock properly<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 343364d0f06c34f403eb009de498455b5ebe14be</p> <p>Landed for 2.8</p> Related LU-6895 Development Rank 1|hzxqrz: Rank (Obsolete) 9223372036854775807 Severity