https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-7356 Lustre <p>While testing <a href="https://jira.whamcloud.com/browse/LU-5541" title="improve liblustreapi build" class="issue-link" data-issue-key="LU-5541"><del>LU-5541</del></a> patch it was discovered that if you use --disable-shared for configure for lustre that lustre snmp and the mount utility components for zfs and ldiskfs will not build. This is due to the Makefiles hardcoding the --shared option.</p> LU-7356

configure --disable-shared broken for server builds

Bug Minor Resolved Fixed Nathaniel Clark James A Simmons patch Thu, 29 Oct 2015 20:19:20 +0000 Sat, 5 Aug 2017 02:01:38 +0000 Sat, 5 Aug 2017 02:01:38 +0000 Lustre 2.8.0 Lustre 2.11.0 0 8 <p>Nathaniel</p> <p>Could you please advise?</p> <p>Thanks</p> <p>Peter</p> <p>Just to make people aware the patch from <a href="https://jira.whamcloud.com/browse/LU-5541" title="improve liblustreapi build" class="issue-link" data-issue-key="LU-5541"><del>LU-5541</del></a> does not cause the breakage.What is causing this breakage is in two spots. One is in snmp/Makefile.am:</p> <p>lustresnmp_la_CFLAGS := -fPIC $(NET_SNMP_CFLAGS)<br/> lustresnmp_la_LDFLAGS = -fPIC -shared -module -avoid-version</p> <p>Both -fPIC -shared are shared file options.</p> <p>Same problem exist in lustre/utils/Makefile.am:</p> <p>mount_osd_ldiskfs_la_LDFLAGS := -shared -export-dynamic -module -avoid-version<br/> ...<br/> mount_osd_zfs_la_LDFLAGS += -shared -export-dynamic -module -avoid-version</p> <p>Looking the the configuration the question is do we want to keep mount_osd_<span class="error">&#91;zfs|ldisk&#93;</span>fs.so as dynamic plugins when --disable-shared is enabled or make the *.so files merge into mount_lustre like a true static file.</p> <p>This will require changing how the build works for those plugins when disable-shared is used. It should be doable. It will also require a change in <tt>lustre/utils/mount_utils.c</tt> since we explicitly load the .so files. </p> <p>I wonder if ltdl library to make dlopen portal would be the solution for both static and dynamic loading for mount_utils.c?</p> <p>I'm not sure it would. ZFS doesn't ship with .a files so the mount_osd_zfs.so would have to be dynamically linked to libzfs unless zfs was built with different options than default.</p> <p>In that case the best option would be to create a temporary &#42;.a file and turn it into a <br/> &#42;.so. Much like what liblustreapi.* does. This avoids the libtool configure --disable-sharedinfluence.</p> <p>James, <br/> Do you mean change the ZFS build to create libzfs.a along with libzfs.so? I don't think there's a way to convert a .so to a .a. If you know of a way do to this, can you please share it with me? If you don't I don't see a way to resolve this issue.</p> <p>James,</p> <p>Looks like we are not going to be able to progress this any further. If you have any new ideas you would like us to investigate, please let us know.</p> <p>Thanks,<br/> ~ jfc.</p> <p>Please don't close this ticket. It is a real bug. What I like to recommend at this point is to do the reverse Nathaniel. We create a static library and if shared libraries are supported then convert it to a shared library. liblustreapi.so actually does this approach today.</p> <p>James,</p> <p><tt>libzfs.so</tt> is provided by the libzfs2-devel package from <a href="http://zfsonlinux.org" class="external-link" target="_blank" rel="nofollow noopener">ZFS on Linux</a>. A patch would need to be pushed upstream to have libzfs2-devel include static versions, then those would be need to used to build a statically linked version of <tt>mount_osd_zfs.so</tt>. But the end result would still be a .so file, just statically linked, because it's explicitly dlloaded by mount/mkfs/tunefs utils.</p> <p>Or am I still misunderstanding your view of this?</p> <p>~ Nathaniel</p> <p>The --disable-shared flags only matter if you use libtool to build the zfs mount module code. Currently it doesn't build due to the build system using lib tool. I will play with it once I get home.</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="http://review.whamcloud.com/17576" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17576</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7356" title="configure --disable-shared broken for server builds" class="issue-link" data-issue-key="LU-7356"><del>LU-7356</del></a> build: fix --disable-shared configure option<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 028df461ff16d0c83c8cb2edc6ee53b31b9f6085</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="http://review.whamcloud.com/17581" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17581</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7356" title="configure --disable-shared broken for server builds" class="issue-link" data-issue-key="LU-7356"><del>LU-7356</del></a> build: handle static/shared configure option for mount plugin<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: ffa58f79c3303ea02b24b799086f3181ec4c2e66</p> <p>Nathaniel I submitted two patches to handle this issue. The first patch makes the lustre SNMP and liblnetconfig to obey the configure --disable-shared --disable-static. That is straight forward and . The challenge is the mount plugins. The mount plugins are always built as dynamic using libtool but libtool always obeys the configure options. So if you do a configure --disable-shared this breaks the mount plugins build. The approach I took was to not use libtool with the mount plugins. First I build it as a static library then link it into a dynamic library type code. I broke the mount plugin changes out from the original patch since dlopen didn't like what I did so I'm doing something wrong but I feel it is a good starting point.</p> <p>They look good. I updated the second to account some debug code in <tt>mount_utils.c</tt>.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/17576/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17576/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7356" title="configure --disable-shared broken for server builds" class="issue-link" data-issue-key="LU-7356"><del>LU-7356</del></a> build: handle library configure options for SNMP/LNet<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 75f07b2fa054b69d1c20eef8dddb831af41fd7a5</p> <p>A patch is still needed to handle building the mount plugins when --disable-shared is set.</p> <p>Nathaniel did you ever make any progress on this?</p> <p>Looked at the patch with fresh eyes and I see the problem. I needed to link in libdl explicitly in the Makefile. Just tested it with --disabled-shared and normal configuration and it worked.</p> <p>I reviewed patch and restarted autotest as you requested.</p> <p>Thank you.</p> <p>Must we do this? Do we really care that --disable-shared doesn't work? I would prefer that we stick with the simple cleaner libtool method unless there is a really, really, good reason to need a static build.</p> <p>Yes due to Oleg making this a requirement for the <a href="https://jira.whamcloud.com/browse/LU-5541" title="improve liblustreapi build" class="issue-link" data-issue-key="LU-5541"><del>LU-5541</del></a> work. In Oleg's personal testing he uses the static versions of things. The ugliness is mainly due to liblustreapi not being built with libtool. That changes in the first <a href="https://jira.whamcloud.com/browse/LU-5541" title="improve liblustreapi build" class="issue-link" data-issue-key="LU-5541"><del>LU-5541</del></a> patch</p> <p>Ah, I see. Thanks for the explanation.</p> <p>Nathaniel I updated the patch. Easy work since it mostly was done. Now if you do a --disable-shared the mount plugins will be built into the utilities. This should make Oleg happy.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/17581/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/17581/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7356" title="configure --disable-shared broken for server builds" class="issue-link" data-issue-key="LU-7356"><del>LU-7356</del></a> build: handle configure options for mount plugin<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: d6f57eda898cc80a1cff49ad3875021749563dbf</p> Related LU-5541 Development End date Wed, 27 Jan 2016 20:19:20 +0000 Epic/Theme build Rank 1|hzxrtj: Rank (Obsolete) 9223372036854775807 Severity Start date Thu, 29 Oct 2015 20:19:20 +0000