https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-7371 Lustre <p>When running on osd-ldiskfs, if the isize is equal to 4095, a read length of 4096 will be returned because a wrong calculation of EOF.</p> LU-7371

Wrong read length over isize

Bug Critical Resolved Fixed Alex Zhuravlev Li Xi patch Mon, 2 Nov 2015 16:45:40 +0000 Thu, 3 Oct 2019 19:17:52 +0000 Wed, 2 Dec 2015 15:59:37 +0000 Lustre 2.8.0 Lustre 2.8.0 0 5 <p>Li Xi (lixi@ddn.com) uploaded a new patch: <a href="http://review.whamcloud.com/17020" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17020</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7371" title=" Wrong read length over isize" class="issue-link" data-issue-key="LU-7371"><del>LU-7371</del></a> osd-ldiskfs: fix wrong read length over isize<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 669fc00eb6ad6a6e9c94e3814326c50c65a7e3af</p> <p>Hi Alex,<br/> Can you take a look at this issue?<br/> Thanks.<br/> Joe</p> <p>I tried to write regression test. However, Lustre client has way to determine file size on client side. So, it seems hard to reproduce the issue on client side.</p> <p>I collected following messages when doing following things on Lustre without patch (all Lustre client and servers runs on the same machine):</p> <p>dd if=/dev/zero of=file bs=4095 count=1<br/> sync<br/> echo 3 &gt; /proc/sys/vm/drop_caches<br/> dd if=file of=/dev/null bs=1048576 </p> <p><span class="error">&#91;root@server1 lustre&#93;</span># grep tgt_brw_read /tmp/lustre.log | grep leaving<br/> 00000020:00000001:0.0:1446642073.288612:0:10887:0:(tgt_handler.c:1915:tgt_brw_read()) Process leaving (rc=4096 : 4096 : 1000)<br/> <span class="error">&#91;root@server1 lustre&#93;</span># grep 4095 /tmp/lustre.log <br/> 00020000:00000001:0.0:1446642073.282732:0:12771:0:(lov_offset.c:68:lov_stripe_size()) Process leaving (rc=4095 : 4095 : fff)<br/> 00020000:00000001:0.0:1446642073.282733:0:12771:0:(lov_offset.c:68:lov_stripe_size()) Process leaving (rc=4095 : 4095 : fff)<br/> 00000080:00000001:1.0:1446642073.288760:0:12771:0:(file.c:1302:ll_file_aio_read()) Process leaving (rc=4095 : 4095 : fff)<br/> 00000080:00000001:1.0:1446642073.288762:0:12771:0:(file.c:1332:ll_file_read()) Process leaving (rc=4095 : 4095 : fff)<br/> 00020000:00000001:1.0:1446642073.288856:0:12771:0:(lov_offset.c:68:lov_stripe_size()) Process leaving (rc=4095 : 4095 : fff)<br/> 00020000:00000001:1.0:1446642073.288857:0:12771:0:(lov_offset.c:68:lov_stripe_size()) Process leaving (rc=4095 : 4095 : fff)</p> <p>I had originally thought <tt>dd if=/dev/zero of=$DIR/$tfile bs=4095 count=1 conv=sync</tt> would be enough to create the file at 4095 bytes, and then the with <tt>bs=4096</tt> bytes would trigger the bug. If that doesn't work, then another option is to add an <tt>OBD_FAIL_OST_*</tt> check in the code to reproduce the original symptom.</p> <p>Li Xi (lixi@ddn.com) uploaded a new patch: <a href="http://review.whamcloud.com/17060" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17060</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7371" title=" Wrong read length over isize" class="issue-link" data-issue-key="LU-7371"><del>LU-7371</del></a> test: wrong read length over isize<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: bc9893da37ae60918b61e2d5fd84b4cb87ad3b82</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/17020/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17020/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7371" title=" Wrong read length over isize" class="issue-link" data-issue-key="LU-7371"><del>LU-7371</del></a> osd-ldiskfs: fix wrong read length over isize<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 97c4c162be77d2ee9bad5d800c9b5803f252caa0</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/17060/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17060/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7371" title=" Wrong read length over isize" class="issue-link" data-issue-key="LU-7371"><del>LU-7371</del></a> test: wrong read length over isize<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 7023698133970372031a16beac276e5e3e64cfbe</p> <p>Both patches have landed for 2.8.0</p> Related LU-12275 Development Rank 1|hzxs0v: Rank (Obsolete) 9223372036854775807 Severity