https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-7437 Lustre <p>When running "lctl list_param -R '*', it only shows /proc/{fs,sys}/{lustre,lnet}/ *, not recursively.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[root@centos6-1 utils]# ./lctl list_param -R '*' devices echo_client error: list_param: /proc/fs/lustre/echo_client/*: Found no match fld error: list_param: /proc/fs/lustre/fld/*: Found no match health_check jobid_name jobid_var ldlm error: list_param: /proc/fs/lustre/ldlm/*: Found no match llite error: list_param: /proc/fs/lustre/llite/*: Found no match lmv ... </pre> </div></div> <p>I will submit a patch later.</p> LU-7437

"lctl list_param -R" can't list the parameters recursively

Bug Critical Resolved Fixed Emoly Liu Emoly Liu Tue, 17 Nov 2015 06:06:48 +0000 Mon, 25 Apr 2016 13:06:20 +0000 Mon, 25 Apr 2016 12:44:06 +0000 Lustre 2.8.0 Lustre 2.8.0 0 8 <p>please, try with <a href="http://review.whamcloud.com/#/c/17135/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/17135/</a></p> <p>Alex, this issue happens to list_param. It's caused by calling lprocfs_param_pattern() inside listparam_display(), which adds prefix "/proc/{fs,sys}/{lustre,lnet}" each time, as follows</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>listparam_display (popt=0x7fffffffe350, pattern=0x7fffffffd2b0 "/proc/fs/lustre/echo_client/*") at lustre_cfg.c:823 823 if (rc &lt; 0) (gdb) n 822 rc = lprocfs_param_pattern(pattern, filename, sizeof(filename)); (gdb) n 823 if (rc &lt; 0) (gdb) p pattern $13 = 0x7fffffffd2b0 "/proc/fs/lustre/echo_client/*" (gdb) p filename $14 = "/proc/{fs,sys}/{lnet,lustre}//proc/fs/lustre/echo_client/*", '\000' &lt;repeats 526 times&gt;"\200, \356\230c1\000\000\000(\200\000\000\000\000\000\000\200\356\230c1\000\000\000&amp;\000\000\000\000\000\000\000\t\000\000\000\000\000\000\000\001\000\000\000\000\000\000\000\200\002", '\000' &lt;repeats 30 times&gt;, "&amp;\000\000\000\001\000\000\000\\\000\000\000|\000\000\000w\000\000\000n\000\000\000p\305\377\377\377\177\000\000\220\204e\000\000\000\000\000`\002\000\000\000\000\000\000\200\356\230c1\000\000\000P\211e\000\000\000\000\000\200\206e\000\000\000\000\000\360\001\000\000\000\000\000\000`\262gc1", '\000' &lt;repeats 11 times&gt;"\360"... (gdb) quit </pre> </div></div> <p>This issue will also happen to get_param if the patch <a href="http://review.whamcloud.com/#/c/17081/5/lustre/utils/lustre_cfg.c" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/17081/5/lustre/utils/lustre_cfg.c</a> is applied.</p> <p>thanks for trying.</p> <p>Emoly Liu (emoly.liu@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/17223" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17223</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7437" title="&quot;lctl list_param -R&quot; can&#39;t list the parameters recursively" class="issue-link" data-issue-key="LU-7437"><del>LU-7437</del></a> lctl: list_param -R can't work correctly<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: cfcf0f168c1c9b87e0f85c46ca44bf71c27f4b12</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/17223/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17223/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7437" title="&quot;lctl list_param -R&quot; can&#39;t list the parameters recursively" class="issue-link" data-issue-key="LU-7437"><del>LU-7437</del></a> lctl: list_param -R can't work correctly<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 2d1103558c8c26030df592589f3e8ebc299fbe48</p> <p>Landed for 2.8</p> <p>Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/18338" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/18338</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7437" title="&quot;lctl list_param -R&quot; can&#39;t list the parameters recursively" class="issue-link" data-issue-key="LU-7437"><del>LU-7437</del></a> utils: continue on errors in lctl {get,set}_param<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 38b6939a82949bc351db1098f4a0a26c3196a432</p> <p>Reopening this ticket because the patch <a href="http://review.whamcloud.com/17223/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17223/</a> broke handing of <tt>lctl set_param</tt> if there are errors during parameter processing. The command should continue to process all parameters given even if some parameters failed during processing. This was worsened by the reorganization in <a href="https://jira.whamcloud.com/browse/LU-5030" title="&quot;lctl {get,set}_param&quot; should also check in /sys/fs/{lnet,lustre}" class="issue-link" data-issue-key="LU-5030"><del>LU-5030</del></a> to use <tt>cfs_get_paths()</tt>.</p> <p>Yes I thought exiting on error for set_param was the normal behavior which I saw when running lctl set_param. </p> <p>Another instance found for Full tag 2.7.66 -EL7.1 Server/SLES11 SP3 Client, build# 3314<br/> <a href="https://testing.hpdd.intel.com/test_sets/6f89f660-ca7b-11e5-9609-5254006e85c2" class="external-link" target="_blank" rel="nofollow noopener">https://testing.hpdd.intel.com/test_sets/6f89f660-ca7b-11e5-9609-5254006e85c2</a></p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/18338/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/18338/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7437" title="&quot;lctl list_param -R&quot; can&#39;t list the parameters recursively" class="issue-link" data-issue-key="LU-7437"><del>LU-7437</del></a> utils: continue on errors in lctl </p> {get,set} <p>_param<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 22856f4e5e2a84be332b6c70f039c47f24cf7b44</p> <p>Landed for 2.8</p> <p>Emoly Liu (emoly.liu@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/19759" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/19759</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7437" title="&quot;lctl list_param -R&quot; can&#39;t list the parameters recursively" class="issue-link" data-issue-key="LU-7437"><del>LU-7437</del></a> lctl: fix a typo in lustre_cfg.c<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 56222d13f95bd9ce00d7d7a6fe7be579a4966520</p> <p>Emoly</p> <p>Given that the first fix was landed for 2.8, which is now GA, it would probably be better to open a new ticket to track this correction. I find that it causes confusion if multiple fixes that are tracked by the same JIRA reference span release boundaries.</p> <p>Peter</p> <p>OK, I will create a new ticket to submit this patch.</p> Related LU-5030 LU-7796 LU-7802 LU-8064 Development Rank 1|hzxt8n: Rank (Obsolete) 9223372036854775807 Severity