https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-7441 Lustre <p>nrs_tbf_*_startup should free hash table if futher process fails.</p> LU-7441

Memory leak in nrs_tbf_*_startup

Bug Major Resolved Fixed Emoly Liu Li Xi patch Tue, 17 Nov 2015 09:12:05 +0000 Fri, 7 Jul 2017 20:50:12 +0000 Fri, 7 Jul 2017 20:49:55 +0000 Lustre 2.8.0 Lustre 2.10.0 0 6 <p>Li Xi (lixi@ddn.com) uploaded a new patch: <a href="http://review.whamcloud.com/17224" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17224</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7441" title="Memory leak in nrs_tbf_*_startup" class="issue-link" data-issue-key="LU-7441"><del>LU-7441</del></a> nrs: fix memory leak in nrs_tbf_*_startup<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: f1b173201d137a8acd924084d03a76d2bdcab0a1</p> <p>Emoly</p> <p>Could you please take care of this patch?</p> <p>Thanks</p> <p>Peter</p> <p>This problem is easy to produce:</p> <p>With following patch:</p> <p>memset(&amp;start, 0, sizeof(start));<br/> start.tc_jobids_str = "*";</p> <p> start.tc_rpc_rate = tbf_rate;<br/> start.tc_rule_flags = NTRS_DEFAULT;<br/> start.tc_name = NRS_TBF_DEFAULT_RULE;<br/> INIT_LIST_HEAD(&amp;start.tc_jobids);<br/> //rc = nrs_tbf_rule_start(policy, head, &amp;start);<br/> rc = -EINVAL;<br/> return rc;</p> <p><span class="error">&#91;root@QYJ tests&#93;</span># lctl set_param ost.OSS.ost_io.nrs_policies="tbf jobid"<br/> ost.OSS.ost_io.nrs_policies=tbf jobid<br/> error: set_param: setting /proc/fs/lustre/ost/OSS/ost_io/nrs_policies=tbf jobid: Invalid argument<br/> <span class="error">&#91;root@QYJ tests&#93;</span># sh llmountcleanup.sh <br/> Stopping clients: QYJ /mnt/lustre (opts:-f)<br/> Stopping client QYJ /mnt/lustre opts:-f<br/> Stopping clients: QYJ /mnt/lustre2 (opts:-f)<br/> Stopping /mnt/mds1 (opts:-f) on QYJ<br/> Stopping /mnt/ost1 (opts:-f) on QYJ<br/> Stopping /mnt/ost2 (opts:-f) on QYJ</p> <p>LNetError: 19587:0:(module.c:412:exit_libcfs_module()) Portals memory leaked: 131600 bytes<br/> Memory leaks detected</p> <p>Lixi, thanks for your reproducer!</p> <p>As we discussed, this problem exists in all NRS policies code, not only TBF, so I think it's related to NRS state setting. Your patch does work, but we need to know the root cause and then fix it.</p> <p>I don't think it is NRS state setting problem. If all funcitons of op_policy_start() always free all memory they allocats when failure happends, no memory will be leaked. And I checked all nrs_*_start functions. I didn't find any problem.</p> <p>Emoly Liu (emoly.liu@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/25319" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/25319</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7441" title="Memory leak in nrs_tbf_*_startup" class="issue-link" data-issue-key="LU-7441"><del>LU-7441</del></a> nrs: some code cleanup in NRS policies<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 740df75fe6952bada2b505a7bd751aff09a07e94</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/17224/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/17224/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7441" title="Memory leak in nrs_tbf_*_startup" class="issue-link" data-issue-key="LU-7441"><del>LU-7441</del></a> nrs: Free hash table if failed to start a nrs policy<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: cd362fa9186a3e4de34c7c68908e6d3d429bb087</p> <p>Issue here is resolved and landed for 2.10.0. The code cleanup patch is moved to a separate ticket: <a href="https://jira.whamcloud.com/browse/LU-9750" title="misc code cleanups in nrs policy code" class="issue-link" data-issue-key="LU-9750"><del>LU-9750</del></a>.</p> Related LU-9750 Development End date Fri, 20 Nov 2015 09:12:05 +0000 Rank 1|hzxt9r: Rank (Obsolete) 9223372036854775807 Severity Start date Tue, 17 Nov 2015 09:12:05 +0000