Whamcloud Community JIRA

Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us

9.4.14

940014

05-12-2023

[LU-761] Return values of ll_prep_md_op_data() should be checked using IS_ERR(). https://jira.whamcloud.com/browse/LU-761 Lustre <p>Several places test to see if ll_prep_md_op_data() returned NULL. Others assume all errors are due to out of memory. Still other's dont check it at all when they should.</p> LU-761

Return values of ll_prep_md_op_data() should be checked using IS_ERR().

Bug Minor Resolved Fixed Andreas Dilger John Hammond Thu, 13 Oct 2011 18:17:46 +0000 Mon, 12 Dec 2011 20:09:54 +0000 Mon, 12 Dec 2011 17:31:01 +0000 Lustre 2.1.0 Lustre 2.2.0 0 0 <p><a href="http://review.whamcloud.com/1520" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/1520</a></p> <p>Landed for 2.2</p> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=sles11,ib_stack=inkernel/378/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,sles11,inkernel #378</a><br/> <a href="https://jira.whamcloud.com/browse/LU-761" title="Return values of ll_prep_md_op_data() should be checked using IS_ERR()." class="issue-link" data-issue-key="LU-761"><del>LU-761</del></a>: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=bd495258d54ea5ab5be7aee4ea23fae558e2f8c4" class="external-link" target="_blank" rel="nofollow noopener">bd495258d54ea5ab5be7aee4ea23fae558e2f8c4</a><br/> Files : </p> <ul> <li>lustre/llite/symlink.c</li> <li>lustre/llite/llite_lib.c</li> <li>lustre/llite/file.c</li> <li>lustre/llite/dir.c</li> <li>lustre/llite/llite_nfs.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el6,ib_stack=inkernel/378/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el6,inkernel #378</a><br/> <a href="https://jira.whamcloud.com/browse/LU-761" title="Return values of ll_prep_md_op_data() should be checked using IS_ERR()." class="issue-link" data-issue-key="LU-761"><del>LU-761</del></a>: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=bd495258d54ea5ab5be7aee4ea23fae558e2f8c4" class="external-link" target="_blank" rel="nofollow noopener">bd495258d54ea5ab5be7aee4ea23fae558e2f8c4</a><br/> Files : </p> <ul> <li>lustre/llite/dir.c</li> <li>lustre/llite/llite_nfs.c</li> <li>lustre/llite/file.c</li> <li>lustre/llite/symlink.c</li> <li>lustre/llite/llite_lib.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el6,ib_stack=inkernel/378/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el6,inkernel #378</a><br/> <a href="https://jira.whamcloud.com/browse/LU-761" title="Return values of ll_prep_md_op_data() should be checked using IS_ERR()." class="issue-link" data-issue-key="LU-761"><del>LU-761</del></a>: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=bd495258d54ea5ab5be7aee4ea23fae558e2f8c4" class="external-link" target="_blank" rel="nofollow noopener">bd495258d54ea5ab5be7aee4ea23fae558e2f8c4</a><br/> Files : </p> <ul> <li>lustre/llite/symlink.c</li> <li>lustre/llite/llite_nfs.c</li> <li>lustre/llite/llite_lib.c</li> <li>lustre/llite/dir.c</li> <li>lustre/llite/file.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el5,ib_stack=ofa/378/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el5,ofa #378</a><br/> <a href="https://jira.whamcloud.com/browse/LU-761" title="Return values of ll_prep_md_op_data() should be checked using IS_ERR()." class="issue-link" data-issue-key="LU-761"><del>LU-761</del></a>: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=bd495258d54ea5ab5be7aee4ea23fae558e2f8c4" class="external-link" target="_blank" rel="nofollow noopener">bd495258d54ea5ab5be7aee4ea23fae558e2f8c4</a><br/> Files : </p> <ul> <li>lustre/llite/llite_nfs.c</li> <li>lustre/llite/symlink.c</li> <li>lustre/llite/llite_lib.c</li> <li>lustre/llite/dir.c</li> <li>lustre/llite/file.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el6,ib_stack=inkernel/378/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el6,inkernel #378</a><br/> <a href="https://jira.whamcloud.com/browse/LU-761" title="Return values of ll_prep_md_op_data() should be checked using IS_ERR()." class="issue-link" data-issue-key="LU-761"><del>LU-761</del></a>: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=bd495258d54ea5ab5be7aee4ea23fae558e2f8c4" class="external-link" target="_blank" rel="nofollow noopener">bd495258d54ea5ab5be7aee4ea23fae558e2f8c4</a><br/> Files : </p> <ul> <li>lustre/llite/llite_nfs.c</li> <li>lustre/llite/symlink.c</li> <li>lustre/llite/llite_lib.c</li> <li>lustre/llite/file.c</li> <li>lustre/llite/dir.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=el5,ib_stack=inkernel/378/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,el5,inkernel #378</a><br/> <a href="https://jira.whamcloud.com/browse/LU-761" title="Return values of ll_prep_md_op_data() should be checked using IS_ERR()." class="issue-link" data-issue-key="LU-761"><del>LU-761</del></a>: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=bd495258d54ea5ab5be7aee4ea23fae558e2f8c4" class="external-link" target="_blank" rel="nofollow noopener">bd495258d54ea5ab5be7aee4ea23fae558e2f8c4</a><br/> Files : </p> <ul> <li>lustre/llite/dir.c</li> <li>lustre/llite/file.c</li> <li>lustre/llite/llite_lib.c</li> <li>lustre/llite/llite_nfs.c</li> <li>lustre/llite/symlink.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=client,distro=ubuntu1004,ib_stack=inkernel/378/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,client,ubuntu1004,inkernel #378</a><br/> <a href="https://jira.whamcloud.com/browse/LU-761" title="Return values of ll_prep_md_op_data() should be checked using IS_ERR()." class="issue-link" data-issue-key="LU-761"><del>LU-761</del></a>: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=bd495258d54ea5ab5be7aee4ea23fae558e2f8c4" class="external-link" target="_blank" rel="nofollow noopener">bd495258d54ea5ab5be7aee4ea23fae558e2f8c4</a><br/> Files : </p> <ul> <li>lustre/llite/symlink.c</li> <li>lustre/llite/llite_lib.c</li> <li>lustre/llite/llite_nfs.c</li> <li>lustre/llite/file.c</li> <li>lustre/llite/dir.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el5,ib_stack=inkernel/378/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el5,inkernel #378</a><br/> <a href="https://jira.whamcloud.com/browse/LU-761" title="Return values of ll_prep_md_op_data() should be checked using IS_ERR()." class="issue-link" data-issue-key="LU-761"><del>LU-761</del></a>: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=bd495258d54ea5ab5be7aee4ea23fae558e2f8c4" class="external-link" target="_blank" rel="nofollow noopener">bd495258d54ea5ab5be7aee4ea23fae558e2f8c4</a><br/> Files : </p> <ul> <li>lustre/llite/symlink.c</li> <li>lustre/llite/llite_lib.c</li> <li>lustre/llite/file.c</li> <li>lustre/llite/llite_nfs.c</li> <li>lustre/llite/dir.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el5,ib_stack=ofa/378/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el5,ofa #378</a><br/> <a href="https://jira.whamcloud.com/browse/LU-761" title="Return values of ll_prep_md_op_data() should be checked using IS_ERR()." class="issue-link" data-issue-key="LU-761"><del>LU-761</del></a>: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=bd495258d54ea5ab5be7aee4ea23fae558e2f8c4" class="external-link" target="_blank" rel="nofollow noopener">bd495258d54ea5ab5be7aee4ea23fae558e2f8c4</a><br/> Files : </p> <ul> <li>lustre/llite/symlink.c</li> <li>lustre/llite/llite_lib.c</li> <li>lustre/llite/file.c</li> <li>lustre/llite/llite_nfs.c</li> <li>lustre/llite/dir.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=client,distro=el5,ib_stack=inkernel/378/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,client,el5,inkernel #378</a><br/> <a href="https://jira.whamcloud.com/browse/LU-761" title="Return values of ll_prep_md_op_data() should be checked using IS_ERR()." class="issue-link" data-issue-key="LU-761"><del>LU-761</del></a>: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=bd495258d54ea5ab5be7aee4ea23fae558e2f8c4" class="external-link" target="_blank" rel="nofollow noopener">bd495258d54ea5ab5be7aee4ea23fae558e2f8c4</a><br/> Files : </p> <ul> <li>lustre/llite/symlink.c</li> <li>lustre/llite/llite_nfs.c</li> <li>lustre/llite/llite_lib.c</li> <li>lustre/llite/dir.c</li> <li>lustre/llite/file.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/red.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,build_type=server,distro=el5,ib_stack=ofa/378/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,server,el5,ofa #378</a><br/> <a href="https://jira.whamcloud.com/browse/LU-761" title="Return values of ll_prep_md_op_data() should be checked using IS_ERR()." class="issue-link" data-issue-key="LU-761"><del>LU-761</del></a>: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)</p> <p> Result = FAILURE<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=bd495258d54ea5ab5be7aee4ea23fae558e2f8c4" class="external-link" target="_blank" rel="nofollow noopener">bd495258d54ea5ab5be7aee4ea23fae558e2f8c4</a><br/> Files : </p> <ul> <li>lustre/llite/file.c</li> <li>lustre/llite/symlink.c</li> <li>lustre/llite/llite_nfs.c</li> <li>lustre/llite/llite_lib.c</li> <li>lustre/llite/dir.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el5,ib_stack=inkernel/378/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el5,inkernel #378</a><br/> <a href="https://jira.whamcloud.com/browse/LU-761" title="Return values of ll_prep_md_op_data() should be checked using IS_ERR()." class="issue-link" data-issue-key="LU-761"><del>LU-761</del></a>: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=bd495258d54ea5ab5be7aee4ea23fae558e2f8c4" class="external-link" target="_blank" rel="nofollow noopener">bd495258d54ea5ab5be7aee4ea23fae558e2f8c4</a><br/> Files : </p> <ul> <li>lustre/llite/llite_lib.c</li> <li>lustre/llite/dir.c</li> <li>lustre/llite/file.c</li> <li>lustre/llite/symlink.c</li> <li>lustre/llite/llite_nfs.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el6,ib_stack=inkernel/378/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el6,inkernel #378</a><br/> <a href="https://jira.whamcloud.com/browse/LU-761" title="Return values of ll_prep_md_op_data() should be checked using IS_ERR()." class="issue-link" data-issue-key="LU-761"><del>LU-761</del></a>: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=bd495258d54ea5ab5be7aee4ea23fae558e2f8c4" class="external-link" target="_blank" rel="nofollow noopener">bd495258d54ea5ab5be7aee4ea23fae558e2f8c4</a><br/> Files : </p> <ul> <li>lustre/llite/llite_lib.c</li> <li>lustre/llite/llite_nfs.c</li> <li>lustre/llite/dir.c</li> <li>lustre/llite/symlink.c</li> <li>lustre/llite/file.c</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=i686,build_type=server,distro=el5,ib_stack=ofa/378/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » i686,server,el5,ofa #378</a><br/> <a href="https://jira.whamcloud.com/browse/LU-761" title="Return values of ll_prep_md_op_data() should be checked using IS_ERR()." class="issue-link" data-issue-key="LU-761"><del>LU-761</del></a>: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)</p> <p> Result = SUCCESS<br/> Oleg Drokin : <a href="http://git.whamcloud.com/gitweb?p=fs/lustre-release.git;a=shortlog;h=refs/heads/master&a=commit&h=bd495258d54ea5ab5be7aee4ea23fae558e2f8c4" class="external-link" target="_blank" rel="nofollow noopener">bd495258d54ea5ab5be7aee4ea23fae558e2f8c4</a><br/> Files : </p> <ul> <li>lustre/llite/symlink.c</li> <li>lustre/llite/llite_lib.c</li> <li>lustre/llite/llite_nfs.c</li> <li>lustre/llite/file.c</li> <li>lustre/llite/dir.c</li> </ul> Development Rank 1|hzv7w7: Rank (Obsolete) 4813 Severity