https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-7623 Lustre <p>Currently there's a significant mess in Lustre code in regards to kernel/user pointers.<br/> Structures are not separated and could be used from both which is bad for multiple reasons.<br/> This also makes it hard for various static tools to properly enforce access rules.</p> <p>Things like IOC_LIBCFS_DEBUG_PEER "ioctl" should be cleaned out and the __user modifiers added all around in the structures to make everything work nice and well.</p> LU-7623

Clean up lustre user/kernel pointer types.

Bug Major Resolved Fixed Oleg Drokin Oleg Drokin Sat, 2 Jan 2016 13:06:02 +0000 Tue, 13 Dec 2016 15:45:34 +0000 Thu, 11 Feb 2016 20:17:34 +0000 Lustre 2.8.0 Lustre 2.9.0 0 5 <p>Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/17778" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17778</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> lnet: Get rid of IOC_LIBCFS_DEBUG_PEER hack<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 12be094e57b485c684a23455fba984b1abed87ee</p> <p>Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/17788" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17788</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> Add __user to seq_write buffer arguments<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 8d599c1f58a98ca4fe2316829745f539c6ff96a6</p> <p>Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/17789" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17789</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> mdt: Match up prototype and definition of mdt_hsm_cdt_control_seq_write<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 05d391314499a38d558782964d8bd4c429a994b6</p> <p>Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/17790" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17790</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> gss: Update upcall structure with user attributes<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: e4363a5c80b280e161d482d08beb8d614754aad7</p> <p>Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/17779" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17779</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> lnet: Get rid of IOC_LIBCFS_PORTALS_COMPATIBILITY ioctl<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 82e735fd82916802c4438a34806799a6d9ffc992</p> <p>Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/17780" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17780</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> lov: Get rid of an ugly statfs hack in lov_iocontrol<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 166b551b8ab4e8f8b5575bde28e3c2ead6d68d5a</p> <p>Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/17781" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17781</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> Update obd iocontrol methods with __user attribute<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: eb910fba9f7aaa047f5ed1e34d6cda69c7653935</p> <p>Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/17782" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17782</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> lmv: Properly mark lmv_fid2path uarg argment as __user<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 8ddfdef6105caaf47ac9001d7f360581a386470c</p> <p>Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/17783" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17783</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> lmv: Mark lmv_hsm_ct_register/unregister uarg as __user<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 452dc42c7ce3976e8752bcdd2c078c55a4d6ecaa</p> <p>Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/17784" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17784</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> lnet: Properly declare lnet_ping() forward declaration<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 3588a998f5ee2f1d448df75cbece1b70da318d73</p> <p>Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/17785" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17785</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> lnet: Remove __user attribute from lnet_copy_flat2* functions<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: e39d05d9c2c4dcdabdc8543baa58ef9ff34d89a7</p> <p>Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/17787" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17787</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> libcfs: Properly map page for vfs_write<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 22e20be216a29b85557ab28dea1031c806374021</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/17790/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17790/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> gss: Update upcall structure with user attributes<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 305bd3d8c82c4ecf67a8d53f43ae69e9cb5568e7</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/17785/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17785/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> lnet: Remove __user attribute from lnet_copy_flat2* functions<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 4594c003e9aa63bde006908e34834a8c134b305c</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/17787/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17787/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> libcfs: Properly map page for vfs_write<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e2a442e3288afec9450a9aef188fe38dce35aab0</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/17788/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17788/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> Add __user to seq_write buffer arguments<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 6fc8da41f2ff5156639e89f379adcdbb73ac8567</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/17778/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17778/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> lnet: Get rid of IOC_LIBCFS_DEBUG_PEER hack<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 39160ccc60eb88c4a665d5d129abceacd2860de2</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/17779/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17779/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> lnet: Get rid of IOC_LIBCFS_PORTALS_COMPATIBILITY ioctl<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 9bafa64985cae09eee5adaba5725038df1bf12e3</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/17780/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17780/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> lov: Get rid of an ugly statfs hack in lov_iocontrol<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 9281658095a63c88a12246df5fb6f3b78f97095a</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/17781/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17781/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> Update obd iocontrol methods with __user attribute<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 9175d6f862039cfbf6b85333d72a9d91e64ea42a</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/17782/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17782/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> lmv: Properly mark lmv_fid2path uarg argment as __user<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: bdd1272607a95482d6b5261de7fe8bec1d57e2a8</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/17783/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17783/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> lmv: Mark lmv_hsm_ct_register/unregister uarg as __user<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 3b2dad4ebb4ac81cebeab6c7e0c4ecb67f1de7ea</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/17784/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17784/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> lnet: Properly declare lnet_ping() forward declaration<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 115011c524e8674de010ddd2dea4afb497c1884e</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/17789/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/17789/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> mdt: Match up prototype and definition of mdt_hsm_cdt_control_seq_write<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: f5f3725d43b30ea9af3928ebb5bfd6fdc2c5c964</p> <p>All patches have landed.</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="http://review.whamcloud.com/18950" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/18950</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> lnet: remove useless cast<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: d6a8c4abea6f0c7e5e9d2cb6547cb92319f0e282</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/18950/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/18950/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7623" title="Clean up lustre user/kernel pointer types." class="issue-link" data-issue-key="LU-7623"><del>LU-7623</del></a> lnet: remove useless cast<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: ba162203853721dd2ad16bcc2212b11461974264</p> Related LU-6215 LU-7624 Development Rank 1|hzxx3j: Rank (Obsolete) 9223372036854775807 Severity