https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-7700 Lustre <p>Lets say you have a clean checkout of Lustre's master branch, and you do the following:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>$ sh autogen.sh $ ./configure $ &lt;edit lustre/autoconf/lustre-version.ac and increment the LUSTRE_PATCH number&gt; $ make cd . &amp;&amp; /bin/sh /home/morrone/src/lustre/config/missing automake-1.13 --foreign autoMakefile.am:122: error: SERVER does not appear in AM_CONDITIONAL make: *** [autoMakefile.in] Error 1 </pre> </div></div> <p>One way or another, the autotools are smart enough to recognize that the configure script needs to be regenerated. However, we are currently hitting the above bug.</p> <p>AM_CONDITIONAL calls all must be made unconditionally. My guess, without looking at the code, is that SERVER is defined from an AM_CONDITIONAL that is burried under conditional calls, and that is triggeing the about error.</p> <p>NOTE: My first guess was wrong, read the comments below for more details.</p> LU-7700

autoreconf does not work

Bug Minor Open Unresolved Christopher Morrone Christopher Morrone patch Fri, 22 Jan 2016 21:32:33 +0000 Wed, 21 Mar 2018 16:39:08 +0000 0 3 <p>I think my guess was incorrect.</p> <p>It looks like autotools are trying to refresh the files using autoreconf. If I run autoreconf with verbosity enabled I see:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>$ autoreconf --verbose autoreconf: Entering directory `.' autoreconf: configure.ac: not using Gettext autoreconf: running: aclocal autoreconf: configure.ac: tracing autoreconf: configure.ac: not running libtoolize: --install not given autoreconf: running: /usr/bin/autoconf autoreconf: running: /usr/bin/autoheader autoreconf: running: automake --no-force autoMakefile.am:122: error: SERVER does not appear in AM_CONDITIONAL autoreconf: automake failed with exit status: 1 </pre> </div></div> <p>So now I suspect this is an issue left over from the days when we had multiple CVS repositories kludged together into one Frankenstein build. The problem is that we are hiding some linkage in the autogen.sh, and not expressing it in a way that the autotools will remember.</p> <p>In particular, in autogen.sh we add multiple include paths on aclocal's command line in autogen.sh ("aclocal -I $pw/config $ACLOCAL_FLAGS") but those don't seem to be known by autoconf later on. I can get exactly the same error if I run the autogen.sh commands leaving out only the includes:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>$ libtoolize -q $ aclocal $ autoheader $ automake -a -c configure.ac:12: installing 'config/config.guess' configure.ac:12: installing 'config/config.sub' configure.ac:14: installing 'config/install-sh' configure.ac:14: installing 'config/missing' autoMakefile.am:122: error: SERVER does not appear in AM_CONDITIONAL </pre> </div></div> <p>So I think the we need to figure out if/how we can express those includes to the autotools more correctly.</p> <p>I think my guess was incorrect.</p> <p>It looks like autotools are trying to refresh the files using autoreconf. If I run autoreconf with verbosity enabled I see:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>$ autoreconf --verbose autoreconf: Entering directory `.' autoreconf: configure.ac: not using Gettext autoreconf: running: aclocal autoreconf: configure.ac: tracing autoreconf: configure.ac: not running libtoolize: --install not given autoreconf: running: /usr/bin/autoconf autoreconf: running: /usr/bin/autoheader autoreconf: running: automake --no-force autoMakefile.am:122: error: SERVER does not appear in AM_CONDITIONAL autoreconf: automake failed with exit status: 1 </pre> </div></div> <p>So now I suspect this is an issue left over from the days when we had multiple CVS repositories kludged together into one Frankenstein build. The problem is that we are hiding some linkage in the autogen.sh, and not expressing it in a way that the autotools will remember.</p> <p>In particular, in autogen.sh we add multiple include paths on aclocal's command line in autogen.sh ("aclocal -I $pw/config $ACLOCAL_FLAGS") but those don't seem to be known by autoconf later on. I can get exactly the same error if I run the autogen.sh commands leaving out only the includes:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>$ libtoolize -q $ aclocal $ autoheader $ automake -a -c configure.ac:12: installing 'config/config.guess' configure.ac:12: installing 'config/config.sub' configure.ac:14: installing 'config/install-sh' configure.ac:14: installing 'config/missing' autoMakefile.am:122: error: SERVER does not appear in AM_CONDITIONAL </pre> </div></div> <p>So I think the we need to figure out if/how we can express those includes to the autotools more correctly.</p> <p>Christopher J. Morrone (morrone2@llnl.gov) uploaded a new patch: <a href="http://review.whamcloud.com/18099" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/18099</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7700" title="autoreconf does not work" class="issue-link" data-issue-key="LU-7700">LU-7700</a> build: Fix autoreconf by using AC_CONFIG_MACRO_DIRS<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 22edb82ebf71099cc73764a91f967d2f997e23db</p> <p>I think I figured out the solution, but it might only work with automake 1.13 and newer. We should be using AC_CONFIG_MACRO_DIRS.</p> Related LU-3953 Development End date Mon, 11 Apr 2016 21:32:33 +0000 Rank 1|hzxz6n: Rank (Obsolete) 9223372036854775807 Severity Start date Fri, 22 Jan 2016 21:32:33 +0000