Whamcloud Community JIRA

Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us

9.4.14

940014

05-12-2023

[LU-7715] out_handle() misuses GOTO() https://jira.whamcloud.com/browse/LU-7715 Lustre <p>In <tt>out_handle()</tt> we have two <tt>GOTO(out_free, err_serious(rc))</tt> that should be <tt>GOTO(out_free, rc = err_serious(rc))</tt>. If followed these will cause an LBUG since the reply has not been packed yet.</p> LU-7715

out_handle() misuses GOTO()

Bug Blocker Resolved Fixed Di Wang John Hammond Tue, 26 Jan 2016 21:10:49 +0000 Thu, 4 Feb 2016 05:25:29 +0000 Thu, 4 Feb 2016 05:25:29 +0000 Lustre 2.8.0 0 4 <p>Hi Di,</p> <p>Can you have a look to see if this is related to the <a href="https://jira.whamcloud.com/browse/LU-7039" title="llog_osd.c:778:llog_osd_next_block()) ASSERTION( last_rec->lrh_index == tail->lrt_index ) failed:" class="issue-link" data-issue-key="LU-7039"><del>LU-7039</del></a> landing? Discussion at triage today seemed to lead down that path.</p> <p>Thanks.<br/> Joe</p> <p>Hmm, according to the comments in tgt_handle_request0(), all of requests handler should return serious error if the reply is not packed yet. so out_handle() should all return err_serious() before req_capsule_server_pack(). I do not think this is related with the landing of <a href="https://jira.whamcloud.com/browse/LU-7039" title="llog_osd.c:778:llog_osd_next_block()) ASSERTION( last_rec->lrh_index == tail->lrt_index ) failed:" class="issue-link" data-issue-key="LU-7039"><del>LU-7039</del></a>.</p> <p>> I do not think this is related with the landing of <a href="https://jira.whamcloud.com/browse/LU-7039" title="llog_osd.c:778:llog_osd_next_block()) ASSERTION( last_rec->lrh_index == tail->lrt_index ) failed:" class="issue-link" data-issue-key="LU-7039"><del>LU-7039</del></a>.</p> <p><a href="http://review.whamcloud.com/#/c/16969/34/lustre/target/out_handler.c" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/16969/34/lustre/target/out_handler.c</a></p> <p>do you mean this? So if it return with non-serious error, and did not pack reply, then it will panic. </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> /* * Process request, there can be two types of rc: * 1) errors with msg unpack/pack, other failures outside the * operation itself. This is counted as serious errors; * 2) errors during fs operation, should be placed in rq_status * only */ rc = h->th_act(tsi); if (!is_serious(rc) && !req->rq_no_reply && req->rq_reply_state == NULL) { DEBUG_REQ(D_ERROR, req, "%s \"handler\" %s did not " "pack reply and returned 0 error\n", tgt_name(tsi->tsi_tgt), h->th_name); LBUG(); } </pre> </div></div> <p>So the patch for <a href="https://jira.whamcloud.com/browse/LU-7039" title="llog_osd.c:778:llog_osd_next_block()) ASSERTION( last_rec->lrh_index == tail->lrt_index ) failed:" class="issue-link" data-issue-key="LU-7039"><del>LU-7039</del></a> turns a few normal error to serious error, though it did not convert all of them. Why this is related with the fix of <a href="https://jira.whamcloud.com/browse/LU-7039" title="llog_osd.c:778:llog_osd_next_block()) ASSERTION( last_rec->lrh_index == tail->lrt_index ) failed:" class="issue-link" data-issue-key="LU-7039"><del>LU-7039</del></a>? or I miss sth?</p> <p>ah, sorry, I missed the comments. </p> <p>wangdi (di.wang@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/18187" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/18187</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7715" title="out_handle() misuses GOTO()" class="issue-link" data-issue-key="LU-7715"><del>LU-7715</del></a> out: fix err_serious in out_handle<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 3c11d3024df04989c7499004560a8358cdce1e11</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/18187/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/18187/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7715" title="out_handle() misuses GOTO()" class="issue-link" data-issue-key="LU-7715"><del>LU-7715</del></a> out: fix err_serious in out_handle<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 7ab18ff6ffef4f5267e3893210a5fbc6cb46efb0</p> <p>Landed for 2.8</p> Related LU-7039 Development Rank 1|hzxzfz: Rank (Obsolete) 9223372036854775807 Severity