[LU-7874] Suspect locking cleanup issue in mdt_create()

Sun, 14 Jan 2018 03:13:02 +0000

In mdt_create():

                        if (!mdt_object_remote(parent)) {
                                mdt_object_unlock(info, parent, lh, 1);
                                mdt_lock_pdo_init(lh, LCK_PW, &rr->rr_name);
                                rc = mdt_reint_object_lock(info, parent, lh,
                                                           MDS_INODELOCK_UPDATE,
                                                           true);
                                if (rc)
                                        GOTO(put_child, rc);
                        }
...
put_child:
        mdt_object_put(info->mti_env, child);
unlock_parent:
        mdt_object_unlock(info, parent, lh, rc);
put_parent:
        mdt_object_put(info->mti_env, parent);
        RETURN(rc);

So if we cannot lock parent we jump to put child and then unlock parent? that sounds wrong.

Whamcloud Community JIRA

[LU-7874] Suspect locking cleanup issue in mdt_create()