https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-7893 Lustre <p>When a ZFS-backed target is mounted, and dmu_objset_own() fails, osd_mount() follows a goto err: and calls dmu_objset_disown(NULL). This triggers a kernel panic due to NULL pointer dereference.</p> <p>dmu_objset_disown() should only be called if the dmu_objset_own() succeeded.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Call Trace: osd_mount+0x435/0x1130 [osd_zfs] ? keys_fill+0xd5/0x1b0 [obdclass] ? kmem_cache_alloc_trace+0x1cf/0x1e0 osd_device_alloc+0x266/0x290 [osd_zfs] obd_setup+0x1bf/0x290 [obdclass] class_setup+0x259/0x930 [obdclass] class_process_config+0x1151/0x24c0 [obdclass] ? do_lcfg+0x198/0x9f0 [obdclass] ? __kmalloc+0x22c/0x240 do_lcfg+0x2cf/0x9f0 [obdclass] lustre_start_simple+0x94/0x200 [obdclass] osd_start+0x54f/0x840 [obdclass] ? simple_strtoull+0x2c/0x50 ? simple_strtoul+0x9/0x10 ? target_name2index+0x78/0xc0 [obdclass] server_fill_super+0x253/0x1450 [obdclass] ? libcfs_debug_msg+0x41/0x50 [libcfs] lustre_fill_super+0x348/0x8c0 [obdclass] ? lustre_fill_super+0x0/0x8c0 [obdclass] get_sb_nodev+0x5f/0xa0 lustre_get_sb+0x25/0x30 [obdclass] vfs_kern_mount+0x7b/0x1b0 do_kern_mount+0x52/0x130 do_mount+0x2fb/0x930 sys_mount+0x90/0xe0 system_call_fastpath+0x16/0x1b </pre> </div></div> lustre-2.8.0-2.6.32_573.18.1.1chaos.ch5.4.x86_64_g0bbc784<br/> TOSS 2.4-7 (based on RHEL 6.7) LU-7893

osd-zfs: calls dmu_objset_disown() with NULL objset_t *

Bug Minor Resolved Fixed Nathaniel Clark Olaf Faaland llnl patch zfs Mon, 21 Mar 2016 20:19:22 +0000 Thu, 9 Feb 2017 17:10:57 +0000 Mon, 11 Apr 2016 13:55:30 +0000 Lustre 2.8.0 Lustre 2.9.0 0 7 <p>The system this occurred on in testing is at 2_8_RC4, but this code is no different in 2_8_0 or in master.</p> <p>Olaf Faaland-LLNL (faaland1@llnl.gov) uploaded a new patch: <a href="http://review.whamcloud.com/19052" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/19052</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7893" title="osd-zfs: calls dmu_objset_disown() with NULL objset_t *" class="issue-link" data-issue-key="LU-7893"><del>LU-7893</del></a> osd-zfs: calls dmu_objset_disown() with NULL<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: d6df23ed4529ae1f75824d1284cde86756ada948</p> <p>Other calls to dmu_objset_disown() were already conditional on o-&gt;od_os != NULL.</p> <p>Nathaniel</p> <p>Could you pleae keep an eye on the test runs for this change?</p> <p>Thanks</p> <p>Peter</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/19052/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/19052/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7893" title="osd-zfs: calls dmu_objset_disown() with NULL objset_t *" class="issue-link" data-issue-key="LU-7893"><del>LU-7893</del></a> osd-zfs: calls dmu_objset_disown() with NULL<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 1b8adfc4945860444d64719d076c4e14c0544384</p> <p>Landed to master for 2.9.0</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/15671/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/15671/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7893" title="osd-zfs: calls dmu_objset_disown() with NULL objset_t *" class="issue-link" data-issue-key="LU-7893"><del>LU-7893</del></a> osd-zfs: fix error handling in osd_mount()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 0704fcd0e620e66743be1010c8eb1faed4d206d0</p> Duplicate LU-7921 Related Development Rank 1|hzy54v: Rank (Obsolete) 9223372036854775807 Severity