https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-7899 Lustre <p>moving EAs from nvlist into bonus/spill is quite expensive, we can save on this a bit collecting changes in nvlist (what we do already) and calling sa_update() from osd_trans_stop().</p> LU-7899

osd_xattr_set() to batch actual EA update

Improvement Minor Resolved Fixed Alex Zhuravlev Alex Zhuravlev Tue, 22 Mar 2016 14:33:02 +0000 Mon, 21 Aug 2017 21:09:55 +0000 Wed, 9 Aug 2017 04:53:29 +0000 Lustre 2.10.1 Lustre 2.11.0 0 6 <p>Alex Zhuravlev (alexey.zhuravlev@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/19143" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/19143</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7899" title="osd_xattr_set() to batch actual EA update" class="issue-link" data-issue-key="LU-7899"><del>LU-7899</del></a> osd: batch EA updates<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 64ecfcbf26bdb21362adb91c62967a9b7db50faf</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/19143/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/19143/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7899" title="osd_xattr_set() to batch actual EA update" class="issue-link" data-issue-key="LU-7899"><del>LU-7899</del></a> osd: batch EA updates<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 6cd79ab5860c59c2a640a9e8ca4ee86eec050b43</p> <p>Patch has landed to master for 2.9.0</p> <p>Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/21878" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/21878</a><br/> Subject: Revert "<a href="https://jira.whamcloud.com/browse/LU-7899" title="osd_xattr_set() to batch actual EA update" class="issue-link" data-issue-key="LU-7899"><del>LU-7899</del></a> osd: batch EA updates"<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 9e26d30328dbe8bd01740ed9981b3a9ce62a4af0</p> <p>Testing on soak - no longer having soft lockups.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/21878/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/21878/</a><br/> Subject: Revert "<a href="https://jira.whamcloud.com/browse/LU-7899" title="osd_xattr_set() to batch actual EA update" class="issue-link" data-issue-key="LU-7899"><del>LU-7899</del></a> osd: batch EA updates"<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 6fad3abf6f962d04989422cb44dfb7aa0835ad07</p> <p>Oleg has reverted this change</p> <p>Alex Zhuravlev (alexey.zhuravlev@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/21893" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/21893</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7899" title="osd_xattr_set() to batch actual EA update" class="issue-link" data-issue-key="LU-7899"><del>LU-7899</del></a> osd: batch EA updates<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 5cf0af5604a1eed3121d82d90ede98eb6207f3c7</p> <p>Soak testing started: 2017-05-24 21:29:31</p> <p>Immediately hit <a href="https://jira.whamcloud.com/browse/LU-9504" title="LBUG ptlrpc_handle_rs()) ASSERTION( lock != ((void *)0) ) failed" class="issue-link" data-issue-key="LU-9504"><del>LU-9504</del></a>. Have to roll up multiple fixes to get a possible working build, will work on that Friday. </p> <p>thanks... working on that.</p> <p>hmm, I still can't reproduce it <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/> Cliff, is it possible to run with just this patch and watch slabtop output along the run?</p> <p>We need a decent working baseline to apply this patch too. That is the problem. <a href="https://jira.whamcloud.com/browse/LU-9504" title="LBUG ptlrpc_handle_rs()) ASSERTION( lock != ((void *)0) ) failed" class="issue-link" data-issue-key="LU-9504"><del>LU-9504</del></a> currently kills the system too quickly, we must have a fix for that in the baseline. </p> <p>Since we have landed <a href="https://jira.whamcloud.com/browse/LU-9504" title="LBUG ptlrpc_handle_rs()) ASSERTION( lock != ((void *)0) ) failed" class="issue-link" data-issue-key="LU-9504"><del>LU-9504</del></a>, can this patch be rebased? I will be able to run it on soak.</p> <p>Cliff, the patch has been rebased. please, give it a run. thanks in advance.</p> <p>I am seeing more odd job failures. Things like:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">07/21/2017 19:10:37: <span class="code-object">Process</span> 0(soak-16.spirit.hpdd.intel.com): FAILED in mdtest_stat, unable to stat file: Input/output error 34395-simul.out:19:32:08: <span class="code-object">Process</span> 10(soak-26.spirit.hpdd.intel.com): FAILED in simul_file_stat, stat failed: Input/output error 34409-simul.out:19:31:50: <span class="code-object">Process</span> 12(soak-26.spirit.hpdd.intel.com): FAILED in simul_truncate, truncate failed: Cannot send after transport endpoint shutdown 34442-simul.out:19:10:37: <span class="code-object">Process</span> 0(soak-16.spirit.hpdd.intel.com): FAILED in create_files, write in file /mnt/soaked/soaktest/test/simul/34442/simul_write.12: Input/output error 34454-mdtestssf.out:07/21/2017 19:10:37: <span class="code-object">Process</span> 0(soak-16.spirit.hpdd.intel.com): FAILED in mdtest_stat, unable to stat file: Input/output error 34454-mdtestssf.out:07/21/2017 19:10:37: <span class="code-object">Process</span> 1(soak-16.spirit.hpdd.intel.com): FAILED in mdtest_stat, unable to stat file: Input/output error 34462-simul.out:19:25:28: <span class="code-object">Process</span> 26(soak-29.spirit.hpdd.intel.com): FAILED in simul_truncate, truncate failed: Input/output error </pre> </div></div> <p>investigating.</p> <p>With this patch, i am seeing more jobs fail than succeed.</p> <p>Cliff, any more details?</p> <p>What are you looking for from slab top? No hard crashes yet, restarting this morning.</p> <p>Tested latest version of the patch, ran 24 hours on soak, so far. No significant errors. </p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="https://review.whamcloud.com/21893/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/21893/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7899" title="osd_xattr_set() to batch actual EA update" class="issue-link" data-issue-key="LU-7899"><del>LU-7899</del></a> osd: batch EA updates<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 2c9ff6dffdf4320af95c9db9af07a416529275f0</p> <p>Landed for 2.11</p> <p>Minh Diep (minh.diep@intel.com) uploaded a new patch: <a href="https://review.whamcloud.com/28482" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28482</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7899" title="osd_xattr_set() to batch actual EA update" class="issue-link" data-issue-key="LU-7899"><del>LU-7899</del></a> osd: batch EA updates<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: 1<br/> Commit: 214a6c3d66456ff5f73fce8eb06b0b8e164347f7</p> <p>John L. Hammond (john.hammond@intel.com) merged in patch <a href="https://review.whamcloud.com/28482/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/28482/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7899" title="osd_xattr_set() to batch actual EA update" class="issue-link" data-issue-key="LU-7899"><del>LU-7899</del></a> osd: batch EA updates<br/> Project: fs/lustre-release<br/> Branch: b2_10<br/> Current Patch Set: <br/> Commit: d53a1183058ebfd52bf61b194d151369ba7c5087</p> Blocker LU-7895 Related LU-8449 Development Rank 1|hzy593: Rank (Obsolete) 9223372036854775807