https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-790 Lustre <p>After I set up a Lustre server and ran "lctl get_param -n version", I got:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[root@fat-intel-2 ~]# uname -a Linux fat-intel-2.lab.whamcloud.com 2.6.18-238.19.1.el5_lustre.g42758c3 #1 SMP Wed Oct 5 21:19:10 PDT 2011 x86_64 x86_64 x86_64 GNU/Linux [root@fat-intel-2 ~]# lctl get_param -n version lustre: 2.1.50 kernel: patchless_client build: jenkins-gb05ed4f-PRISTINE-2.6.18-238.19.1.el5_lustre.g42758c3 </pre> </div></div> <p>The node is not a patchless Lustre client, but the above command showed "kernel: patchless_client", which is confusable.</p> <p>The "patchless_client" string is hard-coded in obd_proc_read_version() as Lustre kernel version without doing some checks.</p> LU-790

"patchless_client" is hard-coded as Lustre kernel version

Bug Minor Resolved Fixed Andreas Dilger Jian Yu Tue, 25 Oct 2011 04:05:46 +0000 Sun, 31 Jul 2016 14:02:55 +0000 Tue, 26 May 2015 17:33:13 +0000 Lustre 2.1.0 Lustre 1.8.6 Lustre 2.8.0 0 5 <p>This is as it is for historical reasons. "patchless_client" means that the client does not use any VFS patches, as were needed in the past. The earlier clients would report a numeric value here, as reported in lustre/kernel_patches/patches/lustre_version.h, depending on what kernel patches were applied.</p> <p>Since all Lustre clients are now patchless, the "patchless_client" string has relatively little use, and could be removed. It would also be useful to delete the lines in lustre/tests/sanity.sh that are using check_kernel_version(), since those checks will always be true today.</p> <p>Care should be taken with test_51b() which uses this check to set a default parameter. The comment there seems to be old and useless, since the test has been running with NUMTEST=31000 for a long time.</p> <p>The changes to remove "patchless_client" string will be committed under <a href="https://jira.whamcloud.com/browse/LU-2024" title="sanity-scrub test was not run" class="issue-link" data-issue-key="LU-2024"><del>LU-2024</del></a> (<a href="https://jira.hpdd.intel.com/browse/LU-2024" class="external-link" target="_blank" rel="nofollow noopener">https://jira.hpdd.intel.com/browse/LU-2024</a>) and the patch for the same is:<br/> <a href="http://review.whamcloud.com/#change,4173" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,4173</a> </p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/4173/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4173/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-790" title="&quot;patchless_client&quot; is hard-coded as Lustre kernel version" class="issue-link" data-issue-key="LU-790"><del>LU-790</del></a> tests: clean up lustre version checking<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 2a223541d299bc8287472a671152ee3ded3b7b86</p> <p>Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/14768" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/14768</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-790" title="&quot;patchless_client&quot; is hard-coded as Lustre kernel version" class="issue-link" data-issue-key="LU-790"><del>LU-790</del></a> tests: remove old get_lustre_version() calls<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 360e73a61d1f815853fcb78ab25743821f334fd8</p> <p>Andreas Dilger (andreas.dilger@intel.com) merged in patch <a href="http://review.whamcloud.com/14768/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/14768/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-790" title="&quot;patchless_client&quot; is hard-coded as Lustre kernel version" class="issue-link" data-issue-key="LU-790"><del>LU-790</del></a> tests: remove old get_lustre_version() calls<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 583fef9966f2e531b1c255cabaf1fbaa323e8e5d</p> <p>Landed to master for 2.8.0.</p> Related Development Rank 1|hzvnbz: Rank (Obsolete) 7590 Severity