https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-7900 Lustre <p>lu_object_assign_fid() doesn't need to lookup FID as the FID is supposed to be unique. that lookup was to assert if something went wrong, but it never got hit in the end. it's time to remove that.</p> LU-7900

lu_object_assign_fid() doesn't need to lookup FID

Improvement Minor Resolved Fixed Alex Zhuravlev Alex Zhuravlev Tue, 22 Mar 2016 14:35:09 +0000 Sat, 1 Oct 2016 00:32:00 +0000 Wed, 13 Jul 2016 18:11:48 +0000 Lustre 2.9.0 0 5 <p>Doesn't this depend on the correct operation of the client, which may be OK now, but could break in the future? I agree we don't want to do extra lookups, but our checking of FIDs is already very lax. At a minimum, we should catch duplicate FID usage when the FID is inserted into the OI?</p> <p>For example, we do not verify if a new FID from a client was actually from a SEQ allocated to that client at all. It would be useful to store the last FID SEQs allocated to the client in the export, or keep a global range of valid SEQs for that target (assigned from SEQ master, not more than largest SEQ assigned to client), so that it can verify the incoming FID is (relatively) valid with low effort. Otherwise, we can get into trouble if the client is spewing garbage FIDs, like the 1.8 big-endian clients that didn't swab their incoming SEQ assignments properly. See <a href="https://jira.whamcloud.com/browse/LU-4232" title="MDT and OST should validate incoming FIDs belong to local target" class="issue-link" data-issue-key="LU-4232">LU-4232</a> and <a href="https://jira.whamcloud.com/browse/LU-4233" title="Verify PPC FID swabbed correctly during create. " class="issue-link" data-issue-key="LU-4233">LU-4233</a> for details. </p> <p>this one is used only for OST object being created during striping creation.</p> <p>Alex Zhuravlev (alexey.zhuravlev@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/19081" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/19081</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7900" title="lu_object_assign_fid() doesn&#39;t need to lookup FID" class="issue-link" data-issue-key="LU-7900"><del>LU-7900</del></a> obdclass: lu_object_assign_fid() do not lookup<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: b1d571dd5407c9340fa0750a564e1ccc0c7cd9b5</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/19081/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/19081/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-7900" title="lu_object_assign_fid() doesn&#39;t need to lookup FID" class="issue-link" data-issue-key="LU-7900"><del>LU-7900</del></a> obdclass: lu_object_assign_fid() do not lookup<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: b2d6651eda081139cb168069d256b651a5435781</p> <p>Patch has landed to master for 2.9.0</p> Blocker LU-7895 Related Development Rank 1|hzy59b: Rank (Obsolete) 9223372036854775807