https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-8036 Lustre <p>After <a href="http://review.whamcloud.com/#/c/10029/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/10029/</a> <a href="https://jira.whamcloud.com/browse/LU-4931" title="New feature of giving server/storage side advice of accessing file" class="issue-link" data-issue-key="LU-4931"><del>LU-4931</del></a> ladvise: Add feature of giving file access advices, lustreapi.h unconditionally defines an <tt>ARRAY_SIZE()</tt> macro. This is inappropriate for lustreapi.h and may cause unexpected compilation failures when lustreapi.h is used out of tree (or perhaps even in tree). Instead we should do</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">#ifndef ARRAY_SIZE # define ARRAY_SIZE(a) ... #endif </pre> </div></div> <p>(after all headers have been included) in <tt>lustre/utils/lfs.c</tt> and <tt>lustre/utils/req-layout.c</tt>.</p> LU-8036

lustreapi.h should not define ARRAY_SIZE()

Bug Minor Resolved Fixed John Hammond John Hammond easy llapi tech-debt Mon, 18 Apr 2016 15:36:45 +0000 Wed, 15 Jun 2016 12:52:31 +0000 Wed, 15 Jun 2016 12:52:30 +0000 Lustre 2.9.0 Lustre 2.9.0 0 6 <p>John L. Hammond (john.hammond@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/19818" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/19818</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8036" title="lustreapi.h should not define ARRAY_SIZE()" class="issue-link" data-issue-key="LU-8036"><del>LU-8036</del></a> utils: remove ARRAY_SIZE() define from lustreapi.h<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 6a0110e2b7207af62b94e0882088d56c509065cc</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/19818/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/19818/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8036" title="lustreapi.h should not define ARRAY_SIZE()" class="issue-link" data-issue-key="LU-8036"><del>LU-8036</del></a> utils: remove ARRAY_SIZE() define from lustreapi.h<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 0efd46fd2e685790b49815007dac4484da73f136</p> <p>patch has landed to master for 2.9.0</p> Development Rank 1|hzy8f3: Rank (Obsolete) 9223372036854775807 Severity