https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-8075 Lustre <p>There is a community list of code reviewers at <a href="http://wiki.lustre.org/Code_Reviewers" class="external-link" target="_blank" rel="nofollow noopener">http://wiki.lustre.org/Code_Reviewers</a>. While at LUG 2016, John Hammond volunteered to write a script to automatically add the appropriate reviewers from the list for pull requests. So for example, code affecting the LNDs would automatically the individual signed up for LND work.</p> <p>I'm not sure if the implementation can pull from the wiki page directly or if the data should be mirrored in a more accessible format. I assume that some refactoring may be in order as well. Further, if there are n reviewers listed for a given sub-system, Gerrit would add all n.</p> LU-8075

Automatically add peer reviewers per the lustre.org community reviewers list

Task Minor Reopened Unresolved WC Triage Cory Spitz Wed, 27 Apr 2016 03:25:54 +0000 Sun, 30 Jan 2022 10:07:42 +0000 0 3 <p>Cory, one option is to use a similar method as the MAINTAINERS list in the kernel, with the <tt>scripts/get-maintainers.pl</tt> script to map directories/files to individuals.</p> <p>That said, I've found in the past that having too many people assigned to review a patch can be counter productive, since (I suspect) each individual assumes one of the other people assigned will do the actual work of reviewing the patch. If there are only 2 or 3 people assigned to review a patch it is more likely that they feel they are on the hook and actually do the review.</p> <p>I agree, 2 or 3 people sounds ideal. I'm a fan of the get-maintainers.pl method. That way, things are transparent.</p> <p>The <tt>get_maintainers.pl</tt> script was added in patch <a href="https://review.whamcloud.com/33104" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33104</a> "<tt><a href="https://jira.whamcloud.com/browse/LU-11329" title="add get_maintainer.pl script from kernel" class="issue-link" data-issue-key="LU-11329"><del>LU-11329</del></a> utils: add get_maintainer.pl script</tt>".</p> <p>Note that the get_maintainer.pl script is not <b>automatically</b> adding reviewers to patches. This would need someone to write a small bot to watch patches and add the reviewers, once we had some confidence that the script itself was doing a good job. </p> Duplicate LU-11329 Development Rank 1|hzy9l3: Rank (Obsolete) 9223372036854775807