https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-8095 Lustre <p>Replace the upper-case names with lower-case names for the following static inline functions from LNet:<br/> LNET_NIDADDR<br/> LNET_NIDNET<br/> LNET_MKNID<br/> LNET_NETNUM<br/> LNET_NETTYP<br/> LNET_MKNET</p> LU-8095

switch LNET_* static function names to lower case

Bug Minor Closed Won't Fix Amir Shehata Sebastien Buisson patch Wed, 4 May 2016 08:57:29 +0000 Thu, 15 Oct 2020 13:58:33 +0000 Thu, 15 Oct 2020 13:58:28 +0000 Lustre 2.8.0 0 6 <p>Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: <a href="http://review.whamcloud.com/19964" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/19964</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8095" title="switch LNET_* static function names to lower case" class="issue-link" data-issue-key="LU-8095"><del>LU-8095</del></a> lnet: switch LNET_* static functions to lower case<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 02ef17b50e0c99795cad88cfb1f8cd18cfd065a1</p> <p>Hi Doug,<br/> Can you please have a look at the patch?<br/> Thanks.<br/> Joe</p> <p>This change makes me nervous. These functions are exposed to external software stacks (Cray's DVS for example) so this change would break them very badly.</p> <p>Is this being done in response to a kernel coding guideline?</p> <p>I know they frown on camel case which we also have exported in our LNet layer. It is the same problem in that if we remove the camel case naming of the LNet functions then we break external modules. As for all capital name functions I don't know if they are so strict. I never seen checkpatch complain about this.</p> <p>Hi,</p> <p>I am proposing this patch following Andreas' comment:<br/> <a href="http://review.whamcloud.com/#/c/19792/2/lustre/ldlm/ldlm_lib.c@469" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/19792/2/lustre/ldlm/ldlm_lib.c@469</a></p> Development End date Mon, 9 May 2016 08:57:29 +0000 Rank 1|hzya9b: Rank (Obsolete) 9223372036854775807 Severity Start date Wed, 4 May 2016 08:57:29 +0000