<!-- 
RSS generated by JIRA (9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c) at Sat Feb 10 02:15:18 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Whamcloud Community JIRA</title>
    <link>https://jira.whamcloud.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.4.14</version>
        <build-number>940014</build-number>
        <build-date>05-12-2023</build-date>
    </build-info>


<item>
            <title>[LU-8176] Add file_dentry and file_inode wrappers</title>
                <link>https://jira.whamcloud.com/browse/LU-8176</link>
                <project id="10000" key="LU">Lustre</project>
                    <description>&lt;p&gt;When upstream kernel moved to file-&amp;gt;f_path.dentry and friends, a couple of very convenient wrappers were added:&lt;br/&gt;
file_dentry(file) would return a dentry of the file&lt;br/&gt;
file_inode(file) would return inode of the file.&lt;/p&gt;

&lt;p&gt;Using those instead of the huge monstrosity we have now is probably better, just need to create compat wrappers for code that does not have it yet.&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;&lt;span class=&quot;code-keyword&quot;&gt;static&lt;/span&gt; inline struct inode *file_inode(&lt;span class=&quot;code-keyword&quot;&gt;const&lt;/span&gt; struct file *f)
{       
        &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; f-&amp;gt;f_inode;
}

&lt;span class=&quot;code-keyword&quot;&gt;static&lt;/span&gt; inline struct dentry *file_dentry(&lt;span class=&quot;code-keyword&quot;&gt;const&lt;/span&gt; struct file *file)
{       
        struct dentry *dentry = file-&amp;gt;f_path.dentry;
        
        &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (unlikely(dentry-&amp;gt;d_flags &amp;amp; DCACHE_OP_REAL))
                &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; dentry-&amp;gt;d_op-&amp;gt;d_real(dentry, file_inode(file));
        &lt;span class=&quot;code-keyword&quot;&gt;else&lt;/span&gt;    
                &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; dentry;
}
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</description>
                <environment></environment>
        <key id="37106">LU-8176</key>
            <summary>Add file_dentry and file_inode wrappers</summary>
                <type id="4" iconUrl="https://jira.whamcloud.com/secure/viewavatar?size=xsmall&amp;avatarId=11310&amp;avatarType=issuetype">Improvement</type>
                                            <priority id="4" iconUrl="https://jira.whamcloud.com/images/icons/priorities/minor.svg">Minor</priority>
                        <status id="5" iconUrl="https://jira.whamcloud.com/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="ys">Yang Sheng</assignee>
                                    <reporter username="green">Oleg Drokin</reporter>
                        <labels>
                    </labels>
                <created>Fri, 20 May 2016 16:41:01 +0000</created>
                <updated>Tue, 5 Jul 2016 22:51:08 +0000</updated>
                            <resolved>Tue, 28 Jun 2016 07:35:06 +0000</resolved>
                                                    <fixVersion>Lustre 2.9.0</fixVersion>
                                        <due></due>
                            <votes>0</votes>
                                    <watches>6</watches>
                                                                            <comments>
                            <comment id="153341" author="jgmitter" created="Tue, 24 May 2016 14:56:08 +0000"  >&lt;p&gt;Hi Yang Sheng,&lt;/p&gt;

&lt;p&gt;Would you be able to look into this one?&lt;/p&gt;

&lt;p&gt;Thanks.&lt;br/&gt;
Joe&lt;/p&gt;</comment>
                            <comment id="154363" author="gerrit" created="Thu, 2 Jun 2016 02:37:45 +0000"  >&lt;p&gt;Yang Sheng (yang.sheng@intel.com) uploaded a new patch: &lt;a href=&quot;http://review.whamcloud.com/20576&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/20576&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-8176&quot; title=&quot;Add file_dentry and file_inode wrappers&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-8176&quot;&gt;&lt;del&gt;LU-8176&lt;/del&gt;&lt;/a&gt; libcfs: Add file_dentry&amp;amp;file_inode wrapper&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: 1&lt;br/&gt;
Commit: a9dbdfc2c350666cf0109dc8b537d086920612a5&lt;/p&gt;</comment>
                            <comment id="157047" author="gerrit" created="Mon, 27 Jun 2016 18:56:03 +0000"  >&lt;p&gt;Oleg Drokin (oleg.drokin@intel.com) merged in patch &lt;a href=&quot;http://review.whamcloud.com/20576/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;http://review.whamcloud.com/20576/&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-8176&quot; title=&quot;Add file_dentry and file_inode wrappers&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-8176&quot;&gt;&lt;del&gt;LU-8176&lt;/del&gt;&lt;/a&gt; libcfs: Add file_dentry() &amp;amp; file_inode() wrapper&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: &lt;br/&gt;
Commit: b384b414d88de3cfa4966e731b46e85f62c8e438&lt;/p&gt;</comment>
                            <comment id="157092" author="ys" created="Tue, 28 Jun 2016 07:35:06 +0000"  >&lt;p&gt;Patch landed, Close ticket.&lt;/p&gt;</comment>
                            <comment id="157710" author="hornc" created="Tue, 5 Jul 2016 19:19:59 +0000"  >&lt;p&gt;This causes a build regression for us on SLES 11 SP3 against OFED 3.12-1 and OFED 3.18:&lt;/p&gt;

&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;[  177s] In file included from /usr/src/packages/BUILD/cray-lustre/libcfs/include/libcfs/linux/libcfs.h:92,
[  177s]                  from /usr/src/packages/BUILD/cray-lustre/libcfs/include/libcfs/libcfs.h:43,
[  177s]                  from /usr/src/packages/BUILD/cray-lustre/lnet/klnds/gnilnd/gnilnd.h:67,
[  177s]                  from /usr/src/packages/BUILD/cray-lustre/lnet/klnds/gnilnd/gnilnd.c:25:
[  177s] /usr/src/packages/BUILD/cray-lustre/libcfs/include/libcfs/linux/linux-fs.h:66: error: conflicting types for &apos;backport_file_inode&apos;
[  177s] /usr/src/kernel-modules-ofed/x86_64/cray_ari_s/include/linux/compat-3.12.h:16: error: previous definition of &apos;backport_file_inode&apos; was here
[  177s] In file included from /usr/src/packages/BUILD/cray-lustre/libcfs/include/libcfs/linux/libcfs.h:92,
[  177s]                  from /usr/src/packages/BUILD/cray-lustre/libcfs/include/libcfs/libcfs.h:43,
[  177s]                  from /usr/src/packages/BUILD/cray-lustre/lnet/include/lnet/lib-lnet.h:48,
[  177s]                  from /usr/src/packages/BUILD/cray-lustre/lnet/lnet/api-ni.c:39:
[  177s] /usr/src/packages/BUILD/cray-lustre/libcfs/include/libcfs/linux/linux-fs.h:66: error: conflicting types for &apos;backport_file_inode&apos;
[  177s] /usr/src/kernel-modules-ofed/x86_64/cray_ari_s/include/linux/compat-3.12.h:16: error: previous definition of &apos;backport_file_inode&apos; was here
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</comment>
                            <comment id="157718" author="simmonsja" created="Tue, 5 Jul 2016 22:51:08 +0000"  >&lt;p&gt;Chris their is a fix for this under ticket &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-8352&quot; title=&quot;Mellanox/OFED build breakage due to file_inode macro.&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-8352&quot;&gt;&lt;del&gt;LU-8352&lt;/del&gt;&lt;/a&gt;.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Related</name>
                                            <outwardlinks description="is related to ">
                                        <issuelink>
            <issuekey id="37903">LU-8352</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                            <customfield id="customfield_10890" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10390" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|hzyccn:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>