Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 [LU-8179] libcfs/util/ioctl.h unconditionally redefines __user https://jira.whamcloud.com/browse/LU-8179 Lustre <p>__user attribute is used by sparse to determine what data could and could not be accessed. libcfs/util/ioctl.h is actually incuded by quite a bit of lustre kernel code, not just userspace, so we should make the redefinition conditional.</p> LU-8179 libcfs/util/ioctl.h unconditionally redefines __user Bug Major Resolved Fixed WC Triage Oleg Drokin Sun, 22 May 2016 16:59:37 +0000 Wed, 15 Jun 2016 13:12:59 +0000 Wed, 15 Jun 2016 13:12:59 +0000 Lustre 2.9.0 0 6 <p>Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/20375" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/20375</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8179" title="libcfs/util/ioctl.h unconditionally redefines __user" class="issue-link" data-issue-key="LU-8179"><del>LU-8179</del></a> libcfs: Do not redefine __user for kernel code<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 3e9b1098bd32126bb68824214a3891c78f6bbe35</p> <p>libcfs/util/ioctl.h should never be used in kernel space. As you pointed out it is lustre_ioctl.h that is broken. I rather see lustre_ioctl.h fixed instead.</p> <p>As a side topic __user should be handled more cleaning for user space. The reason for this work around is currently the uapi headers are not exposed to the lustre user land code. Plus if I do that we can remove byteorder.h from libcfs.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/20375/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/20375/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8179" title="libcfs/util/ioctl.h unconditionally redefines __user" class="issue-link" data-issue-key="LU-8179"><del>LU-8179</del></a> libcfs: Do not include libcfs/util/ioctl.h in kernel code<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 0ecdb18ea46790a21f35f60d452e8fc7a50ce838</p> <p>patch has landed to master for 2.9.0</p> Development Rank 1|hzycfr: Rank (Obsolete) 9223372036854775807 Severity