https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-8191 Lustre <p>Here's a bunch of functions that are not declared in any .h files but are not static.</p> <p>Some have prototypes in .c files (also bad practice), mot I bet a lot of them could be converted to static:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">libcfs/libcfs/linux/linux-module.c:111:5: warning: symbol <span class="code-quote">'libcfs_ioctl_getdata'</span> was not declared. Should it be <span class="code-keyword">static</span>? lnet/klnds/o2iblnd/o2iblnd.c:588:1: warning: symbol <span class="code-quote">'kiblnd_debug_conn'</span> was not declared. Should it be <span class="code-keyword">static</span>? lnet/lnet/config.c:444:1: warning: symbol <span class="code-quote">'lnet_print_text_bufs'</span> was not declared. Should it be <span class="code-keyword">static</span>? lnet/selftest/conctl.c:812:1: warning: symbol <span class="code-quote">'lstcon_ioctl_entry'</span> was not declared. Should it be <span class="code-keyword">static</span>? lnet/selftest/module.c:92:1: warning: symbol <span class="code-quote">'lnet_selftest_structure_assertion'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/fid/fid_store.c:67:6: warning: symbol <span class="code-quote">'seq_update_cb'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/fid/fid_store.c:80:5: warning: symbol <span class="code-quote">'seq_update_cb_add'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/fid/lproc_fid.c:346:23: warning: symbol <span class="code-quote">'fldb_sops'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/fid/lproc_fid.c:502:30: warning: symbol <span class="code-quote">'seq_fld_proc_seq_fops'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/fld/lproc_fld.c:272:23: warning: symbol <span class="code-quote">'fldb_sops'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lfsck/lfsck_layout.c:5547:35: warning: symbol <span class="code-quote">'lfsck_layout_assistant_ops'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lfsck/lfsck_namespace.c:6303:35: warning: symbol <span class="code-quote">'lfsck_namespace_assistant_ops'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:139:17: warning: symbol <span class="code-quote">'lmv_get_uuid'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:1652:21: warning: symbol <span class="code-quote">'lmv_locate_target_for_name'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:1749:5: warning: symbol <span class="code-quote">'lmv_create'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:2498:5: warning: symbol <span class="code-quote">'lmv_read_page'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:2810:5: warning: symbol <span class="code-quote">'lmv_set_info_async'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:3005:5: warning: symbol <span class="code-quote">'lmv_set_lock_data'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:3019:16: warning: symbol <span class="code-quote">'lmv_lock_match'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:3062:5: warning: symbol <span class="code-quote">'lmv_get_lustre_md'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:3075:5: warning: symbol <span class="code-quote">'lmv_free_lustre_md'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:3091:5: warning: symbol <span class="code-quote">'lmv_set_open_replay_data'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:3107:5: warning: symbol <span class="code-quote">'lmv_clear_open_replay_data'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:3143:5: warning: symbol <span class="code-quote">'lmv_intent_getattr_async'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:315:5: warning: symbol <span class="code-quote">'lmv_connect_mdc'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:3182:5: warning: symbol <span class="code-quote">'lmv_revalidate_lock'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:3203:5: warning: symbol <span class="code-quote">'lmv_get_fid_from_lsm'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:3224:5: warning: symbol <span class="code-quote">'lmv_quotactl'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:3315:16: warning: symbol <span class="code-quote">'lmv_obd_ops'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lmv/lmv_obd.c:3332:15: warning: symbol <span class="code-quote">'lmv_md_ops'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lod/lod_dev.c:177:19: warning: symbol <span class="code-quote">'lod_txn_callback_kmem'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lod/lod_pool.c:431:6: warning: symbol <span class="code-quote">'lod_dump_pool'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lov/lov_object.c:1545:5: warning: symbol <span class="code-quote">'lov_read_and_clear_async_rc'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/lov/lov_pack.c:236:22: warning: symbol <span class="code-quote">'lov_lsm_alloc'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/mdd/mdd_device.c:510:5: warning: symbol <span class="code-quote">'mdd_changelog_write_header'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/mgc/mgc_request.c:398:1: warning: symbol <span class="code-quote">'llog_process_lock'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/mgs/mgs_fs.c:104:5: warning: symbol <span class="code-quote">'mgs_client_add'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/linux/linux-module.c:77:5: warning: symbol <span class="code-quote">'proc_version'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/llog_osd.c:1295:18: warning: symbol <span class="code-quote">'llog_osd_get_regular_fid_dir'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/llog_swab.c:106:6: warning: symbol <span class="code-quote">'lustre_swab_llogd_conn_body'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/llog_swab.c:115:6: warning: symbol <span class="code-quote">'lustre_swab_ll_fid'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/llog_swab.c:122:6: warning: symbol <span class="code-quote">'lustre_swab_lu_seq_range'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/llog_swab.c:131:6: warning: symbol <span class="code-quote">'lustre_swab_update_ops'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/llog_swab.c:146:6: warning: symbol <span class="code-quote">'lustre_swab_llog_rec'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/llog_swab.c:339:6: warning: symbol <span class="code-quote">'lustre_swab_llog_hdr'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/llog_swab.c:374:6: warning: symbol <span class="code-quote">'lustre_swab_lustre_cfg'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/llog_swab.c:416:6: warning: symbol <span class="code-quote">'lustre_swab_cfg_marker'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/llog_swab.c:63:6: warning: symbol <span class="code-quote">'lustre_swab_lu_fid'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/llog_swab.c:71:6: warning: symbol <span class="code-quote">'lustre_swab_ost_id'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/llog_swab.c:83:6: warning: symbol <span class="code-quote">'lustre_swab_llog_id'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/llog_swab.c:90:6: warning: symbol <span class="code-quote">'lustre_swab_llogd_body'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/local_storage.c:121:18: warning: symbol <span class="code-quote">'ls_find_dev'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/lprocfs_status.c:2012:5: warning: symbol <span class="code-quote">'lprocfs_obd_rd_max_pages_per_rpc'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/lprocfs_status_server.c:232:5: warning: symbol <span class="code-quote">'lprocfs_exp_print_replydata_seq'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/lprocfs_status_server.c:251:5: warning: symbol <span class="code-quote">'lprocfs_exp_replydata_seq_show'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/lprocfs_status_server.c:45:5: warning: symbol <span class="code-quote">'lprocfs_evict_client_open'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/lprocfs_status_server.c:53:5: warning: symbol <span class="code-quote">'lprocfs_evict_client_release'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/lu_object.c:1387:1: warning: symbol <span class="code-quote">'lu_keys_guard'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/lu_object.c:2095:5: warning: symbol <span class="code-quote">'lu_printk_printer'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/lu_object.c:2106:5: warning: symbol <span class="code-quote">'lu_debugging_setup'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/lu_object.c:2111:6: warning: symbol <span class="code-quote">'lu_context_keys_dump'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/obd_config.c:1015:6: warning: symbol <span class="code-quote">'lustre_register_client_process_config'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/obdclass/obd_config.c:1132:6: warning: symbol <span class="code-quote">'lustre_register_quota_process_config'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/osd-zfs/osd_handler.c:1335:5: warning: symbol <span class="code-quote">'osd_fid_alloc'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/osd-zfs/osd_handler.c:75:19: warning: symbol <span class="code-quote">'osd_object_kmem'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/osd-zfs/osd_index.c:1638:34: warning: symbol <span class="code-quote">'osd_zfs_otable_ops'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/osd-zfs/osd_index.c:493:19: warning: symbol <span class="code-quote">'osd_object_find'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/osd-zfs/osd_io.c:924:27: warning: symbol <span class="code-quote">'osd_body_ops'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/osd-zfs/osd_object.c:1199:5: warning: symbol <span class="code-quote">'__osd_attr_init'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/osd-zfs/osd_object.c:186:5: warning: symbol <span class="code-quote">'__osd_object_attr_get'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/osd-zfs/osd_object.c:330:5: warning: symbol <span class="code-quote">'osd_object_init0'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/osd-zfs/osd_oi.c:237:5: warning: symbol <span class="code-quote">'fid_is_on_ost'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/osd-zfs/osd_oi.c:72:14: warning: symbol <span class="code-quote">'osd_oi_count'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/osd-zfs/osd_xattr.c:227:5: warning: symbol <span class="code-quote">'__osd_xattr_get'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/osp/osp_md_object.c:962:5: warning: symbol <span class="code-quote">'osp_md_declare_object_destroy'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/osp/osp_md_object.c:983:5: warning: symbol <span class="code-quote">'osp_md_object_destroy'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/osp/osp_object.c:1530:5: warning: symbol <span class="code-quote">'osp_declare_object_destroy'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/osp/osp_object.c:2024:5: warning: symbol <span class="code-quote">'osp_orphan_it_load'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/osp/osp_sync.c:438:5: warning: symbol <span class="code-quote">'osp_sync_gap'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/osp/osp_trans.c:262:5: warning: symbol <span class="code-quote">'osp_prep_inline_update_req'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ost/ost_handler.c:50:5: warning: symbol <span class="code-quote">'oss_max_threads'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ptlrpc/gss/gss_krb5_mech.c:1893:5: warning: symbol <span class="code-quote">'gss_display_kerberos'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ptlrpc/gss/gss_null_mech.c:140:5: warning: symbol <span class="code-quote">'gss_display_null'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ptlrpc/gss/gss_sk_mech.c:165:5: warning: symbol <span class="code-quote">'gss_display_sk'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ptlrpc/gss/gss_svc_upcall.c:782:6: warning: symbol <span class="code-quote">'gss_secsvc_flush'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ptlrpc/layout.c:2067:6: warning: symbol <span class="code-quote">'__req_capsule_dump'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ptlrpc/../../lustre/ldlm/ldlm_lib.c:2569:6: warning: symbol <span class="code-quote">'target_recovery_fini'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ptlrpc/../../lustre/ldlm/ldlm_lib.c:2590:6: warning: symbol <span class="code-quote">'target_recovery_init'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ptlrpc/../../lustre/target/out_lib.c:91:5: warning: symbol <span class="code-quote">'out_update_header_pack'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ptlrpc/../../lustre/target/tgt_handler.c:1107:5: warning: symbol <span class="code-quote">'tgt_obd_log_cancel'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ptlrpc/nodemap_handler.c:1126:6: warning: symbol <span class="code-quote">'nodemap_config_cleanup'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ptlrpc/nodemap_handler.c:1244:6: warning: symbol <span class="code-quote">'nodemap_mod_exit'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ptlrpc/nodemap_handler.c:1253:5: warning: symbol <span class="code-quote">'nodemap_mod_init'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ptlrpc/nodemap_lproc.c:1021:30: warning: symbol <span class="code-quote">'nodemap_ranges_fops'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ptlrpc/nodemap_lproc.c:1028:30: warning: symbol <span class="code-quote">'nodemap_idmap_fops'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ptlrpc/nodemap_lproc.c:1035:30: warning: symbol <span class="code-quote">'nodemap_exports_fops'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ptlrpc/pack_generic.c:2295:6: warning: symbol <span class="code-quote">'dump_obdo'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/ptlrpc/wiretest.c:49:6: warning: symbol <span class="code-quote">'lustre_assert_wire_constants'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/quota/lproc_quota.c:247:23: warning: symbol <span class="code-quote">'lprocfs_quota_seq_sops'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/quota/lquota_lib.c:41:22: warning: symbol <span class="code-quote">'lquota_caches'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/quota/qmt_dev.c:416:16: warning: symbol <span class="code-quote">'qmt_obd_ops'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/quota/qsd_lib.c:57:19: warning: symbol <span class="code-quote">'upd_kmem'</span> was not declared. Should it be <span class="code-keyword">static</span>? lustre/quota/qsd_lib.c:59:22: warning: symbol <span class="code-quote">'qsd_caches'</span> was not declared. Should it be <span class="code-keyword">static</span>? </pre> </div></div> LU-8191

Candidates for conversion to static functions

Bug Minor Open Unresolved Neil Brown Oleg Drokin easy Sun, 22 May 2016 23:29:46 +0000 Mon, 22 Jan 2024 04:11:14 +0000 Upstream 0 5 <p>Neil is already pushing patches for this.</p> <p>Oleg which tool did you use to find these functions?  We should try to wrap this up</p> <p>My guess is <a href="https://www.kernel.org/doc/html/latest/dev-tools/sparse.html" class="external-link" target="_blank" rel="nofollow noopener">Sparse</a>, based on this <a href="https://patchwork.kernel.org/project/linux-wireless/patch/20191023105407.92131-1-chiu@endlessm.com/" class="external-link" target="_blank" rel="nofollow noopener">patch</a>. The error messages in the commit message seem similar.</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51345" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51345</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> mdt: convert functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: c2d038002885f320dc0cb2af01b436b6fa2a4c84</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51353" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51353</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> ptlrpc: convert functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: d200ac0ca292c0d3340ff48a8b5b7e911943b386</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51427" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51427</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> lnet: convert functions in utils to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 65f38ca7f2684ad9b7348b683db0dda560383bda</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51428" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51428</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> libcfs: convert functions to static, removed function<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 6ac0c768213895e63bbe5b712ee3acf4ea9e012f</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51433" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51433</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> tests: convert functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: e5cfff4ddc0c4fbb2cb279e3af5d65e1b8fe6480</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51434" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51434</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> liblustre: add missing function to header<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 8f9cb5354fdd18b2068682a864ed715b61c67e9c</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51436" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51436</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> lnet: remove unused, fix non-static functions<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: a053c2da560a6684b1dda5ebc4215c6a8d4fb125</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51439" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51439</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> utils: remove unused, fix non-static functions<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 73ed0152add0f634142bba968c833ffc3a35baeb</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51440" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51440</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> obdclass: add static and remove functions<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: a0a969433ba43dbb4d4356cfbaa755b8c9058039</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51441" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51441</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> llite: convert functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 2ed1c93dea43ddd217587e13389c4bd1a8e191b8</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51475" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51475</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> target: convert functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: feea2c967250b1c524ad48e615e735cf5c73cab0</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51476" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51476</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> lustre: convert ec,fid,ldlm,quota functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 066e2f72d1d0741b45ab2437dedc3cec8b952486</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51477" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51477</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> lustre: convert osp,osd,osc,ofd functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 6fa956b5b6404d7340bb8e6b0bacfaf9434922e0</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51478" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51478</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> lustre: convert mdc,mdd,mdt,mgc functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 57c58e2735d8e1c330d33dd084ddd3ca410c2208</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51479" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51479</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> lustre: convert lmv,lod,lov functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: a7e79e8517484913cb27c66682c9cfafa431a0fb</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51480" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51480</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> ptlrpc: add missing headers<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 0580c46e43f003a358bc1bcbd7fa114a6a4f2160</p> <p>This should be all of the patches for now. I wrote a Clang plugin to track down these functions, so it warned on everything that gets compiled on my setup. The only major omissions are snmp (since it doesn't get built by default and isn't actively developed), ldiskfs (since it's tough to built against newer mainline kernels), and several of the LNDs. I'll probably revisit those at some point. I combined a couple subsystems per patch for the last few patches, mostly to avoid having to make ~25 3 line patches.</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51353/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51353/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> ptlrpc: convert functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 41d94aa9c9c01fa88ae152625d5ffd97256bab73</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51345/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51345/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> mdt: convert functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: a1d332f613ac41f4a565c3aeca6633fbd618467e</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51433/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51433/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> tests: convert functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 629d6bca95f96bd307d6a9da9b04d73d3fe7c68f</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51436/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51436/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> lnet: remove unused, fix non-static functions<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 43cbc93f1edc493e47fe5c4059bf0bae6a20c207</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51440/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51440/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> obdclass: add static and remove functions<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: b3f0995b772877f0bea5d3d790db441244c3c821</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51441/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51441/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> llite: convert functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: a586a2bbc37879dc22382793d1704e7708b80887</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51475/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51475/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> target: convert functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: bcbf31a9e1bd6399053a5a757b406152f0d65a42</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51476/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51476/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> lustre: convert ec,fid,ldlm,quota functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: bcc828bdf88f8a19e56535ff3840e06065b606b2</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51477/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51477/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> lustre: convert osp,osd,osc,ofd functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 2fa075d10f72f1400e4da9bdcaec905858b0a264</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51478/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51478/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> lustre: convert mdc,mdd,mdt,mgc functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 38d151f2f65d76fc392d356519227a648e114b5f</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51480/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51480/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> ptlrpc: add missing headers<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: fba78a416621343aadeeb4d28df86e422b653bfe</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51427/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51427/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> lnet: convert functions in utils to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: d9cd9992b9e04bfad1ebd755f78d3e96850eaa32</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51428/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51428/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> libcfs: convert functions to static, removed function<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 067dfd8d2701572ebe7246726c14a6e72a78cb33</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51434/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51434/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> liblustre: add missing functions to header<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 25523e5a35138a0534b01ff561169e501cc30787</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/51479/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/51479/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> lustre: convert lmv,lod,lov functions to static<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 78605b74a56a5338aa93bbf394fe35d0f7c17c5b</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/53754" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/53754</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> llverfs: fix non-static functions<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 381c8246a0ac8cca0b6c470f6b45535481ad3cf3</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/53755" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/53755</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> utils: fix non-static functions in obd.c<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 9c4cfe79fbdb5e5001e65d2fd71057103cc8697e</p> <p>"Timothy Day &lt;timday@amazon.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/53756" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/53756</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8191" title="Candidates for conversion to static functions" class="issue-link" data-issue-key="LU-8191">LU-8191</a> utils: non-static functions in lustre_rsync.c<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 30d9c6aff01abfd27f00151fe4298ccd31b8991f</p> Related LU-6142 LU-16961 Development Rank 1|hzycif: Rank (Obsolete) 9223372036854775807 Severity