https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-8216 Lustre <p> In our production system, when Lustre server crash happen, e2fsck mostly will report Quota accounting mismatch problems. and sometimes there are huge differences.</p> <p> Problems are current Lustre quota codes rely on ldiskfs quota accounting<br/> and if ldiskfs quota is wrong, we need run e2fsck or by disable/enable to fix quota accounting.</p> <p> This encourage me to look quota implement for ldiskfs. while taking at codes<br/> I found there is a big problem with RHEL6 quota codes, that quota updates are<br/> not properly journaled.</p> <p> Every ext4_mark_dquot_dirty is called, we skip and only add quota updates<br/> to dirty list without journal it. This make quota updates only journaled in ext4_quota_write() which can be called in 'sync_file' which only happen<br/> during sync call or umount.</p> <p> This will make big problem if we hit crash, we will lost many quota updates.</p> Running Lustre in RHEL6. LU-8216

Quota updates are not properly journaled

Bug Major Resolved Fixed Niu Yawei Wang Shilong patch Mon, 30 May 2016 14:42:40 +0000 Wed, 12 Oct 2016 15:00:54 +0000 Wed, 22 Jun 2016 15:14:28 +0000 Lustre 2.8.0 Lustre 2.9.0 0 8 <p>Wang Shilong (wshilong@ddn.com) uploaded a new patch: <a href="http://review.whamcloud.com/20503" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/20503</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8216" title="Quota updates are not properly journaled " class="issue-link" data-issue-key="LU-8216"><del>LU-8216</del></a> ldiskfs: fix journal quota files<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 9d519f9900fe1aa6c4d552fea20faf1346f0069a</p> <p>Niu</p> <p>Could you please review this proposed change?</p> <p>Thanks</p> <p>Peter</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/20503/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/20503/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8216" title="Quota updates are not properly journaled " class="issue-link" data-issue-key="LU-8216"><del>LU-8216</del></a> ldiskfs: fix journal quota files<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: d59d553dc18189dfc5e43196f7c8a2bd6346b675</p> <p>I see the change <a href="http://review.whamcloud.com/20503" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/20503</a> updates many of the ldiskfs patch series, but not those for el6.8, el7*, sles12*. Is this change not needed there or was it left out by mistake?</p> <p>Hello Bob Glossman, I think we still need it for el6.8, maybe when i pushed patch, el6.8 is not yet merged into master.</p> <p>Wang Shilong (wshilong@ddn.com) uploaded a new patch: <a href="http://review.whamcloud.com/20791" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/20791</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8216" title="Quota updates are not properly journaled " class="issue-link" data-issue-key="LU-8216"><del>LU-8216</del></a> ldiskfs: fix journal quota files for rhel6.8<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 62056c1d43625696ec719d1f1d7e0f1d477b5c6e</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/20791/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/20791/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8216" title="Quota updates are not properly journaled " class="issue-link" data-issue-key="LU-8216"><del>LU-8216</del></a> ldiskfs: fix journal quota files for RHEL6.8<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e9d2e7d7ef86e322d1fbc9b01e549e133d8cecc5</p> <p>All patches have landed to master for 2.9.0</p> <p>For the record, when we discovered this journaling issue, we added the following mount options to our mdt and osts : </p> <p><tt>usrjquota=lquota.user,grpjquota=lquota.group,jqfmt=vfsv1</tt></p> <p>No fix needed.</p> Related Development End date Mon, 30 May 2016 14:42:40 +0000 Rank 1|hzyd3r: Rank (Obsolete) 9223372036854775807 Severity Start date Mon, 30 May 2016 14:42:40 +0000