Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 [LU-8383] Wrong tests package dependencies https://jira.whamcloud.com/browse/LU-8383 Lustre <p>The patch for <a href="https://jira.whamcloud.com/browse/LU-5614" title="use %kernel_module_package for weak-updates" class="issue-link" data-issue-key="LU-5614"><del>LU-5614</del></a> introduced issue with absence of dependency from tests modules.<br/> Also Build dependency is specified incorrectly.</p> LU-8383 Wrong tests package dependencies Bug Minor Resolved Fixed Dmitry Eremin Dmitry Eremin Fri, 8 Jul 2016 12:18:43 +0000 Mon, 29 Aug 2016 20:52:12 +0000 Fri, 26 Aug 2016 04:05:27 +0000 Lustre 2.9.0 0 6 <p>Dmitry Eremin (dmitry.eremin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/21208" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/21208</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8383" title="Wrong tests package dependencies" class="issue-link" data-issue-key="LU-8383"><del>LU-8383</del></a> build: Spec file cleanup after <a href="https://jira.whamcloud.com/browse/LU-5614" title="use %kernel_module_package for weak-updates" class="issue-link" data-issue-key="LU-5614"><del>LU-5614</del></a><br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: ba973ec97df69912d29c4c12022af4688261d0ca</p> <p>It looks like you want to move the call to %kernel_module_package_buildreqs. But I'm not sure that is correct. Although, admittedly, I don't really understand what they were thinking when they made kernel_module_package_buildreqs.</p> <p>If you use rpmbuild --showrc to look at the definition of kernel_module_package_buildreqs on a RHEL7.2 system, it looks like this:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>-14: kernel_module_package_buildreqs %global kmodtool_generate_buildreqs 1 kernel-devel </pre> </div></div> <p>So what exactly happens when you try to move the call to that macro to be the following?</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>BuildRequires: %kernel_module_package_buildreqs </pre> </div></div> <p>If you try to define a macro on a BuildRequires line, does that even work? Will the "kernel-devel" string, which is on a separate line in the kernel_module_package_buildreqs macro even wind up being added to the BuildRequires?</p> <p>Maybe it is fine. I wish the spec file syntax was more rigorously defined somewhere.</p> <p>Exactly, the string <tt>BuildRequires: %kernel_module_package_buildreqs</tt> will be transformed to <tt>BuildRequires: kernel-devel</tt> and additional macro will be defined.<br/> For now the string "kernel-devel" is appended to package description.<br/> With fixed dependencies build failed on SuSe with following:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>error: Failed build dependencies: kernel-syms is needed by lustre-2.8.55_49_g7174998-1.x86_64 make: *** [srpm] Error 1 </pre> </div></div> <p>So, dependency works now.</p> <p>OK, thats good.</p> <p>Dmitry Eremin (dmitry.eremin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/21228" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/21228</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8383" title="Wrong tests package dependencies" class="issue-link" data-issue-key="LU-8383"><del>LU-8383</del></a> build: Spec file cleanup after <a href="https://jira.whamcloud.com/browse/LU-5614" title="use %kernel_module_package for weak-updates" class="issue-link" data-issue-key="LU-5614"><del>LU-5614</del></a><br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: c36fbd320a0451f203879fa364cffb610db5c9c6</p> <p>Dmitry Eremin (dmitry.eremin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/21229" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/21229</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8383" title="Wrong tests package dependencies" class="issue-link" data-issue-key="LU-8383"><del>LU-8383</del></a> build: Spec file cleanup after <a href="https://jira.whamcloud.com/browse/LU-5614" title="use %kernel_module_package for weak-updates" class="issue-link" data-issue-key="LU-5614"><del>LU-5614</del></a><br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: a2ad8f2d2742f4661f3a52fb2662a5c20b18fb72</p> <p>For SuSe we have <tt>BuildRequires: module-init-tools kernel-syms</tt>. But the package <tt>kernel-syms</tt> is just an empty package.<br/> It is used to group build dependencies for all kernel flavors. The KMP build process will build KMPs against all installed kernel flavors automatically.</p> <p>So, it's not clear how to build lustre packages without this package installed. For now lbuild for SuSe failed with following:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>error: Failed build dependencies: kernel-syms is needed by lustre-2.8.55_49_g7174998-1.x86_64 </pre> </div></div> <p>Have Minh install kernel-syms on all the SLES builders?</p> <p>I installed kernel-syms on all the SLES builders and build is fixed now.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/21208/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/21208/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8383" title="Wrong tests package dependencies" class="issue-link" data-issue-key="LU-8383"><del>LU-8383</del></a> build: Spec file cleanup after <a href="https://jira.whamcloud.com/browse/LU-5614" title="use %kernel_module_package for weak-updates" class="issue-link" data-issue-key="LU-5614"><del>LU-5614</del></a><br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 55836cd0e55eb1912911c6f195412c99852115aa</p> <p>Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/21877" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/21877</a><br/> Subject: Revert "<a href="https://jira.whamcloud.com/browse/LU-8383" title="Wrong tests package dependencies" class="issue-link" data-issue-key="LU-8383"><del>LU-8383</del></a> build: Spec file cleanup after <a href="https://jira.whamcloud.com/browse/LU-5614" title="use %kernel_module_package for weak-updates" class="issue-link" data-issue-key="LU-5614"><del>LU-5614</del></a>"<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: ae9e55067c5830066dc10844ad62b63d3ee0125a</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/21877/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/21877/</a><br/> Subject: Revert "<a href="https://jira.whamcloud.com/browse/LU-8383" title="Wrong tests package dependencies" class="issue-link" data-issue-key="LU-8383"><del>LU-8383</del></a> build: Spec file cleanup after <a href="https://jira.whamcloud.com/browse/LU-5614" title="use %kernel_module_package for weak-updates" class="issue-link" data-issue-key="LU-5614"><del>LU-5614</del></a>"<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 272c136099bb27550202f0a69d72bc6f344284a4</p> <p>Oleg, kernel-syms should be installed on all the SLES builders. This is prerequisite now for SLES.</p> <p>I am working on installing kernel-syms on all SLES builders</p> <p>Dmitry Eremin (dmitry.eremin@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/22125" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/22125</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8383" title="Wrong tests package dependencies" class="issue-link" data-issue-key="LU-8383"><del>LU-8383</del></a> build: Spec file cleanup after <a href="https://jira.whamcloud.com/browse/LU-5614" title="use %kernel_module_package for weak-updates" class="issue-link" data-issue-key="LU-5614"><del>LU-5614</del></a><br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 0dca982b6658e31c50f7c5bad2c3b980929a22d4</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/22125/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/22125/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8383" title="Wrong tests package dependencies" class="issue-link" data-issue-key="LU-8383"><del>LU-8383</del></a> build: Spec file cleanup after <a href="https://jira.whamcloud.com/browse/LU-5614" title="use %kernel_module_package for weak-updates" class="issue-link" data-issue-key="LU-5614"><del>LU-5614</del></a><br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 656f9f0ddecec0a06fd38b9a0d67d46cec2e67ff</p> Related LU-5614 Development Rank 1|hzygyn: Rank (Obsolete) 9223372036854775807 Severity