https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-8514 Lustre <p>Running Lustre version 2.8.0_0.0.llnlpreview.33 (see repo lustre-release-fe-llnl), we hit the following assertion on one of our MDS nodes (out of 16) in our 2.8 DNE testbed:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>2016-08-18 05:45:32 [47956.538091] LustreError: 17552:0:(llog_cat.c:385:llog_cat_current_log()) lquake-MDT0004-osd: next log does not exist! 2016-08-18 05:45:32 [47956.550273] LustreError: 17552:0:(update_trans.c:1006:top_trans_stop()) lquake-MDT0004-osd: write updates failed: rc = -14 2016-08-18 05:45:32 [47956.592024] LustreError: 15805:0:(tgt_main.c:121:tgt_cancel_slc_locks()) ASSERTION( lock-&gt;l_client_cookie != 0 ) failed: 2016-08-18 05:45:32 [47956.604585] LustreError: 15805:0:(tgt_main.c:121:tgt_cancel_slc_locks()) LBUG 2016-08-18 05:45:32 [47956.612773] Pid: 15805, comm: tx_commit_cb </pre> </div></div> <p>Note that the "next log does not exist!" message was introduced by the patch from <a href="https://jira.whamcloud.com/browse/LU-7800" title="Panic during recovery of soak-test." class="issue-link" data-issue-key="LU-7800"><del>LU-7800</del></a>, Change-Id: I2343023c1f3109c077c98d78d3669377d95ed42f, Patch-Set: 6.</p> LU-8514

tgt_main.c:121:tgt_cancel_slc_locks()) ASSERTION( lock->l_client_cookie != 0 ) failed

Bug Critical Resolved Fixed Lai Siyao Christopher Morrone llnl Thu, 18 Aug 2016 21:17:35 +0000 Tue, 14 Mar 2017 21:11:50 +0000 Fri, 2 Sep 2016 04:38:41 +0000 Lustre 2.9.0 0 6 <p>Lai</p> <p>Could you please look into this one?</p> <p>Thanks</p> <p>Peter</p> <p>Lai, It looks like we should not save slc locks if transaction fails?</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>static void mdt_save_remote_lock(struct mdt_thread_info *info, struct lustre_handle *h, enum ldlm_mode mode, int decref) { ENTRY; if (lustre_handle_is_used(h)) { if (decref || !info-&gt;mti_has_trans || !(mode &amp; (LCK_PW | LCK_EX))) { ----&gt; check failure transaction here. ldlm_lock_decref_and_cancel(h, mode); } else { struct ldlm_lock *lock = ldlm_handle2lock(h); struct ptlrpc_request *req = mdt_info_req(info); LASSERT(req != NULL); tgt_save_slc_lock(lock, req-&gt;rq_transno); ldlm_lock_decref(h, mode); } h-&gt;cookie = 0ull; } EXIT; } </pre> </div></div> <p>IMHO the cause if transaction failure is not checked in mdt handlers, do you know why it's always ignored?</p> <p>We hit this a couple of more times. Now it is hitting almost as soon as the MDS is brought back up. This is currently our worst blocker in testing on the DNE testbed.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>IMHO the cause if transaction failure is not checked in mdt handlers, do you know why it's always ignored? </pre> </div></div> <p>Usually if the transaction fails, info-&gt;mti_has_trans should not be set, but unfortunately for this case, the local transaction succeeds (i.e. info-&gt;mti_has_trans is set), but the remote transaction fails, so I think you need add another flag or sth to check this failure.</p> <p>Lai Siyao (lai.siyao@intel.com) uploaded a new patch: <a href="http://review.whamcloud.com/22071" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/22071</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8514" title="tgt_main.c:121:tgt_cancel_slc_locks()) ASSERTION( lock-&gt;l_client_cookie != 0 ) failed" class="issue-link" data-issue-key="LU-8514"><del>LU-8514</del></a> mdd: transaction failure should be checked<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: b1d88d35ee5b156aed9a3c4ab61fedc8f1821257</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/22071/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/22071/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8514" title="tgt_main.c:121:tgt_cancel_slc_locks()) ASSERTION( lock-&gt;l_client_cookie != 0 ) failed" class="issue-link" data-issue-key="LU-8514"><del>LU-8514</del></a> mdd: transaction failure should be checked<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e1ace3751f9add26b3f01aad9c278b6bfca8f739</p> <p>Landed for 2.9</p> Related Development Rank 1|hzyl9z: Rank (Obsolete) 9223372036854775807 Severity