https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-8534 Lustre <p>Locally I need to get Lustre built against an <del>alpha</del> kernel for RHEL7.3 beta. I started with the ldiskfs-3.10-rhel7.2.series, and hit the following issue.</p> <p>It appears that patch 923ae0ff9250430133b3310fe62c47538cf1cbc1 from the upsteam linux kernel is in this new pre-RHEL7.3 kernel. The patch introduces ext4 DAX support.</p> <p>It adds the following define to fs/ext4/ext4.h:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>+#ifdef CONFIG_FS_DAX +#define EXT4_MOUNT_DAX 0x00200 /* Direct Access */ +#else +#define EXT4_MOUNT_DAX 0 +#endif </pre> </div></div> <p>The ext4-data-in-dirent.patch introduces EXT4_MOUNT_DIRDATA with the same value:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>#define EXT4_MOUNT_DIRDATA 0x00200 /* Data in directory entries*/ </pre> </div></div> <p>I am going to need guidance on that flag conflict.</p> LU-8534

RHEL7.3 ldiskfs patch set

Bug Critical Resolved Fixed Peter Jones Christopher Morrone RHEL7.3 llnl Wed, 24 Aug 2016 03:18:29 +0000 Fri, 2 Dec 2016 22:55:34 +0000 Fri, 18 Nov 2016 16:35:08 +0000 Lustre 2.8.0 Lustre 2.9.0 0 6 <p>It looks like commit 4113c4caa4f removed the use of <tt>EXT4_MOUNT_OLDALLOC 0x00002</tt> in the 3.1 kernel, so it should be usable for RHEL7.x. These EXT4_MOUNT_* constants are only used in-core so changing it isn't critical. It would also be possible to use an EXT4_MOUNT2_DIRDATA constant.</p> <p>Yes, there is no EXT4_MOUNT_* macro using 0x00002. I'll go with that then.</p> <p>Christopher J. Morrone (morrone2@llnl.gov) uploaded a new patch: <a href="http://review.whamcloud.com/22113" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/22113</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8534" title="RHEL7.3 ldiskfs patch set" class="issue-link" data-issue-key="LU-8534"><del>LU-8534</del></a> ldiskfs: Add patch series for RHEL7.3<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: bf02c36601bbc7628b3fbd4ece726f46b08778e4</p> <p>The <a href="http://review.whamcloud.com/22113" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/22113</a> is a pretty naive refresh of the ldiskfs patches for RHEL7.3.</p> <p>The ext4-corrupted-inode-block-bitmaps-handling-patches.patch in particular probably needs scrutiny. The upstream kernel adds this at the beginning of the ext4/balloc.c:ext4_init_block_bitmap() function:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">if</span> (buffer_verified(bh) || EXT4_MB_GRP_BBITMAP_CORRUPT(grp)) <span class="code-keyword">return</span>; </pre> </div></div> <p>Previously the patch removed the declaration and definition of "grp". I reintroduced that line. I have no idea if that is correct.</p> <p>Also there was a simple contextual conflic in ext4/balloc.c:ext4_read_block_bitmap_nowait() here:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> set_buffer_uptodate(bh); ext4_unlock_group(sb, block_group); unlock_buffer(bh); - <span class="code-keyword">if</span> (err) - ext4_error(sb, <span class="code-quote">"Checksum bad <span class="code-keyword">for</span> grp %u"</span>, block_group); <span class="code-keyword">goto</span> verify; } </pre> </div></div> <p>Previously there was a return where now there is "goto verify;". The naive contextual resolution was simple, but someone should look into whether the broader logic still makes sense.</p> <p>Ping. Review still needed here.</p> <p>it looks fine to me, but should really include brand new el7.2 ldiskfs patch. Just landed in master. see <a href="https://jira.whamcloud.com/browse/LU-8327" title="conf_sanity test_61: soft lockup" class="issue-link" data-issue-key="LU-8327"><del>LU-8327</del></a>.</p> <p>Please put the review in gerrit. Thanks.</p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/22113/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/22113/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-8534" title="RHEL7.3 ldiskfs patch set" class="issue-link" data-issue-key="LU-8534"><del>LU-8534</del></a> ldiskfs: Add patch series for RHEL7.3<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: adc9592d1820d5086e52e387008263b4dace9b0e</p> <p>Landed for 2.9</p> Blocker LU-8796 Related LU-8571 Development Rank 1|hzylxb: Rank (Obsolete) 9223372036854775807 Severity